LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	LKML <linux-kernel@vger.kernel.org>,
	clameter@sgi.com, GOTO <y-goto@jp.fujitsu.com>
Subject: Re: [BUG][PATCH] fix mempolcy's check on a system with memory-less-node take2
Date: Thu, 8 Feb 2007 09:19:16 +0100	[thread overview]
Message-ID: <200702080919.16879.ak@suse.de> (raw)
In-Reply-To: <20070208000857.7296b94b.akpm@linux-foundation.org>

On Thursday 08 February 2007 09:08, Andrew Morton wrote:
> On Thu, 8 Feb 2007 09:03:46 +0100 Andi Kleen <ak@suse.de> wrote:
> 
> > On Thursday 08 February 2007 09:00, Andrew Morton wrote:
> > > On Thu, 8 Feb 2007 08:49:41 +0100 Andi Kleen <ak@suse.de> wrote:
> > > 
> > > > 
> > > > > This panic(hang) was found by a numa test-set on a system with 3 nodes, where
> > > > > node(2) was memory-less-node.
> > > > 
> > > > I still think it's the wrong fix -- just get rid of the memory less node.
> > > 
> > > "Let's break it even more"?
> > 
> > I still don't get what you believe what would be broken then.
> 
> A node with no memory is physical reality.  The kernel should do its best
> handle and report it accurately. 

What would be the advantage of that? 

The reason we present nodes to user space is that we can tell the user
where the memory is. You seem to try to promote it to some abstract entity
beyond that, but that doesn't seem particularly fruitful to me. I think
I prefer "down to earth" memory nodes.

> Pretending that the CPUs on that node are 
> local to a different node's memory (as I understand your proposal) goes
> against that.

Well it is then most local to that node's memory.

> 
> > > > I expect you'll likely run into more problems with that setup anyways.
> > > 
> > > What happens if he doesn't run into more problems?
> > 
> > Then he's lucky. I ran into problems at least when I still had the empty
> > nodes some time ago on x86-64.  Christoph said SN2 is doing the same.
> > 
> > iirc slab blew up at least, but that  might be fixed by now. But it's a little risky 
> > because there is more code now that is node aware.
> > 
> 
> Well...  I'd suggest that we try to struggle on, get it working.  Is there
> a downside to doing that?  

The main problem I used to have was regressions. e.g. having memory
less nodes in different combinations would break in new releases.
(on x86-64 this depends on how the DIMMs are distributed so sometimes
breakage wasn't noticed for a long time. We ended up trying all combinations
on a simulator in the end). Assigning to nearby nodes avoided that special
case.

Ok there is still one other case -- nodes that have memory, but not enough
to do anything useful. This can happen too, but is still somewhat different.
Basically all kmalloc_node() need to fail gratiously.

-Andi

  reply	other threads:[~2007-02-08  8:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08  2:06 KAMEZAWA Hiroyuki
2007-02-08  7:49 ` Andi Kleen
2007-02-08  8:00   ` Andrew Morton
2007-02-08  8:03     ` Andi Kleen
2007-02-08  8:08       ` Andrew Morton
2007-02-08  8:19         ` Andi Kleen [this message]
2007-02-08  8:24           ` Andrew Morton
2007-02-08  8:16   ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702080919.16879.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=y-goto@jp.fujitsu.com \
    --subject='Re: [BUG][PATCH] fix mempolcy'\''s check on a system with memory-less-node take2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).