LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Kconfig:  Remove DEBUG_RWSEMS
@ 2007-02-08 22:06 Robert P. J. Day
  2007-02-08 22:19 ` Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2007-02-08 22:06 UTC (permalink / raw)
  To: Linux kernel mailing list; +Cc: Linus Torvalds, Roman Zippel


  Remove the final vestiges of the kernel config option DEBUG_RWSEMS,
since it has no value, at least at the moment.

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

  my apologies for pushing this so high up the food chain, but i want
to submit another patch that sits *right* next to this one in the
Kconfig.debug file so i either have to do it in two steps, or submit
those two changes as a single patch, and i don't like doing that.

  so if this can go in in short order, well, that would be just ducky.
if it can't, then just toss it and i'll move on to that second patch.


diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 5c26818..356a5ab 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -181,19 +181,11 @@ config DEBUG_MUTEXES
 	 This feature allows mutex semantics violations to be detected and
 	 reported.

-config DEBUG_RWSEMS
-	bool "RW-sem debugging: basic checks"
-	depends on DEBUG_KERNEL
-	help
-	 This feature allows read-write semaphore semantics violations to
-	 be detected and reported.
-
 config DEBUG_LOCK_ALLOC
 	bool "Lock debugging: detect incorrect freeing of live locks"
 	depends on DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT
 	select DEBUG_SPINLOCK
 	select DEBUG_MUTEXES
-	select DEBUG_RWSEMS
 	select LOCKDEP
 	help
 	 This feature will check whether any held lock (spinlock, rwlock,
@@ -209,7 +201,6 @@ config PROVE_LOCKING
 	select LOCKDEP
 	select DEBUG_SPINLOCK
 	select DEBUG_MUTEXES
-	select DEBUG_RWSEMS
 	select DEBUG_LOCK_ALLOC
 	default n
 	help

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Kconfig:  Remove DEBUG_RWSEMS
  2007-02-08 22:06 [PATCH] Kconfig: Remove DEBUG_RWSEMS Robert P. J. Day
@ 2007-02-08 22:19 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2007-02-08 22:19 UTC (permalink / raw)
  To: Robert P. J. Day; +Cc: Linux kernel mailing list, Linus Torvalds, Roman Zippel

On Thu, 8 Feb 2007 17:06:12 -0500 (EST) Robert P. J. Day wrote:

> 
>   Remove the final vestiges of the kernel config option DEBUG_RWSEMS,
> since it has no value, at least at the moment.
> 
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

no other uses of it.

> ---
> 
>   my apologies for pushing this so high up the food chain, but i want
> to submit another patch that sits *right* next to this one in the
> Kconfig.debug file so i either have to do it in two steps, or submit
> those two changes as a single patch, and i don't like doing that.
> 
>   so if this can go in in short order, well, that would be just ducky.
> if it can't, then just toss it and i'll move on to that second patch.
> 
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 5c26818..356a5ab 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -181,19 +181,11 @@ config DEBUG_MUTEXES
>  	 This feature allows mutex semantics violations to be detected and
>  	 reported.
> 
> -config DEBUG_RWSEMS
> -	bool "RW-sem debugging: basic checks"
> -	depends on DEBUG_KERNEL
> -	help
> -	 This feature allows read-write semaphore semantics violations to
> -	 be detected and reported.
> -
>  config DEBUG_LOCK_ALLOC
>  	bool "Lock debugging: detect incorrect freeing of live locks"
>  	depends on DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT
>  	select DEBUG_SPINLOCK
>  	select DEBUG_MUTEXES
> -	select DEBUG_RWSEMS
>  	select LOCKDEP
>  	help
>  	 This feature will check whether any held lock (spinlock, rwlock,
> @@ -209,7 +201,6 @@ config PROVE_LOCKING
>  	select LOCKDEP
>  	select DEBUG_SPINLOCK
>  	select DEBUG_MUTEXES
> -	select DEBUG_RWSEMS
>  	select DEBUG_LOCK_ALLOC
>  	default n
>  	help
> 
> -- 

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-02-08 22:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-08 22:06 [PATCH] Kconfig: Remove DEBUG_RWSEMS Robert P. J. Day
2007-02-08 22:19 ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).