LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org, clameter@sgi.com, akpm@osdl.org,
	y-goto@jp.fujitsu.com
Subject: Re: [BUG][PATCH] fix mempolcy's check on a system with memory-less-node take2
Date: Thu, 8 Feb 2007 17:16:10 +0900	[thread overview]
Message-ID: <20070208171610.d1bea5d2.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <200702080849.42167.ak@suse.de>

On Thu, 8 Feb 2007 08:49:41 +0100
Andi Kleen <ak@suse.de> wrote:

> 
> > This panic(hang) was found by a numa test-set on a system with 3 nodes, where
> > node(2) was memory-less-node.
> 
> I still think it's the wrong fix -- just get rid of the memory less node.
> I expect you'll likely run into more problems with that setup anyways.
> 
memory-less-node problem is a bit big issue for this small bug.

For removing memory-less-node, we'll have to make consensus on 
"a node represents a group of memory, not cpu, not devices"

I read old e-mails on node-hotplug again.
In the early stage of node-hotplug, I assumes "a node has memory".
After discussion between several groups, I knew there are people
who consider groups of something as node.
(and we had to change our plan......)
like this (old) homepage's FAQ 5. http://lse.sourceforge.net/numa/faq/


> >  static struct mempolicy *mpol_new(int mode, nodemask_t *nodes)
> >  {
> >  	struct mempolicy *policy;
> > +	void  *val;
> 
> Using void * here is nasty when it's a zonelist pointer.
> 
okay. changes this to be more neat one..take3 will come.

-Kame





      parent reply	other threads:[~2007-02-08  8:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08  2:06 KAMEZAWA Hiroyuki
2007-02-08  7:49 ` Andi Kleen
2007-02-08  8:00   ` Andrew Morton
2007-02-08  8:03     ` Andi Kleen
2007-02-08  8:08       ` Andrew Morton
2007-02-08  8:19         ` Andi Kleen
2007-02-08  8:24           ` Andrew Morton
2007-02-08  8:16   ` KAMEZAWA Hiroyuki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070208171610.d1bea5d2.kamezawa.hiroyu@jp.fujitsu.com \
    --to=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=y-goto@jp.fujitsu.com \
    --subject='Re: [BUG][PATCH] fix mempolcy'\''s check on a system with memory-less-node take2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).