LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix cc-option-yn whitespace
Date: Thu,  8 Feb 2007 12:06:35 -0800 (PST)	[thread overview]
Message-ID: <20070208200636.3222518005D@magilla.sf.frob.com> (raw)
In-Reply-To: Linus Torvalds's message of  Wednesday, 7 February 2007 20:34:20 -0800 <Pine.LNX.4.64.0702072024330.8424@woody.linux-foundation.org>

> Yes.. It doesn't seem to happen with make-3.81, for some reason, and I 
> don't see why the leading space happens. Maybe somebody with deep GNU make 
> knowledge knows.

You probably think that's me, but thankfully I have succeeded in forgetting
more about GNU make than anyone else knew.  I wouldn't be much surprised if
3.81 changed some details about whitespace in `call', or in `define', or
something else like that; people keep diddling with make.  At least in the
world I knew, only whitespace after an = or := is stripped like you might
have been expecting, and not whitespace after commas (I mean, why else
would make have the `strip' function?).  All of the $(call foo, a, b) uses
introduce whitespace (vs $(call foo,a,b)).  It's been luck, or silent
careful tweaking, that's made all those work out right so far.  Note also
that the new form of cc-option-yn results in:
      then echo " "y""; \
      else echo " "n""; \
in those commands.  Some other uses of the functions turned into
checker-shell uses might have doubled quotes (i.e. unquoted text) now too.
(People always think make is sh, but it's m4.)

I have long ago sworn off thinking too hard about other people's makefiles
that get arcane with GNU make features.  (You don't feel compelled to watch
every piece of porn on the net that people use Linux to get there, do you?)
So I just did the minimal tweak to fix the concrete regression, though I'd
have to say that the "cleanup" has made things messier and more obfuscated.


Thanks,
Roland

  reply	other threads:[~2007-02-08 20:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08  3:30 Roland McGrath
2007-02-08  4:34 ` Linus Torvalds
2007-02-08 20:06   ` Roland McGrath [this message]
2007-02-08 20:54     ` Oleg Verych

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070208200636.3222518005D@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH] fix cc-option-yn whitespace' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).