LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Oleg Verych <olecom@flower.upol.cz>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: akpm@linux-foundation.org, sam@ravnborg.org,
	linux-kernel@vger.kernel.org
Subject: Re: + search-a-little-harder-for-mkimage.patch added to -mm tree
Date: Thu, 8 Feb 2007 21:25:35 +0100	[thread overview]
Message-ID: <20070208202535.GX22699@flower.upol.cz> (raw)
In-Reply-To: <8bd0f97a0702080628u5038191dm74139a7dd7bff909@mail.gmail.com>

On Thu, Feb 08, 2007 at 09:28:03AM -0500, Mike Frysinger wrote:
> On 2/8/07, Oleg Verych <olecom@flower.upol.cz> wrote:
> >proposition is to substitute:
> >     "$(CONFIG_SHELL) $(MKIMAGE)"
> >with
> >     "mkimage"
> 
> this isnt a one-to-one change ... let's look at the typical
> mkimage-missing scenario ...

You are interested in presents of `mkimage', but yet we discussing its
missing, or "Error -> Don't care" behavior.

uImage, as i can compare with other *final* targets, like bzImage on PC,
must be made in case of `make uImage', or if default rule depends on
it. Thus, if it fails it, must be error. It doesn't matter what cause
it, and what message was printed:

> with mkuboot.sh you'd get output like:
> ...
>  UIMAGE  arch/blackfin/boot/vmImage
> "mkimage" command not found - U-Boot images will not be built
>  Building modules, stage 2.
> ...
> 
> with mkimage you'd get output like:
> ...
>  UIMAGE  arch/blackfin/boot/vmImage
> /bin/sh: mkimage: command not found
> make[1]: *** [arch/blackfin/boot/vmImage] Error 127
> make: *** [vmImage] Error 2

In this example `uImage' is required by final target, e.g.

,-*-
|all: prepare uImage modules_install
|	while things; do them; done
`-*-

> so while you could change all the Makefile's to insert - to ignore
> *all* failures, without the script, you loose the ability to only
> ignore "binary missing" errors

So, are we ignoring our primary (default) goal?

OK, as you wish. As for me it's a plain bloat, but i have neither one
for-embedded setup to propose non-bloating change for _you_ (:.

> -mike
____

  reply	other threads:[~2007-02-08 20:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200702080607.l1867c0D006861@shell0.pdx.osdl.net>
2007-02-08 14:11 ` Oleg Verych
2007-02-08 14:28   ` Mike Frysinger
2007-02-08 20:25     ` Oleg Verych [this message]
2007-02-08 20:35       ` Mike Frysinger
2007-02-08 21:40         ` - " Oleg Verych

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070208202535.GX22699@flower.upol.cz \
    --to=olecom@flower.upol.cz \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=vapier.adi@gmail.com \
    --subject='Re: + search-a-little-harder-for-mkimage.patch added to -mm tree' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).