LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor@insightbb.com>
To: Greg KH <greg@kroah.com>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
	Jeff Garzik <jeff@garzik.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: Network: convert network devices to use struct device instead of class_device
Date: Thu, 8 Feb 2007 22:59:46 -0500	[thread overview]
Message-ID: <200702082259.47685.dtor@insightbb.com> (raw)
In-Reply-To: <20070209005601.GE30794@kroah.com>

On Thursday 08 February 2007 19:56, Greg KH wrote:
> On Thu, Feb 08, 2007 at 12:29:12PM -0500, Dmitry Torokhov wrote:
> > On 2/8/07, Stephen Hemminger <shemminger@linux-foundation.org> wrote:
> > >On Thu, 08 Feb 2007 07:43:18 -0500
> > >Jeff Garzik <jeff@garzik.org> wrote:
> > >
> > >> Linux Kernel Mailing List wrote:
> > >> > Gitweb:     
> > >http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=43cb76d91ee85f579a69d42bc8efc08bac560278
> > >> > Commit:     43cb76d91ee85f579a69d42bc8efc08bac560278
> > >> > Parent:     2943ecf2ed32632473c06f1975db47a7aa98c10f
> > >> > Author:     Greg Kroah-Hartman <gregkh@suse.de>
> > >> > AuthorDate: Tue Apr 9 12:14:34 2002 -0700
> > >> > Committer:  Greg Kroah-Hartman <gregkh@suse.de>
> > >> > CommitDate: Wed Feb 7 10:37:11 2007 -0800
> > >> >
> > >> >     Network: convert network devices to use struct device instead of 
> > >class_device
> > >> >
> > >> >     This lets the network core have the ability to handle 
> > >suspend/resume
> > >> >     issues, if it wants to.
> > >
> > >It fixes a non-problem. I would like to see the network core suspend/resume
> > >proposal as well. Last time I examined doing network core suspend help,
> > >the problem was that the physical device suspend was called before the
> > >class device. It is not clear how this change would help.
> > 
> > If physical devices are registered before class devices then when
> > suspending class devices are naturally suspended first. It is still
> > not clear to me why we need to convert everythign to struct device, I
> > believe I've shown (with patches) that it is possible to integrate
> > struct class_device into PM framework and avoid reshuffling half of
> > the kernel code.
> 
> I don't want to have two separate device trees in the kernel (well, one
> big device tree and a bunch of little class_device trees.)  The code
> duplication in the class_device code is just too much, and I get
> questions all the time as to what the differences are.
>

While duplication of code is a real concern my worry is constant fattening
of struct device. For example most physical devices do not interface
directly with userspace but every single one of them now has dev_t.
Former class_devices do not need suspend/resume early framework either.
And so on, and so forth.
 
> With these slow and gradual changes, we are getting a true, unified,
> device tree, and it will reduce the amount of code and complexity we
> need to maintain and fix in the driver core itself.
> 
> And it should also alow for proper power management functionality, using
> the changes that Linus put into the driver core about 8 months ago.
> 
> Don't worry, I have input patches queued up next for you Dmitry :)
> 

;)

-- 
Dmitry

  reply	other threads:[~2007-02-09  4:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200702080400.l1840lFd002314@hera.kernel.org>
2007-02-08 12:43 ` Jeff Garzik
2007-02-08 15:41   ` Stephen Hemminger
2007-02-08 17:29     ` Dmitry Torokhov
2007-02-09  0:56       ` Greg KH
2007-02-09  3:59         ` Dmitry Torokhov [this message]
2007-02-09  8:22           ` Kay Sievers
2007-02-09 15:28             ` Dmitry Torokhov
2007-02-09 16:48           ` Greg KH
2007-02-20 15:15         ` Dmitry Torokhov
2007-02-09  0:52     ` Greg KH
2007-02-09  0:51   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702082259.47685.dtor@insightbb.com \
    --to=dtor@insightbb.com \
    --cc=greg@kroah.com \
    --cc=jeff@garzik.org \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    --subject='Re: Network: convert network devices to use struct device instead of class_device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).