LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Walrond <andrew@walrond.org>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux header change breaks linux-atm userspace build
Date: Fri, 9 Feb 2007 07:55:41 +0000	[thread overview]
Message-ID: <200702090755.41932.andrew@walrond.org> (raw)
In-Reply-To: <20070208.160142.11599230.davem@davemloft.net>

On Friday 09 February 2007 00:01, David Miller wrote:
> From: Andrew Walrond <andrew@walrond.org>
> Date: Thu, 8 Feb 2007 21:31:25 +0000
>
> > Sometime between 2.6.18.3 and 2.6.20, this change...
> >
> > --- /include/linux/atmarp.h     2007-01-10 16:32:05.000000000 +0000
> > +++ pkg/linux/include/linux/atmarp.h    2007-02-08 20:02:08.000000000
> > +0000 @@ -34,7 +34,7 @@
> >  struct atmarp_ctrl {
> >         enum atmarp_ctrl_type   type;   /* message type */
> >         int                     itf_num;/* interface number (if present)
> > */ -       uint32_t                ip;     /* IP address (act_need only)
> > */ +       __be32                  ip;     /* IP address (act_need only)
> > */ };
> >
> >  #endif
> >
> > was introduced, but __be32 is undefined, so atmarp.h should include
> > linux/types.h
>
> I'll fix this, thanks for reporting.

Actually, it seems that several other atm headers are also missing 
linux/types.h. I guess you can tell which ones have changed recently using 
git (I just patched linux-atm with liberal #include <linux/types.h>). But let 
me know if you want a full list.

Andrew Walrond

      reply	other threads:[~2007-02-09  7:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08 21:31 Andrew Walrond
2007-02-09  0:01 ` David Miller
2007-02-09  7:55   ` Andrew Walrond [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702090755.41932.andrew@walrond.org \
    --to=andrew@walrond.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: Linux header change breaks linux-atm userspace build' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).