LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@osdl.org>, Hugh Dickins <hugh@veritas.com>,
Paul Mundt <lethal@linux-sh.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 1/3 take2] smaps: extract pte walker from smaps code
Date: Fri, 9 Feb 2007 10:15:49 -0600 [thread overview]
Message-ID: <20070209161549.GO16722@waste.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0702070017360.26926@schroedinger.engr.sgi.com>
On Wed, Feb 07, 2007 at 12:30:38AM -0800, Christoph Lameter wrote:
> On Tue, 6 Feb 2007, David Rientjes wrote:
>
> > Extracts the page table entry walker from the smaps-specific code in
> > fs/proc/task_mmu.c. This will be used later for clearing the reference
> > bits on pages to measure the number of pages accessed over a time period
> > through /proc/pid/smaps.
>
> Clearing reference bits? Ummm... That is a pretty inaccurate measure since
> reclaim can remove pages and revert the reference bits. It can never work
> reliably.
>
> > The new struct pte_walker includes the struct vm_area_struct of the memory
> > to walk over. Iteration begins at the start address and completes at the
> > the end address. A pointer to another data structure may be stored in the
> > private field such as the struct mem_size_stats, which acts as the smaps
> > accumulator. For each page table entry in the VMA, the func function is
> > called with the corresponding struct pte_walker, the pte_t, and its
> > address.
>
> Would it be possible to sync up with the people doing the page table
> interface?
Have a pointer to this?
--
Mathematics is the supreme nostalgia of our time.
prev parent reply other threads:[~2007-02-09 16:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-07 6:15 David Rientjes
2007-02-07 6:15 ` [patch 2/3 take2] smaps: add pages referenced count to smaps David Rientjes
2007-02-07 6:15 ` [patch 3/3 take2] smaps: add clear_refs file to clear reference David Rientjes
2007-02-07 6:33 ` Andrew Morton
2007-02-07 6:29 ` [patch 1/3 take2] smaps: extract pte walker from smaps code Paul Mundt
2007-02-07 6:49 ` Andrew Morton
2007-02-07 7:24 ` Paul Mundt
2007-02-09 2:00 ` Matt Mackall
2007-02-09 2:25 ` David Rientjes
2007-02-07 8:30 ` Christoph Lameter
2007-02-07 9:35 ` David Rientjes
2007-02-09 16:15 ` Matt Mackall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070209161549.GO16722@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=hugh@veritas.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--subject='Re: [patch 1/3 take2] smaps: extract pte walker from smaps code' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).