LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 01/34] __initdata cleanup - alpha
       [not found] <200702091711.34441.alon.barlev@gmail.com>
@ 2007-02-09 15:13 ` Alon Bar-Lev
  2007-02-09 16:47   ` Jiri Slaby
  2007-02-09 15:13 ` [PATCH 02/34] __initdata cleanup - arm Alon Bar-Lev
                   ` (33 subsequent siblings)
  34 siblings, 1 reply; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:13 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, rth


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/setup.c linux-2.6.20-rc6-mm3/arch/alpha/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/setup.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/alpha/kernel/setup.c	2007-01-31 22:19:30.000000000 +0200
@@ -122,7 +122,7 @@ static void get_sysnames(unsigned long, 
 			 char **, char **);
 static void determine_cpu_caches (unsigned int);
 
-static char __initdata command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE] = "";
 
 /*
  * The format of "screen_info" is strange, and due to early
diff -urNp linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/smc37c669.c linux-2.6.20-rc6-mm3/arch/alpha/kernel/smc37c669.c
--- linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/smc37c669.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/alpha/kernel/smc37c669.c	2007-01-31 22:19:30.000000000 +0200
@@ -996,7 +996,7 @@ static SMC37c669_CONFIG_REGS *SMC37c669 
 ** and standard ISA IRQs.
 **
 */
-static SMC37c669_IRQ_TRANSLATION_ENTRY *SMC37c669_irq_table __initdata; 
+static SMC37c669_IRQ_TRANSLATION_ENTRY *SMC37c669_irq_table __initdata = NULL; 
 
 /*
 ** The following definition is for the default IRQ 
@@ -1045,7 +1045,7 @@ static SMC37c669_IRQ_TRANSLATION_ENTRY *
 ** ISA DMA channels.
 **
 */
-static SMC37c669_DRQ_TRANSLATION_ENTRY *SMC37c669_drq_table __initdata;
+static SMC37c669_DRQ_TRANSLATION_ENTRY *SMC37c669_drq_table __initdata = NULL;
 
 /*
 ** The following definition is the default DRQ

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 02/34] __initdata cleanup - arm
       [not found] <200702091711.34441.alon.barlev@gmail.com>
  2007-02-09 15:13 ` [PATCH 01/34] __initdata cleanup - alpha Alon Bar-Lev
@ 2007-02-09 15:13 ` Alon Bar-Lev
  2007-02-09 15:14 ` [PATCH 03/34] __initdata cleanup - avr32 Alon Bar-Lev
                   ` (32 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:13 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, spyro


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/arm/kernel/setup.c linux-2.6.20-rc6-mm3/arch/arm/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/arm/kernel/setup.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/arm/kernel/setup.c	2007-01-31 22:19:30.000000000 +0200
@@ -106,7 +106,7 @@ unsigned long phys_initrd_size __initdat
 static struct meminfo meminfo __initdata = { 0, };
 static const char *cpu_name;
 static const char *machine_name;
-static char __initdata command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE] = "";
 
 static char default_command_line[COMMAND_LINE_SIZE] __initdata = CONFIG_CMDLINE;
 static union { char c[4]; unsigned long l; } endian_test __initdata = { { 'l', '?', '?', 'b' } };
@@ -753,7 +753,7 @@ static struct init_tags {
 	{ 0, ATAG_NONE }
 };
 
-static void (*init_machine)(void) __initdata;
+static void (*init_machine)(void) __initdata = NULL;
 
 static int __init customize_machine(void)
 {
diff -urNp linux-2.6.20-rc6-mm3.org/arch/arm26/kernel/setup.c linux-2.6.20-rc6-mm3/arch/arm26/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/arm26/kernel/setup.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/arm26/kernel/setup.c	2007-01-31 22:19:30.000000000 +0200
@@ -80,7 +80,7 @@ unsigned long phys_initrd_size __initdat
 static struct meminfo meminfo __initdata = { 0, };
 static struct proc_info_item proc_info;
 static const char *machine_name;
-static char __initdata command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE] = "";
 
 static char default_command_line[COMMAND_LINE_SIZE] __initdata = CONFIG_CMDLINE;
 

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 03/34] __initdata cleanup - avr32
       [not found] <200702091711.34441.alon.barlev@gmail.com>
  2007-02-09 15:13 ` [PATCH 01/34] __initdata cleanup - alpha Alon Bar-Lev
  2007-02-09 15:13 ` [PATCH 02/34] __initdata cleanup - arm Alon Bar-Lev
@ 2007-02-09 15:14 ` Alon Bar-Lev
  2007-02-09 15:15 ` [PATCH 04/34] __initdata cleanup - frv Alon Bar-Lev
                   ` (31 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:14 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, rmk+lkml


Trivial.

**NOT TESTED***

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/avr32/boards/atstk1000/atstk1002.c linux-2.6.20-rc6-mm3/arch/avr32/boards/atstk1000/atstk1002.c
--- linux-2.6.20-rc6-mm3.org/arch/avr32/boards/atstk1000/atstk1002.c
+++ linux-2.6.20-rc6-mm3/arch/avr32/boards/atstk1000/atstk1002.c
@@ -27,9 +27,9 @@ struct eth_addr {
 	u8 addr[6];
 };
 
-static struct eth_addr __initdata hw_addr[2];
+static struct eth_addr __initdata hw_addr[2] = {{{0}}};
 
-static struct eth_platform_data __initdata eth_data[2];
+static struct eth_platform_data __initdata eth_data[2] = {{0}};
 extern struct lcdc_platform_data atstk1000_fb0_data;
 
 static struct spi_board_info spi_board_info[] __initdata = {
diff -urNp linux-2.6.20-rc6-mm3.org/arch/avr32/boards/atstk1000/setup.c linux-2.6.20-rc6-mm3/arch/avr32/boards/atstk1000/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/avr32/boards/atstk1000/setup.c
+++ linux-2.6.20-rc6-mm3/arch/avr32/boards/atstk1000/setup.c
@@ -17,9 +17,9 @@
 #include <asm/arch/board.h>
 
 /* Initialized by bootloader-specific startup code. */
-struct tag *bootloader_tags __initdata;
+struct tag *bootloader_tags __initdata = NULL;
 
-struct lcdc_platform_data __initdata atstk1000_fb0_data;
+struct lcdc_platform_data __initdata atstk1000_fb0_data = {0};
 
 void __init board_setup_fbmem(unsigned long fbmem_start,
 			      unsigned long fbmem_size)
diff -urNp linux-2.6.20-rc6-mm3.org/arch/avr32/kernel/setup.c linux-2.6.20-rc6-mm3/arch/avr32/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/avr32/kernel/setup.c
+++ linux-2.6.20-rc6-mm3/arch/avr32/kernel/setup.c
@@ -44,13 +44,13 @@ struct avr32_cpuinfo boot_cpu_data = {
 };
 EXPORT_SYMBOL(boot_cpu_data);
 
-static char __initdata command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE] = "";
 
 /*
  * Should be more than enough, but if you have a _really_ complex
  * setup, you might need to increase the size of this...
  */
-static struct tag_mem_range __initdata mem_range_cache[32];
+static struct tag_mem_range __initdata mem_range_cache[32] = {{0}};
 static unsigned mem_range_next_free;
 
 /*
@@ -87,8 +87,8 @@ static struct resource mem_res[] = {
  * Board-specific code may use these variables to set up platform data
  * for the framebuffer driver if fbmem_size is nonzero.
  */
-static unsigned long __initdata fbmem_start;
-static unsigned long __initdata fbmem_size;
+static unsigned long __initdata fbmem_start = 0l;
+static unsigned long __initdata fbmem_size = 0l;
 
 /*
  * "fbmem=xxx[kKmM]" allocates the specified amount of boot memory for

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 04/34] __initdata cleanup - frv
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (2 preceding siblings ...)
  2007-02-09 15:14 ` [PATCH 03/34] __initdata cleanup - avr32 Alon Bar-Lev
@ 2007-02-09 15:15 ` Alon Bar-Lev
  2007-02-09 15:15 ` [PATCH 05/34] __initdata cleanup - h8300 Alon Bar-Lev
                   ` (30 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:15 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/frv/kernel/setup.c linux-2.6.20-rc6-mm3/arch/frv/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/frv/kernel/setup.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/frv/kernel/setup.c	2007-01-31 22:19:30.000000000 +0200
@@ -105,13 +105,13 @@ unsigned long __nongprelbss memory_end;
 unsigned long __nongprelbss dma_coherent_mem_start;
 unsigned long __nongprelbss dma_coherent_mem_end;
 
-unsigned long __initdata __sdram_old_base;
-unsigned long __initdata num_mappedpages;
+unsigned long __initdata __sdram_old_base = 0l;
+unsigned long __initdata num_mappedpages = 0l;
 
 struct cpuinfo_frv __nongprelbss boot_cpu_data;
 
-char __initdata command_line[COMMAND_LINE_SIZE];
-char __initdata redboot_command_line[COMMAND_LINE_SIZE];
+char __initdata command_line[COMMAND_LINE_SIZE] = "";
+char __initdata redboot_command_line[COMMAND_LINE_SIZE] = "";
 
 #ifdef CONFIG_PM
 #define __pminit

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 05/34] __initdata cleanup - h8300
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (3 preceding siblings ...)
  2007-02-09 15:15 ` [PATCH 04/34] __initdata cleanup - frv Alon Bar-Lev
@ 2007-02-09 15:15 ` Alon Bar-Lev
  2007-02-09 15:16 ` [PATCH 06/34] __initdata cleanup - i386 Alon Bar-Lev
                   ` (29 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:15 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/h8300/kernel/setup.c linux-2.6.20-rc6-mm3/arch/h8300/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/h8300/kernel/setup.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/h8300/kernel/setup.c	2007-01-31 22:19:30.000000000 +0200
@@ -54,7 +54,7 @@ unsigned long rom_length;
 unsigned long memory_start;
 unsigned long memory_end;
 
-char __initdata command_line[COMMAND_LINE_SIZE];
+char __initdata command_line[COMMAND_LINE_SIZE] = "";
 
 extern int _stext, _etext, _sdata, _edata, _sbss, _ebss, _end;
 extern int _ramstart, _ramend;

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 06/34] __initdata cleanup - i386
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (4 preceding siblings ...)
  2007-02-09 15:15 ` [PATCH 05/34] __initdata cleanup - h8300 Alon Bar-Lev
@ 2007-02-09 15:16 ` Alon Bar-Lev
  2007-02-09 15:17 ` [PATCH 07/34] __initdata cleanup - ia64 Alon Bar-Lev
                   ` (28 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:16 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, davej, hpa, Riley


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/kernel/acpi/boot.c linux-2.6.20-rc6-mm3/arch/i386/kernel/acpi/boot.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/kernel/acpi/boot.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/kernel/acpi/boot.c	2007-01-31 22:20:36.000000000 +0200
@@ -72,7 +72,7 @@ static inline int acpi_madt_oem_check(ch
 #define PREFIX			"ACPI: "
 
 int acpi_noirq;				/* skip ACPI IRQ initialization */
-int acpi_pci_disabled __initdata;	/* skip ACPI PCI scan and IRQ initialization */
+int acpi_pci_disabled __initdata = 0;	/* skip ACPI PCI scan and IRQ initialization */
 int acpi_ht __initdata = 1;	/* enable HT */
 
 int acpi_lapic;
@@ -80,10 +80,10 @@ int acpi_ioapic;
 int acpi_strict;
 EXPORT_SYMBOL(acpi_strict);
 
-u8 acpi_sci_flags __initdata;
-int acpi_sci_override_gsi __initdata;
-int acpi_skip_timer_override __initdata;
-int acpi_use_timer_override __initdata;
+u8 acpi_sci_flags __initdata = 0;
+int acpi_sci_override_gsi __initdata = 0;
+int acpi_skip_timer_override __initdata = 0;
+int acpi_use_timer_override __initdata = 0;
 
 #ifdef CONFIG_X86_LOCAL_APIC
 static u64 acpi_lapic_addr __initdata = APIC_DEFAULT_PHYS_BASE;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/kernel/acpi/earlyquirk.c linux-2.6.20-rc6-mm3/arch/i386/kernel/acpi/earlyquirk.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/kernel/acpi/earlyquirk.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/kernel/acpi/earlyquirk.c	2007-01-31 22:19:30.000000000 +0200
@@ -13,7 +13,7 @@
 
 #ifdef CONFIG_ACPI
 
-static int nvidia_hpet_detected __initdata;
+static int nvidia_hpet_detected __initdata = 0;
 
 static int __init nvidia_hpet_check(struct acpi_table_header *header)
 {
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/kernel/cpu/mtrr/generic.c linux-2.6.20-rc6-mm3/arch/i386/kernel/cpu/mtrr/generic.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/kernel/cpu/mtrr/generic.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/kernel/cpu/mtrr/generic.c	2007-01-31 22:19:30.000000000 +0200
@@ -26,7 +26,7 @@ static struct mtrr_state mtrr_state = {}
 #undef MODULE_PARAM_PREFIX
 #define MODULE_PARAM_PREFIX "mtrr."
 
-static __initdata int mtrr_show;
+static __initdata int mtrr_show = 0;
 module_param_named(show, mtrr_show, bool, 0);
 
 /*  Get the MSR pair relating to a var range  */
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/kernel/e820.c linux-2.6.20-rc6-mm3/arch/i386/kernel/e820.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/kernel/e820.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/kernel/e820.c	2007-01-31 22:19:30.000000000 +0200
@@ -26,10 +26,10 @@ struct change_member {
 	struct e820entry *pbios; /* pointer to original bios entry */
 	unsigned long long addr; /* address for this change point */
 };
-static struct change_member change_point_list[2*E820MAX] __initdata;
-static struct change_member *change_point[2*E820MAX] __initdata;
-static struct e820entry *overlap_list[E820MAX] __initdata;
-static struct e820entry new_bios[E820MAX] __initdata;
+static struct change_member change_point_list[2*E820MAX] __initdata = {{0}};
+static struct change_member *change_point[2*E820MAX] __initdata = {0};
+static struct e820entry *overlap_list[E820MAX] __initdata = {0};
+static struct e820entry new_bios[E820MAX] __initdata = {{0}};
 /* For PCI or other memory-mapped resources */
 unsigned long pci_mem_start = 0x10000000;
 #ifdef CONFIG_PCI
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/kernel/io_apic.c linux-2.6.20-rc6-mm3/arch/i386/kernel/io_apic.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/kernel/io_apic.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/kernel/io_apic.c	2007-01-31 22:19:30.000000000 +0200
@@ -72,7 +72,7 @@ int sis_apic_bug = -1;
  */
 int nr_ioapic_registers[MAX_IO_APICS];
 
-static int disable_timer_pin_1 __initdata;
+static int disable_timer_pin_1 __initdata = 0;
 
 /*
  * Rough estimation of how many shared IRQs there are, can
@@ -1920,7 +1920,7 @@ static void __init setup_ioapic_ids_from
 static void __init setup_ioapic_ids_from_mpc(void) { }
 #endif
 
-int no_timer_check __initdata;
+int no_timer_check __initdata = 0;
 
 static int __init notimercheck(char *s)
 {
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/kernel/setup.c linux-2.6.20-rc6-mm3/arch/i386/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/kernel/setup.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/kernel/setup.c	2007-01-31 22:19:30.000000000 +0200
@@ -133,9 +133,9 @@ unsigned long saved_videomode;
 #define RAMDISK_PROMPT_FLAG		0x8000
 #define RAMDISK_LOAD_FLAG		0x4000	
 
-static char __initdata command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE] = "";
 
-unsigned char __initdata boot_params[PARAM_SIZE];
+unsigned char __initdata boot_params[PARAM_SIZE] = {0};
 
 #if defined(CONFIG_EDD) || defined(CONFIG_EDD_MODULE)
 struct edd edd;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/kernel/srat.c linux-2.6.20-rc6-mm3/arch/i386/kernel/srat.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/kernel/srat.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/kernel/srat.c	2007-01-31 22:19:30.000000000 +0200
@@ -55,7 +55,7 @@ struct node_memory_chunk_s {
 static struct node_memory_chunk_s node_memory_chunk[MAXCHUNKS];
 
 static int num_memory_chunks;		/* total number of memory chunks */
-static u8 __initdata apicid_to_pxm[MAX_APICID];
+static u8 __initdata apicid_to_pxm[MAX_APICID] = {0};
 
 extern void * boot_ioremap(unsigned long, unsigned long);
 
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/kernel/summit.c linux-2.6.20-rc6-mm3/arch/i386/kernel/summit.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/kernel/summit.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/kernel/summit.c	2007-01-31 22:19:30.000000000 +0200
@@ -31,9 +31,9 @@
 #include <asm/io.h>
 #include <asm/mach-summit/mach_mpparse.h>
 
-static struct rio_table_hdr *rio_table_hdr __initdata;
-static struct scal_detail   *scal_devs[MAX_NUMNODES] __initdata;
-static struct rio_detail    *rio_devs[MAX_NUMNODES*4] __initdata;
+static struct rio_table_hdr *rio_table_hdr __initdata = NULL;
+static struct scal_detail   *scal_devs[MAX_NUMNODES] __initdata = {0};
+static struct rio_detail    *rio_devs[MAX_NUMNODES*4] __initdata = {0};
 
 static int __init setup_pci_node_map_for_wpeg(int wpeg_num, int last_bus)
 {
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/mach-generic/probe.c linux-2.6.20-rc6-mm3/arch/i386/mach-generic/probe.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/mach-generic/probe.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/mach-generic/probe.c	2007-01-31 22:19:30.000000000 +0200
@@ -30,7 +30,7 @@ struct genapic *apic_probe[] __initdata 
 	NULL,
 };
 
-static int cmdline_apic __initdata;
+static int cmdline_apic __initdata = 0;
 static int __init parse_apic(char *arg)
 {
 	int i;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/mach-voyager/voyager_cat.c linux-2.6.20-rc6-mm3/arch/i386/mach-voyager/voyager_cat.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/mach-voyager/voyager_cat.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/mach-voyager/voyager_cat.c	2007-01-31 22:19:30.000000000 +0200
@@ -561,7 +561,7 @@ cat_subread(voyager_module_t *modp, voya
 
 
 /* buffer for storing EPROM data read in during initialisation */
-static __initdata __u8 eprom_buf[0xFFFF];
+static __initdata __u8 eprom_buf[0xFFFF] = {0};
 static voyager_module_t *voyager_initial_module;
 
 /* Initialise the cat bus components.  We assume this is called by the
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/mm/boot_ioremap.c linux-2.6.20-rc6-mm3/arch/i386/mm/boot_ioremap.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/mm/boot_ioremap.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/mm/boot_ioremap.c	2007-01-31 22:19:30.000000000 +0200
@@ -65,7 +65,7 @@ static void __boot_ioremap(unsigned long
 #define BOOT_IOREMAP_PAGES 4
 #define BOOT_IOREMAP_SIZE (BOOT_IOREMAP_PAGES*PAGE_SIZE)
 static __initdata char boot_ioremap_space[BOOT_IOREMAP_SIZE]
-		       __attribute__ ((aligned (PAGE_SIZE)));
+		       __attribute__ ((aligned (PAGE_SIZE))) = {0};
 
 /*
  * This only applies to things which need to ioremap before paging_init()

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 07/34] __initdata cleanup - ia64
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (5 preceding siblings ...)
  2007-02-09 15:16 ` [PATCH 06/34] __initdata cleanup - i386 Alon Bar-Lev
@ 2007-02-09 15:17 ` Alon Bar-Lev
  2007-02-09 15:18 ` [PATCH 08/34] __initdata cleanup - m32r Alon Bar-Lev
                   ` (27 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:17 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, tony.luck


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/acpi.c linux-2.6.20-rc6-mm3/arch/ia64/kernel/acpi.c
--- linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/acpi.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/ia64/kernel/acpi.c	2007-01-31 22:19:30.000000000 +0200
@@ -158,9 +158,9 @@ char *__acpi_map_table(unsigned long phy
                             Boot-time Table Parsing
    -------------------------------------------------------------------------- */
 
-static int total_cpus __initdata;
-static int available_cpus __initdata;
-struct acpi_table_madt *acpi_madt __initdata;
+static int total_cpus __initdata = 0;
+static int available_cpus __initdata = 0;
+struct acpi_table_madt *acpi_madt __initdata = NULL;
 static u8 has_8259;
 
 static int __init
@@ -229,7 +229,7 @@ acpi_parse_iosapic(struct acpi_subtable_
 	return iosapic_init(iosapic->address, iosapic->global_irq_base);
 }
 
-static unsigned int __initdata acpi_madt_rev;
+static unsigned int __initdata acpi_madt_rev = 0;
 
 static int __init
 acpi_parse_plat_int_src(struct acpi_subtable_header * header,
@@ -401,11 +401,11 @@ static int __init acpi_parse_madt(struct
 
 #define PXM_FLAG_LEN ((MAX_PXM_DOMAINS + 1)/32)
 
-static int __initdata srat_num_cpus;	/* number of cpus */
-static u32 __devinitdata pxm_flag[PXM_FLAG_LEN];
+static int __initdata srat_num_cpus = 0;	/* number of cpus */
+static u32 __devinitdata pxm_flag[PXM_FLAG_LEN] = {0};
 #define pxm_bit_set(bit)	(set_bit(bit,(void *)pxm_flag))
 #define pxm_bit_test(bit)	(test_bit(bit,(void *)pxm_flag))
-static struct acpi_table_slit __initdata *slit_table;
+static struct acpi_table_slit __initdata *slit_table = NULL;
 
 static int get_processor_proximity_domain(struct acpi_srat_cpu_affinity *pa)
 {
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/machvec.c linux-2.6.20-rc6-mm3/arch/ia64/kernel/machvec.c
--- linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/machvec.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/ia64/kernel/machvec.c	2007-01-31 22:19:30.000000000 +0200
@@ -13,7 +13,7 @@
 struct ia64_machine_vector ia64_mv;
 EXPORT_SYMBOL(ia64_mv);
 
-static __initdata const char *mvec_name;
+static __initdata const char *mvec_name = NULL;
 static __init int setup_mvec(char *s)
 {
 	mvec_name = s;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/mca.c linux-2.6.20-rc6-mm3/arch/ia64/kernel/mca.c
--- linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/mca.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/ia64/kernel/mca.c	2007-01-31 22:19:30.000000000 +0200
@@ -138,7 +138,7 @@ static int cpe_poll_enabled = 1;
 
 extern void salinfo_log_wakeup(int type, u8 *buffer, u64 size, int irqsafe);
 
-static int mca_init __initdata;
+static int mca_init __initdata = 0;
 
 /*
  * limited & delayed printing support for MCA/INIT handler
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/setup.c linux-2.6.20-rc6-mm3/arch/ia64/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/setup.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/ia64/kernel/setup.c	2007-01-31 22:19:30.000000000 +0200
@@ -131,8 +131,8 @@ EXPORT_SYMBOL(ia64_max_iommu_merge_mask)
 /*
  * We use a special marker for the end of memory and it uses the extra (+1) slot
  */
-struct rsvd_region rsvd_region[IA64_MAX_RSVD_REGIONS + 1] __initdata;
-int num_rsvd_regions __initdata;
+struct rsvd_region rsvd_region[IA64_MAX_RSVD_REGIONS + 1] __initdata = {{0}};
+int num_rsvd_regions __initdata = 0;
 
 
 /*
@@ -432,7 +432,7 @@ check_for_logical_procs (void)
 }
 #endif
 
-static __initdata int nomca;
+static __initdata int nomca = 0;
 static __init int setup_nomca(char *s)
 {
 	nomca = 1;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/smpboot.c linux-2.6.20-rc6-mm3/arch/ia64/kernel/smpboot.c
--- linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/smpboot.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/ia64/kernel/smpboot.c	2007-01-31 22:19:30.000000000 +0200
@@ -148,11 +148,11 @@ EXPORT_SYMBOL(ia64_cpu_to_sapicid);
 
 static volatile cpumask_t cpu_callin_map;
 
-struct smp_boot_data smp_boot_data __initdata;
+struct smp_boot_data smp_boot_data __initdata = {0};
 
 unsigned long ap_wakeup_vector = -1; /* External Int use to wakeup APs */
 
-char __initdata no_int_routing;
+char __initdata no_int_routing = 0;
 
 unsigned char smp_int_redirect; /* are INT and IPI redirectable by the chipset? */
 
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ia64/mm/discontig.c linux-2.6.20-rc6-mm3/arch/ia64/mm/discontig.c
--- linux-2.6.20-rc6-mm3.org/arch/ia64/mm/discontig.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/ia64/mm/discontig.c	2007-01-31 22:19:30.000000000 +0200
@@ -44,8 +44,8 @@ struct early_node_data {
 	unsigned long max_pfn;
 };
 
-static struct early_node_data mem_data[MAX_NUMNODES] __initdata;
-static nodemask_t memory_less_mask __initdata;
+static struct early_node_data mem_data[MAX_NUMNODES] __initdata = {{0}};
+static nodemask_t memory_less_mask __initdata = {{0}};
 
 static pg_data_t *pgdat_list[MAX_NUMNODES];
 
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ia64/mm/init.c linux-2.6.20-rc6-mm3/arch/ia64/mm/init.c
--- linux-2.6.20-rc6-mm3.org/arch/ia64/mm/init.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/ia64/mm/init.c	2007-01-31 22:19:30.000000000 +0200
@@ -656,7 +656,7 @@ count_reserved_pages (u64 start, u64 end
  * purposes.
  */
 
-static int nolwsys __initdata;
+static int nolwsys __initdata = 0;
 
 static int __init
 nolwsys_setup (char *s)
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ia64/sn/kernel/setup.c linux-2.6.20-rc6-mm3/arch/ia64/sn/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/ia64/sn/kernel/setup.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/ia64/sn/kernel/setup.c	2007-01-31 22:19:30.000000000 +0200
@@ -194,7 +194,7 @@ void __init early_sn_setup(void)
 }
 
 extern int platform_intr_list[];
-static int __initdata shub_1_1_found;
+static int __initdata shub_1_1_found = 0;
 
 /*
  * sn_check_for_wars

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 08/34] __initdata cleanup - m32r
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (6 preceding siblings ...)
  2007-02-09 15:17 ` [PATCH 07/34] __initdata cleanup - ia64 Alon Bar-Lev
@ 2007-02-09 15:18 ` Alon Bar-Lev
  2007-02-09 15:19 ` [PATCH 09/34] __initdata cleanup - m68knommu Alon Bar-Lev
                   ` (26 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:18 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml


Trivial.

**NOT TESTED***

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/m32r/kernel/setup.c linux-2.6.20-rc6-mm3/arch/m32r/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/m32r/kernel/setup.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/m32r/kernel/setup.c	2007-01-31 22:19:30.000000000 +0200
@@ -64,7 +64,7 @@ struct screen_info screen_info = {
 
 extern int root_mountflags;
 
-static char __initdata command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE] = "";
 
 static struct resource data_resource = {
 	.name   = "Kernel data",
diff -urNp linux-2.6.20-rc6-mm3.org/arch/m32r/mm/discontig.c linux-2.6.20-rc6-mm3/arch/m32r/mm/discontig.c
--- linux-2.6.20-rc6-mm3.org/arch/m32r/mm/discontig.c	2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/m32r/mm/discontig.c	2007-01-31 22:19:30.000000000 +0200
@@ -20,7 +20,7 @@ extern char _end[];
 
 struct pglist_data *node_data[MAX_NUMNODES];
 EXPORT_SYMBOL(node_data);
-static bootmem_data_t node_bdata[MAX_NUMNODES] __initdata;
+static bootmem_data_t node_bdata[MAX_NUMNODES] __initdata = {{0}};
 
 pg_data_t m32r_node_data[MAX_NUMNODES];
 

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 09/34] __initdata cleanup - m68knommu
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (7 preceding siblings ...)
  2007-02-09 15:18 ` [PATCH 08/34] __initdata cleanup - m32r Alon Bar-Lev
@ 2007-02-09 15:19 ` Alon Bar-Lev
  2007-02-09 15:19 ` [PATCH 10/34] __initdata cleanup - mips Alon Bar-Lev
                   ` (25 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:19 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, geert, zippel


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/m68knommu/kernel/setup.c linux-2.6.20-rc6-mm3/arch/m68knommu/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/m68knommu/kernel/setup.c	2007-01-31 22:15:31.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/m68knommu/kernel/setup.c	2007-01-31 22:19:30.000000000 +0200
@@ -44,7 +44,7 @@ unsigned long memory_end;
 EXPORT_SYMBOL(memory_start);
 EXPORT_SYMBOL(memory_end);
 
-char __initdata command_line[COMMAND_LINE_SIZE];
+char __initdata command_line[COMMAND_LINE_SIZE] = "";
 
 /* setup some dummy routines */
 static void dummy_waitbut(void)

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 10/34] __initdata cleanup - mips
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (8 preceding siblings ...)
  2007-02-09 15:19 ` [PATCH 09/34] __initdata cleanup - m68knommu Alon Bar-Lev
@ 2007-02-09 15:19 ` Alon Bar-Lev
  2007-02-09 15:20 ` [PATCH 11/34] __initdata cleanup - parisc Alon Bar-Lev
                   ` (24 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:19 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, ralf


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/mips/kernel/traps.c linux-2.6.20-rc6-mm3/arch/mips/kernel/traps.c
--- linux-2.6.20-rc6-mm3.org/arch/mips/kernel/traps.c
+++ linux-2.6.20-rc6-mm3/arch/mips/kernel/traps.c
@@ -1432,7 +1432,7 @@ void __init set_uncached_handler (unsign
 	memcpy((void *)(uncached_ebase + offset), addr, size);
 }
 
-static int __initdata rdhwr_noopt;
+static int __initdata rdhwr_noopt = 0;
 static int __init set_rdhwr_noopt(char *str)
 {
 	rdhwr_noopt = 1;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/mips/mm/pg-r4k.c linux-2.6.20-rc6-mm3/arch/mips/mm/pg-r4k.c
--- linux-2.6.20-rc6-mm3.org/arch/mips/mm/pg-r4k.c
+++ linux-2.6.20-rc6-mm3/arch/mips/mm/pg-r4k.c
@@ -67,13 +67,13 @@ EXPORT_SYMBOL(copy_page);
 static int pref_offset_clear __initdata = 512;
 static int pref_offset_copy  __initdata = 256;
 
-static unsigned int pref_src_mode __initdata;
-static unsigned int pref_dst_mode __initdata;
+static unsigned int pref_src_mode __initdata = 0;
+static unsigned int pref_dst_mode __initdata = 0;
 
-static int load_offset __initdata;
-static int store_offset __initdata;
+static int load_offset __initdata = 0;
+static int store_offset __initdata = 0;
 
-static unsigned int __initdata *dest, *epc;
+static unsigned int __initdata *dest = NULL, *epc = NULL;
 
 static unsigned int instruction_pending;
 static union mips_instruction delayed_mi;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/mips/mm/tlbex.c linux-2.6.20-rc6-mm3/arch/mips/mm/tlbex.c
--- linux-2.6.20-rc6-mm3.org/arch/mips/mm/tlbex.c
+++ linux-2.6.20-rc6-mm3/arch/mips/mm/tlbex.c
@@ -728,11 +728,11 @@ il_bgez(u32 **p, struct reloc **r, unsig
  * We deliberately chose a buffer size of 128, so we won't scribble
  * over anything important on overflow before we panic.
  */
-static __initdata u32 tlb_handler[128];
+static __initdata u32 tlb_handler[128] = {0};
 
 /* simply assume worst case size for labels and relocs */
-static __initdata struct label labels[128];
-static __initdata struct reloc relocs[128];
+static __initdata struct label labels[128] = {{NULL}};
+static __initdata struct reloc relocs[128] = {{NULL}};
 
 /*
  * The R3000 TLB handler is simple.
@@ -786,7 +786,7 @@ static void __init build_r3000_tlb_refil
  * other one.To keep things simple, we first assume linear space,
  * then we relocate it to the final handler layout as needed.
  */
-static __initdata u32 final_handler[64];
+static __initdata u32 final_handler[64] = {0};
 
 /*
  * Hazards
diff -urNp linux-2.6.20-rc6-mm3.org/arch/mips/mm/tlb-r4k.c linux-2.6.20-rc6-mm3/arch/mips/mm/tlb-r4k.c
--- linux-2.6.20-rc6-mm3.org/arch/mips/mm/tlb-r4k.c
+++ linux-2.6.20-rc6-mm3/arch/mips/mm/tlb-r4k.c
@@ -367,7 +367,7 @@ void __init add_wired_entry(unsigned lon
  * lifetime of the system
  */
 
-static int temp_tlb_entry __initdata;
+static int temp_tlb_entry __initdata = 0;
 
 __init int add_temporary_entry(unsigned long entrylo0, unsigned long entrylo1,
 			       unsigned long entryhi, unsigned long pagemask)
diff -urNp linux-2.6.20-rc6-mm3.org/arch/mips/pci/fixup-malta.c linux-2.6.20-rc6-mm3/arch/mips/pci/fixup-malta.c
--- linux-2.6.20-rc6-mm3.org/arch/mips/pci/fixup-malta.c
+++ linux-2.6.20-rc6-mm3/arch/mips/pci/fixup-malta.c
@@ -8,7 +8,7 @@
 #define PCID		4
 
 /* This table is filled in by interrogating the PIIX4 chip */
-static char pci_irq[5] __initdata;
+static char pci_irq[5] __initdata = {0};
 
 static char irq_tab[][5] __initdata = {
 	/*      INTA    INTB    INTC    INTD */
diff -urNp linux-2.6.20-rc6-mm3.org/arch/mips/pmc-sierra/yosemite/smp.c linux-2.6.20-rc6-mm3/arch/mips/pmc-sierra/yosemite/smp.c
--- linux-2.6.20-rc6-mm3.org/arch/mips/pmc-sierra/yosemite/smp.c
+++ linux-2.6.20-rc6-mm3/arch/mips/pmc-sierra/yosemite/smp.c
@@ -9,11 +9,11 @@
 
 static __initdata DEFINE_SPINLOCK(launch_lock);
 
-static unsigned long secondary_sp __initdata;
-static unsigned long secondary_gp __initdata;
+static unsigned long secondary_sp __initdata = 0l;
+static unsigned long secondary_gp __initdata = 0l;
 
 static unsigned char launchstack[LAUNCHSTACK_SIZE] __initdata
-	__attribute__((aligned(2 * sizeof(long))));
+	__attribute__((aligned(2 * sizeof(long)))) = {0};
 
 static void __init prom_smp_bootstrap(void)
 {
diff -urNp linux-2.6.20-rc6-mm3.org/arch/mips/sgi-ip27/ip27-memory.c linux-2.6.20-rc6-mm3/arch/mips/sgi-ip27/ip27-memory.c
--- linux-2.6.20-rc6-mm3.org/arch/mips/sgi-ip27/ip27-memory.c
+++ linux-2.6.20-rc6-mm3/arch/mips/sgi-ip27/ip27-memory.c
@@ -34,9 +34,9 @@
 
 #define SLOT_IGNORED		0xffff
 
-static short __initdata slot_lastfilled_cache[MAX_COMPACT_NODES];
-static unsigned short __initdata slot_psize_cache[MAX_COMPACT_NODES][MAX_MEM_SLOTS];
-static struct bootmem_data __initdata plat_node_bdata[MAX_COMPACT_NODES];
+static short __initdata slot_lastfilled_cache[MAX_COMPACT_NODES] = {0};
+static unsigned short __initdata slot_psize_cache[MAX_COMPACT_NODES][MAX_MEM_SLOTS] = {0};
+static struct bootmem_data __initdata plat_node_bdata[MAX_COMPACT_NODES] = {0};
 
 struct node_data *__node_data[MAX_COMPACT_NODES];
 
diff -urNp linux-2.6.20-rc6-mm3.org/arch/mips/tx4938/toshiba_rbtx4938/setup.c linux-2.6.20-rc6-mm3/arch/mips/tx4938/toshiba_rbtx4938/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/mips/tx4938/toshiba_rbtx4938/setup.c
+++ linux-2.6.20-rc6-mm3/arch/mips/tx4938/toshiba_rbtx4938/setup.c
@@ -63,8 +63,8 @@ struct tx4938_pcic_reg *pcicptrs[4] = {
 static struct {
 	unsigned long base;
 	unsigned long size;
-} phys_regions[16] __initdata;
-static int num_phys_regions  __initdata;
+} phys_regions[16] __initdata = {{0}};
+static int num_phys_regions  __initdata = 0;
 
 #define PHYS_REGION_MINSIZE	0x10000
 

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 11/34] __initdata cleanup - parisc
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (9 preceding siblings ...)
  2007-02-09 15:19 ` [PATCH 10/34] __initdata cleanup - mips Alon Bar-Lev
@ 2007-02-09 15:20 ` Alon Bar-Lev
  2007-02-09 15:21 ` [PATCH 12/34] __initdata cleanup - powerpc Alon Bar-Lev
                   ` (23 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:20 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, matthew, grundler, kyle


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/parisc/kernel/setup.c linux-2.6.20-rc6-mm3/arch/parisc/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/parisc/kernel/setup.c	2007-01-31 22:15:31.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/parisc/kernel/setup.c	2007-01-31 22:19:30.000000000 +0200
@@ -45,7 +45,7 @@
 #include <asm/io.h>
 #include <asm/setup.h>
 
-char	__initdata command_line[COMMAND_LINE_SIZE] __read_mostly;
+char	__initdata command_line[COMMAND_LINE_SIZE] __read_mostly = "";
 
 /* Intended for ccio/sba/cpu statistics under /proc/bus/{runway|gsc} */
 struct proc_dir_entry * proc_runway_root __read_mostly = NULL;

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 12/34] __initdata cleanup - powerpc
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (10 preceding siblings ...)
  2007-02-09 15:20 ` [PATCH 11/34] __initdata cleanup - parisc Alon Bar-Lev
@ 2007-02-09 15:21 ` Alon Bar-Lev
  2007-02-09 15:21 ` [PATCH 13/34] __initdata cleanup - ppc Alon Bar-Lev
                   ` (22 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:21 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, paulus


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/legacy_serial.c linux-2.6.20-rc6-mm3/arch/powerpc/kernel/legacy_serial.c
--- linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/legacy_serial.c	2007-01-31 22:15:31.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/powerpc/kernel/legacy_serial.c	2007-01-31 22:19:30.000000000 +0200
@@ -565,7 +565,7 @@ static int __init check_legacy_serial_co
 	DBG("Found serial console at ttyS%d\n", offset);
 
 	if (speed) {
-		static char __initdata opt[16];
+		static char __initdata opt[16] = {0};
 		sprintf(opt, "%d", speed);
 		return add_preferred_console("ttyS", offset, opt);
 	} else
diff -urNp linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/pci_32.c linux-2.6.20-rc6-mm3/arch/powerpc/kernel/pci_32.c
--- linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/pci_32.c	2007-01-31 22:15:31.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/powerpc/kernel/pci_32.c	2007-01-31 22:19:30.000000000 +0200
@@ -889,7 +889,7 @@ void __init
 pci_process_bridge_OF_ranges(struct pci_controller *hose,
 			   struct device_node *dev, int primary)
 {
-	static unsigned int static_lc_ranges[256] __initdata;
+	static unsigned int static_lc_ranges[256] __initdata = {0};
 	const unsigned int *dt_ranges;
 	unsigned int *lc_ranges, *ranges, *prev, size;
 	int rlen = 0, orig_rlen;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/prom.c linux-2.6.20-rc6-mm3/arch/powerpc/kernel/prom.c
--- linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/prom.c	2007-01-31 22:15:31.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/powerpc/kernel/prom.c	2007-01-31 22:19:30.000000000 +0200
@@ -60,8 +60,8 @@
 #endif
 
 
-static int __initdata dt_root_addr_cells;
-static int __initdata dt_root_size_cells;
+static int __initdata dt_root_addr_cells = 0;
+static int __initdata dt_root_size_cells = 0;
 
 #ifdef CONFIG_PPC64
 int __initdata iommu_is_off;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/prom_init.c linux-2.6.20-rc6-mm3/arch/powerpc/kernel/prom_init.c
--- linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/prom_init.c	2007-01-31 22:15:31.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/powerpc/kernel/prom_init.c	2007-01-31 22:19:30.000000000 +0200
@@ -157,26 +157,26 @@ extern void copy_and_flush(unsigned long
 			   unsigned long size, unsigned long offset);
 
 /* prom structure */
-static struct prom_t __initdata prom;
+static struct prom_t __initdata prom = {0};
 
-static unsigned long prom_entry __initdata;
+static unsigned long prom_entry __initdata = 0l;
 
 #define PROM_SCRATCH_SIZE 256
 
-static char __initdata of_stdout_device[256];
-static char __initdata prom_scratch[PROM_SCRATCH_SIZE];
+static char __initdata of_stdout_device[256] = {0};
+static char __initdata prom_scratch[PROM_SCRATCH_SIZE] = {0};
 
-static unsigned long __initdata dt_header_start;
-static unsigned long __initdata dt_struct_start, dt_struct_end;
-static unsigned long __initdata dt_string_start, dt_string_end;
+static unsigned long __initdata dt_header_start = 0l;
+static unsigned long __initdata dt_struct_start = 0l, dt_struct_end = 0l;
+static unsigned long __initdata dt_string_start = 0l, dt_string_end = 0l;
 
-static unsigned long __initdata prom_initrd_start, prom_initrd_end;
+static unsigned long __initdata prom_initrd_start = 0l, prom_initrd_end = 0l;
 
 #ifdef CONFIG_PPC64
-static int __initdata prom_iommu_force_on;
-static int __initdata prom_iommu_off;
-static unsigned long __initdata prom_tce_alloc_start;
-static unsigned long __initdata prom_tce_alloc_end;
+static int __initdata prom_iommu_force_on = 0;
+static int __initdata prom_iommu_off = 0;
+static unsigned long __initdata prom_tce_alloc_start = 0l;
+static unsigned long __initdata prom_tce_alloc_end = 0l;
 #endif
 
 /* Platforms codes are now obsolete in the kernel. Now only used within this
@@ -189,20 +189,20 @@ static unsigned long __initdata prom_tce
 #define PLATFORM_POWERMAC	0x0400
 #define PLATFORM_GENERIC	0x0500
 
-static int __initdata of_platform;
+static int __initdata of_platform = 0;
 
-static char __initdata prom_cmd_line[COMMAND_LINE_SIZE];
+static char __initdata prom_cmd_line[COMMAND_LINE_SIZE] = "";
 
-static unsigned long __initdata alloc_top;
-static unsigned long __initdata alloc_top_high;
-static unsigned long __initdata alloc_bottom;
-static unsigned long __initdata rmo_top;
-static unsigned long __initdata ram_top;
+static unsigned long __initdata alloc_top = 0l;
+static unsigned long __initdata alloc_top_high = 0l;
+static unsigned long __initdata alloc_bottom = 0l;
+static unsigned long __initdata rmo_top = 0l;
+static unsigned long __initdata ram_top = 0l;
 
-static struct mem_map_entry __initdata mem_reserve_map[MEM_RESERVE_MAP_SIZE];
-static int __initdata mem_reserve_cnt;
+static struct mem_map_entry __initdata mem_reserve_map[MEM_RESERVE_MAP_SIZE] = {{0}};
+static int __initdata mem_reserve_cnt = 0;
 
-static cell_t __initdata regbuf[1024];
+static cell_t __initdata regbuf[1024] = {0};
 
 
 #define MAX_CPU_THREADS 2
diff -urNp linux-2.6.20-rc6-mm3.org/arch/powerpc/mm/numa.c linux-2.6.20-rc6-mm3/arch/powerpc/mm/numa.c
--- linux-2.6.20-rc6-mm3.org/arch/powerpc/mm/numa.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/powerpc/mm/numa.c	2007-01-31 22:19:30.000000000 +0200
@@ -35,7 +35,7 @@ EXPORT_SYMBOL(numa_cpu_lookup_table);
 EXPORT_SYMBOL(numa_cpumask_lookup_table);
 EXPORT_SYMBOL(node_data);
 
-static bootmem_data_t __initdata plat_node_bdata[MAX_NUMNODES];
+static bootmem_data_t __initdata plat_node_bdata[MAX_NUMNODES] = {{0}};
 static int min_common_depth;
 static int n_mem_addr_cells, n_mem_size_cells;
 
diff -urNp linux-2.6.20-rc6-mm3.org/arch/powerpc/platforms/iseries/dt.c linux-2.6.20-rc6-mm3/arch/powerpc/platforms/iseries/dt.c
--- linux-2.6.20-rc6-mm3.org/arch/powerpc/platforms/iseries/dt.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/powerpc/platforms/iseries/dt.c	2007-01-31 22:19:30.000000000 +0200
@@ -61,7 +61,7 @@ struct iseries_flat_dt {
 	u64 reserve_map[2];
 };
 
-static void * __initdata dt_data;
+static void * __initdata dt_data = NULL;
 
 /*
  * Putting these strings here keeps them out of the section
diff -urNp linux-2.6.20-rc6-mm3.org/arch/powerpc/platforms/powermac/bootx_init.c linux-2.6.20-rc6-mm3/arch/powerpc/platforms/powermac/bootx_init.c
--- linux-2.6.20-rc6-mm3.org/arch/powerpc/platforms/powermac/bootx_init.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/powerpc/platforms/powermac/bootx_init.c	2007-01-31 22:19:30.000000000 +0200
@@ -32,11 +32,11 @@
 
 extern void __start(unsigned long r3, unsigned long r4, unsigned long r5);
 
-static unsigned long __initdata bootx_dt_strbase;
-static unsigned long __initdata bootx_dt_strend;
-static unsigned long __initdata bootx_node_chosen;
-static boot_infos_t * __initdata bootx_info;
-static char __initdata bootx_disp_path[256];
+static unsigned long __initdata bootx_dt_strbase = 0l;
+static unsigned long __initdata bootx_dt_strend = 0l;
+static unsigned long __initdata bootx_node_chosen = 0l;
+static boot_infos_t * __initdata bootx_info = NULL;
+static char __initdata bootx_disp_path[256] = {0};
 
 /* Is boot-info compatible ? */
 #define BOOT_INFO_IS_COMPATIBLE(bi) \
diff -urNp linux-2.6.20-rc6-mm3.org/arch/powerpc/xmon/xmon.c linux-2.6.20-rc6-mm3/arch/powerpc/xmon/xmon.c
--- linux-2.6.20-rc6-mm3.org/arch/powerpc/xmon/xmon.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/powerpc/xmon/xmon.c	2007-01-31 22:19:30.000000000 +0200
@@ -2632,7 +2632,7 @@ static int __init setup_xmon_sysrq(void)
 __initcall(setup_xmon_sysrq);
 #endif /* CONFIG_MAGIC_SYSRQ */
 
-int __initdata xmon_early, xmon_off;
+int __initdata xmon_early = 0, xmon_off = 0;
 
 static int __init early_parse_xmon(char *p)
 {

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 13/34] __initdata cleanup - ppc
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (11 preceding siblings ...)
  2007-02-09 15:21 ` [PATCH 12/34] __initdata cleanup - powerpc Alon Bar-Lev
@ 2007-02-09 15:21 ` Alon Bar-Lev
  2007-02-09 15:22 ` [PATCH 14/34] __initdata cleanup - s390 Alon Bar-Lev
                   ` (21 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:21 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, paulus


Trivial.

**NOT TESTED***

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/bamboo.c linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/bamboo.c
--- linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/bamboo.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/bamboo.c	2007-01-31 22:19:30.000000000 +0200
@@ -50,7 +50,7 @@
 
 extern bd_t __res;
 
-static struct ibm44x_clocks clocks __initdata;
+static struct ibm44x_clocks clocks __initdata = {0};
 
 /*
  * Bamboo external IRQ triggering/polarity settings
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/ebony.c linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/ebony.c
--- linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/ebony.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/ebony.c	2007-01-31 22:19:30.000000000 +0200
@@ -53,7 +53,7 @@
 
 extern bd_t __res;
 
-static struct ibm44x_clocks clocks __initdata;
+static struct ibm44x_clocks clocks __initdata = {0};
 
 /*
  * Ebony external IRQ triggering/polarity settings
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/luan.c linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/luan.c
--- linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/luan.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/luan.c	2007-01-31 22:19:30.000000000 +0200
@@ -51,7 +51,7 @@
 
 extern bd_t __res;
 
-static struct ibm44x_clocks clocks __initdata;
+static struct ibm44x_clocks clocks __initdata = {0};
 
 static void __init
 luan_calibrate_decr(void)
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/ocotea.c linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/ocotea.c
--- linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/ocotea.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/ocotea.c	2007-01-31 22:19:30.000000000 +0200
@@ -51,7 +51,7 @@
 
 extern bd_t __res;
 
-static struct ibm44x_clocks clocks __initdata;
+static struct ibm44x_clocks clocks __initdata = {0};
 
 static void __init
 ocotea_calibrate_decr(void)
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/yucca.c linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/yucca.c
--- linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/yucca.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/yucca.c	2007-01-31 22:19:30.000000000 +0200
@@ -53,7 +53,7 @@
 
 extern bd_t __res;
 
-static struct ibm44x_clocks clocks __initdata;
+static struct ibm44x_clocks clocks __initdata = {0};
 
 static void __init
 yucca_calibrate_decr(void)

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 14/34] __initdata cleanup - s390
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (12 preceding siblings ...)
  2007-02-09 15:21 ` [PATCH 13/34] __initdata cleanup - ppc Alon Bar-Lev
@ 2007-02-09 15:22 ` Alon Bar-Lev
  2007-02-09 15:22 ` [PATCH 15/34] __initdata cleanup - sh Alon Bar-Lev
                   ` (20 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:22 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, schwidefsky, heiko.carstens


Trivial.

**NOT TESTED***

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/s390/kernel/setup.c linux-2.6.20-rc6-mm3/arch/s390/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/s390/kernel/setup.c
+++ linux-2.6.20-rc6-mm3/arch/s390/kernel/setup.c
@@ -74,9 +74,9 @@ unsigned int console_devno = -1;
 unsigned int console_irq = -1;
 unsigned long machine_flags = 0;
 
-struct mem_chunk __initdata memory_chunk[MEMORY_CHUNKS];
+struct mem_chunk __initdata memory_chunk[MEMORY_CHUNKS] = {{0}};
 volatile int __cpu_logical_map[NR_CPUS]; /* logical cpu to cpu address */
-static unsigned long __initdata memory_end;
+static unsigned long __initdata memory_end = 0l;
 
 /*
  * This is set up by the setup-routine at boot-time
diff -urNp linux-2.6.20-rc6-mm3.org/arch/s390/kernel/smp.c linux-2.6.20-rc6-mm3/arch/s390/kernel/smp.c
--- linux-2.6.20-rc6-mm3.org/arch/s390/kernel/smp.c
+++ linux-2.6.20-rc6-mm3/arch/s390/kernel/smp.c
@@ -603,8 +603,8 @@ __cpu_up(unsigned int cpu)
 	return 0;
 }
 
-static unsigned int __initdata additional_cpus;
-static unsigned int __initdata possible_cpus;
+static unsigned int __initdata additional_cpus = 0;
+static unsigned int __initdata possible_cpus = 0;
 
 void __init smp_setup_cpu_possible_map(void)
 {
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/s390/block/xpram.c linux-2.6.20-rc6-mm3/drivers/s390/block/xpram.c
--- linux-2.6.20-rc6-mm3.org/drivers/s390/block/xpram.c
+++ linux-2.6.20-rc6-mm3/drivers/s390/block/xpram.c
@@ -63,7 +63,7 @@ static int xpram_devs;
  * Parameter parsing functions.
  */
 static int __initdata devs = XPRAM_DEVS;
-static char __initdata *sizes[XPRAM_MAX_DEVS];
+static char __initdata *sizes[XPRAM_MAX_DEVS] = {0};
 
 module_param(devs, int, 0);
 module_param_array(sizes, charp, NULL, 0);

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 15/34] __initdata cleanup - sh
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (13 preceding siblings ...)
  2007-02-09 15:22 ` [PATCH 14/34] __initdata cleanup - s390 Alon Bar-Lev
@ 2007-02-09 15:22 ` Alon Bar-Lev
  2007-02-09 15:23 ` [PATCH 16/34] __initdata cleanup - sparc64 Alon Bar-Lev
                   ` (19 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:22 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, lethal


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/sh/kernel/early_printk.c linux-2.6.20-rc6-mm3/arch/sh/kernel/early_printk.c
--- linux-2.6.20-rc6-mm3.org/arch/sh/kernel/early_printk.c	2007-01-31 22:15:32.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/sh/kernel/early_printk.c	2007-01-31 22:19:30.000000000 +0200
@@ -163,7 +163,7 @@ static struct console *early_console =
 #endif
 	;
 
-static int __initdata keep_early;
+static int __initdata keep_early = 0;
 static int early_console_initialized;
 
 int __init setup_early_printk(char *buf)
diff -urNp linux-2.6.20-rc6-mm3.org/arch/sh/kernel/timers/timer.c linux-2.6.20-rc6-mm3/arch/sh/kernel/timers/timer.c
--- linux-2.6.20-rc6-mm3.org/arch/sh/kernel/timers/timer.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/sh/kernel/timers/timer.c	2007-01-31 22:19:30.000000000 +0200
@@ -26,7 +26,7 @@ static struct sys_timer *sys_timers[] __
 	NULL,
 };
 
-static char timer_override[10] __initdata;
+static char timer_override[10] __initdata = {0};
 static int __init timer_setup(char *str)
 {
 	if (str)

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 16/34] __initdata cleanup - sparc64
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (14 preceding siblings ...)
  2007-02-09 15:22 ` [PATCH 15/34] __initdata cleanup - sh Alon Bar-Lev
@ 2007-02-09 15:23 ` Alon Bar-Lev
  2007-02-09 15:23 ` [PATCH 17/34] __initdata cleanup - v850 Alon Bar-Lev
                   ` (18 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:23 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, davem


Trivial.

**NOT TESTED***

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/sparc64/mm/init.c linux-2.6.20-rc6-mm3/arch/sparc64/mm/init.c
--- linux-2.6.20-rc6-mm3.org/arch/sparc64/mm/init.c
+++ linux-2.6.20-rc6-mm3/arch/sparc64/mm/init.c
@@ -64,10 +64,10 @@ struct tsb swapper_4m_tsb[KERNEL_TSB4M_N
 
 #define MAX_BANKS	32
 
-static struct linux_prom64_registers pavail[MAX_BANKS] __initdata;
-static struct linux_prom64_registers pavail_rescan[MAX_BANKS] __initdata;
-static int pavail_ents __initdata;
-static int pavail_rescan_ents __initdata;
+static struct linux_prom64_registers pavail[MAX_BANKS] __initdata = {{0}};
+static struct linux_prom64_registers pavail_rescan[MAX_BANKS] __initdata = {{0}};
+static int pavail_ents __initdata = 0;
+static int pavail_rescan_ents __initdata = 0;
 
 static int cmp_p64(const void *a, const void *b)
 {
@@ -1109,8 +1109,8 @@ static unsigned long __init bootmem_init
 	return end_pfn;
 }
 
-static struct linux_prom64_registers pall[MAX_BANKS] __initdata;
-static int pall_ents __initdata;
+static struct linux_prom64_registers pall[MAX_BANKS] __initdata = {{0}};
+static int pall_ents __initdata = 0;
 
 #ifdef CONFIG_DEBUG_PAGEALLOC
 static unsigned long kernel_map_range(unsigned long pstart, unsigned long pend, pgprot_t prot)

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 17/34] __initdata cleanup - v850
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (15 preceding siblings ...)
  2007-02-09 15:23 ` [PATCH 16/34] __initdata cleanup - sparc64 Alon Bar-Lev
@ 2007-02-09 15:23 ` Alon Bar-Lev
  2007-02-09 15:24 ` [PATCH 18/34] __initdata cleanup - x86_64 Alon Bar-Lev
                   ` (17 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:23 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, uclinux-v850


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/v850/kernel/setup.c linux-2.6.20-rc6-mm3/arch/v850/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/v850/kernel/setup.c	2007-01-31 22:15:32.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/v850/kernel/setup.c	2007-01-31 22:19:30.000000000 +0200
@@ -42,7 +42,7 @@ extern char _root_fs_image_start __attri
 extern char _root_fs_image_end __attribute__ ((__weak__));
 
 
-char __initdata command_line[COMMAND_LINE_SIZE];
+char __initdata command_line[COMMAND_LINE_SIZE] = "";
 
 /* Memory not used by the kernel.  */
 static unsigned long total_ram_pages;

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 18/34] __initdata cleanup - x86_64
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (16 preceding siblings ...)
  2007-02-09 15:23 ` [PATCH 17/34] __initdata cleanup - v850 Alon Bar-Lev
@ 2007-02-09 15:24 ` Alon Bar-Lev
  2007-02-09 19:35   ` Andi Kleen
  2007-02-09 15:24 ` [PATCH 19/34] __initdata cleanup - xtensa Alon Bar-Lev
                   ` (16 subsequent siblings)
  34 siblings, 1 reply; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:24 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, ak, vojtech


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/crypto/aes.c linux-2.6.20-rc6-mm3/arch/x86_64/crypto/aes.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/crypto/aes.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/crypto/aes.c
@@ -83,10 +83,10 @@ struct aes_ctx
 #define E_KEY (&ctx->buf[0])
 #define D_KEY (&ctx->buf[60])
 
-static u8 pow_tab[256] __initdata;
-static u8 log_tab[256] __initdata;
-static u8 sbx_tab[256] __initdata;
-static u8 isb_tab[256] __initdata;
+static u8 pow_tab[256] __initdata = {0};
+static u8 log_tab[256] __initdata = {0};
+static u8 sbx_tab[256] __initdata = {0};
+static u8 isb_tab[256] __initdata = {0};
 static u32 rco_tab[10];
 u32 aes_ft_tab[4][256];
 u32 aes_it_tab[4][256];
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/apic.c linux-2.6.20-rc6-mm3/arch/x86_64/kernel/apic.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/apic.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/apic.c
@@ -43,9 +43,9 @@
 int apic_mapped;
 int apic_verbosity;
 int apic_runs_main_timer;
-int apic_calibrate_pmtmr __initdata;
+int apic_calibrate_pmtmr __initdata = 0;
 
-int disable_apic_timer __initdata;
+int disable_apic_timer __initdata = 0;
 
 static struct resource *ioapic_resources;
 static struct resource lapic_resource = {
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/e820.c linux-2.6.20-rc6-mm3/arch/x86_64/kernel/e820.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/e820.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/e820.c
@@ -25,7 +25,7 @@
 #include <asm/bootsetup.h>
 #include <asm/sections.h>
 
-struct e820map e820 __initdata;
+struct e820map e820 __initdata = {0};
 
 /* 
  * PFN of last memory page.
@@ -402,10 +402,10 @@ static int __init sanitize_e820_map(stru
 		struct e820entry *pbios; /* pointer to original bios entry */
 		unsigned long long addr; /* address for this change point */
 	};
-	static struct change_member change_point_list[2*E820MAX] __initdata;
-	static struct change_member *change_point[2*E820MAX] __initdata;
-	static struct e820entry *overlap_list[E820MAX] __initdata;
-	static struct e820entry new_bios[E820MAX] __initdata;
+	static struct change_member change_point_list[2*E820MAX] __initdata = {{0}};
+	static struct change_member *change_point[2*E820MAX] __initdata = {0};
+	static struct e820entry *overlap_list[E820MAX] __initdata = {0};
+	static struct e820entry new_bios[E820MAX] __initdata = {{0}};
 	struct change_member *change_tmp;
 	unsigned long current_type, last_type;
 	unsigned long long last_addr;
@@ -618,7 +618,7 @@ static int __init parse_memopt(char *p)
 } 
 early_param("mem", parse_memopt);
 
-static int userdef __initdata;
+static int userdef __initdata = 0;
 
 static int __init parse_memmap_opt(char *p)
 {
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/early_printk.c linux-2.6.20-rc6-mm3/arch/x86_64/kernel/early_printk.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/early_printk.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/early_printk.c
@@ -213,7 +213,7 @@ void early_printk(const char *fmt, ...)
 	va_end(ap);
 }
 
-static int __initdata keep_early;
+static int __initdata keep_early = 0;
 
 static int __init setup_early_printk(char *buf)
 {
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/early-quirks.c linux-2.6.20-rc6-mm3/arch/x86_64/kernel/early-quirks.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/early-quirks.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/early-quirks.c
@@ -30,7 +30,7 @@ static void via_bugs(void)
 
 #ifdef CONFIG_ACPI
 
-static int nvidia_hpet_detected __initdata;
+static int nvidia_hpet_detected __initdata = 0;
 
 static int __init nvidia_hpet_check(struct acpi_table_header *header)
 {
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/io_apic.c linux-2.6.20-rc6-mm3/arch/x86_64/kernel/io_apic.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/io_apic.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/io_apic.c
@@ -55,7 +55,7 @@ int sis_apic_bug; /* not actually suppor
 
 static int no_timer_check;
 
-static int disable_timer_pin_1 __initdata;
+static int disable_timer_pin_1 __initdata = 0;
 
 int timer_over_8254 __initdata = 1;
 
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/mpparse.c linux-2.6.20-rc6-mm3/arch/x86_64/kernel/mpparse.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/mpparse.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/mpparse.c
@@ -62,7 +62,7 @@ unsigned int boot_cpu_id = -1U;
 /* Internal processor count */
 unsigned int num_processors __initdata = 0;
 
-unsigned disabled_cpus __initdata;
+unsigned disabled_cpus __initdata = 0;
 
 /* Bitmask of physically existing CPUs */
 physid_mask_t phys_cpu_present_map = PHYSID_MASK_NONE;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/pci-calgary.c linux-2.6.20-rc6-mm3/arch/x86_64/kernel/pci-calgary.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/pci-calgary.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/pci-calgary.c
@@ -142,9 +142,9 @@ unsigned int specified_table_size = TCE_
 static int translate_empty_slots __read_mostly = 0;
 static int calgary_detected __read_mostly = 0;
 
-static struct rio_table_hdr	*rio_table_hdr __initdata;
-static struct scal_detail	*scal_devs[MAX_NUMNODES] __initdata;
-static struct rio_detail	*rio_devs[MAX_NUMNODES * 4] __initdata;
+static struct rio_table_hdr	*rio_table_hdr __initdata = NULL;
+static struct scal_detail	*scal_devs[MAX_NUMNODES] __initdata = {0};
+static struct rio_detail	*rio_devs[MAX_NUMNODES * 4] __initdata = {0};
 
 struct calgary_bus_info {
 	void *tce_space;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/setup64.c linux-2.6.20-rc6-mm3/arch/x86_64/kernel/setup64.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/setup64.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/setup64.c
@@ -24,7 +24,7 @@
 #include <asm/proto.h>
 #include <asm/sections.h>
 
-char x86_boot_params[BOOT_PARAM_SIZE] __initdata;
+char x86_boot_params[BOOT_PARAM_SIZE] __initdata = "";
 
 cpumask_t cpu_initialized __cpuinitdata = CPU_MASK_NONE;
 
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/setup.c linux-2.6.20-rc6-mm3/arch/x86_64/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/setup.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/setup.c
@@ -100,7 +100,7 @@ EXPORT_SYMBOL_GPL(edid_info);
 
 extern int root_mountflags;
 
-char __initdata command_line[COMMAND_LINE_SIZE];
+char __initdata command_line[COMMAND_LINE_SIZE] = "";
 
 struct resource standard_io_resources[] = {
 	{ .name = "dma1", .start = 0x00, .end = 0x1f,
@@ -333,8 +333,8 @@ static inline void copy_edd(void)
 
 #define EBDA_ADDR_POINTER 0x40E
 
-unsigned __initdata ebda_addr;
-unsigned __initdata ebda_size;
+unsigned __initdata ebda_addr = 0;
+unsigned __initdata ebda_size = 0;
 
 static void discover_ebda(void)
 {
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/mm/init.c linux-2.6.20-rc6-mm3/arch/x86_64/mm/init.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/mm/init.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/mm/init.c
@@ -49,7 +49,7 @@
 struct dma_mapping_ops* dma_ops;
 EXPORT_SYMBOL(dma_ops);
 
-static unsigned long dma_reserve __initdata;
+static unsigned long dma_reserve __initdata = 0l;
 
 DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);
 
@@ -165,7 +165,7 @@ __set_fixmap (enum fixed_addresses idx, 
 	set_pte_phys(address, phys, prot);
 }
 
-unsigned long __initdata table_start, table_end; 
+unsigned long __initdata table_start = 0l, table_end = 0l;
 
 extern pmd_t temp_boot_pmds[]; 
 
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/mm/numa.c linux-2.6.20-rc6-mm3/arch/x86_64/mm/numa.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/mm/numa.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/mm/numa.c
@@ -35,9 +35,9 @@ unsigned char apicid_to_node[MAX_LOCAL_A
 };
 cpumask_t node_to_cpumask[MAX_NUMNODES] __read_mostly;
 
-int numa_off __initdata;
-unsigned long __initdata nodemap_addr;
-unsigned long __initdata nodemap_size;
+int numa_off __initdata = 0;
+unsigned long __initdata nodemap_addr = 0l;
+unsigned long __initdata nodemap_size = 0l;
 
 
 /*
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/mm/srat.c linux-2.6.20-rc6-mm3/arch/x86_64/mm/srat.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/mm/srat.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/mm/srat.c
@@ -21,14 +21,14 @@
 #include <asm/numa.h>
 #include <asm/e820.h>
 
-int acpi_numa __initdata;
+int acpi_numa __initdata = 0;
 
 static struct acpi_table_slit *acpi_slit;
 
-static nodemask_t nodes_parsed __initdata;
-static struct bootnode nodes[MAX_NUMNODES] __initdata;
+static nodemask_t nodes_parsed __initdata = {{0}};
+static struct bootnode nodes[MAX_NUMNODES] __initdata = {{0}};
 static struct bootnode nodes_add[MAX_NUMNODES];
-static int found_add_area __initdata;
+static int found_add_area __initdata = 0;
 int hotadd_percent __initdata = 0;
 
 /* Too small nodes confuse the VM badly. Usually they result

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 19/34] __initdata cleanup - xtensa
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (17 preceding siblings ...)
  2007-02-09 15:24 ` [PATCH 18/34] __initdata cleanup - x86_64 Alon Bar-Lev
@ 2007-02-09 15:24 ` Alon Bar-Lev
  2007-02-09 15:25 ` [PATCH 20/34] __initdata cleanup - acpi Alon Bar-Lev
                   ` (15 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:24 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, chris


Trivial.

**NOT TESTED***

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/xtensa/kernel/setup.c linux-2.6.20-rc6-mm3/arch/xtensa/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/xtensa/kernel/setup.c
+++ linux-2.6.20-rc6-mm3/arch/xtensa/kernel/setup.c
@@ -78,13 +78,13 @@ extern unsigned long loops_per_jiffy;
 
 /* Command line specified as configuration option. */
 
-static char __initdata command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE] = "";
 
 #ifdef CONFIG_CMDLINE_BOOL
 static char default_command_line[COMMAND_LINE_SIZE] __initdata = CONFIG_CMDLINE;
 #endif
 
-sysmem_info_t __initdata sysmem;
+sysmem_info_t __initdata sysmem = {0};
 
 #ifdef CONFIG_BLK_DEV_INITRD
 int initrd_is_mapped;

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 20/34] __initdata cleanup - acpi
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (18 preceding siblings ...)
  2007-02-09 15:24 ` [PATCH 19/34] __initdata cleanup - xtensa Alon Bar-Lev
@ 2007-02-09 15:25 ` Alon Bar-Lev
  2007-02-09 15:25 ` [PATCH 21/34] __initdata cleanup - aes Alon Bar-Lev
                   ` (14 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:25 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, len.brown, lenb


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/drivers/acpi/ec.c linux-2.6.20-rc6-mm3/drivers/acpi/ec.c
--- linux-2.6.20-rc6-mm3.org/drivers/acpi/ec.c	2007-01-31 22:15:32.000000000 +0200
+++ linux-2.6.20-rc6-mm3/drivers/acpi/ec.c	2007-01-31 22:19:30.000000000 +0200
@@ -911,7 +911,7 @@ static int __init acpi_ec_get_real_ecdt(
 	return -ENODEV;
 }
 
-static int __initdata acpi_fake_ecdt_enabled;
+static int __initdata acpi_fake_ecdt_enabled = 0;
 int __init acpi_ec_ecdt_probe(void)
 {
 	acpi_status status;
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/acpi/tables.c linux-2.6.20-rc6-mm3/drivers/acpi/tables.c
--- linux-2.6.20-rc6-mm3.org/drivers/acpi/tables.c	2007-01-31 22:15:32.000000000 +0200
+++ linux-2.6.20-rc6-mm3/drivers/acpi/tables.c	2007-01-31 22:21:09.000000000 +0200
@@ -40,7 +40,7 @@
 static char *mps_inti_flags_polarity[] = { "dfl", "high", "res", "low" };
 static char *mps_inti_flags_trigger[] = { "dfl", "edge", "res", "level" };
 
-static struct acpi_table_desc initial_tables[ACPI_MAX_TABLES] __initdata;
+static struct acpi_table_desc initial_tables[ACPI_MAX_TABLES] __initdata = {{0}};
 
 void acpi_table_print_madt_entry(struct acpi_subtable_header * header)
 {

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 21/34] __initdata cleanup - aes
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (19 preceding siblings ...)
  2007-02-09 15:25 ` [PATCH 20/34] __initdata cleanup - acpi Alon Bar-Lev
@ 2007-02-09 15:25 ` Alon Bar-Lev
  2007-02-09 15:26 ` [PATCH 22/34] __initdata cleanup - fs Alon Bar-Lev
                   ` (13 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:25 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, herbert, davem


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/crypto/aes.c linux-2.6.20-rc6-mm3/crypto/aes.c
--- linux-2.6.20-rc6-mm3.org/crypto/aes.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/crypto/aes.c	2007-01-31 22:19:30.000000000 +0200
@@ -81,10 +81,10 @@ struct aes_ctx {
 #define E_KEY (&ctx->buf[0])
 #define D_KEY (&ctx->buf[60])
 
-static u8 pow_tab[256] __initdata;
-static u8 log_tab[256] __initdata;
-static u8 sbx_tab[256] __initdata;
-static u8 isb_tab[256] __initdata;
+static u8 pow_tab[256] __initdata = {0};
+static u8 log_tab[256] __initdata = {0};
+static u8 sbx_tab[256] __initdata = {0};
+static u8 isb_tab[256] __initdata = {0};
 static u32 rco_tab[10];
 static u32 ft_tab[4][256];
 static u32 it_tab[4][256];

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 22/34] __initdata cleanup - fs
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (20 preceding siblings ...)
  2007-02-09 15:25 ` [PATCH 21/34] __initdata cleanup - aes Alon Bar-Lev
@ 2007-02-09 15:26 ` Alon Bar-Lev
  2007-02-09 15:27 ` [PATCH 23/34] __initdata cleanup - ide Alon Bar-Lev
                   ` (12 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:26 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, viro


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/fs/dcache.c linux-2.6.20-rc6-mm3/fs/dcache.c
--- linux-2.6.20-rc6-mm3.org/fs/dcache.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/fs/dcache.c	2007-01-31 22:19:30.000000000 +0200
@@ -2009,7 +2009,7 @@ ino_t find_inode_number(struct dentry *d
 	return ino;
 }
 
-static __initdata unsigned long dhash_entries;
+static __initdata unsigned long dhash_entries = 0l;
 static int __init set_dhash_entries(char *str)
 {
 	if (!str)
diff -urNp linux-2.6.20-rc6-mm3.org/fs/inode.c linux-2.6.20-rc6-mm3/fs/inode.c
--- linux-2.6.20-rc6-mm3.org/fs/inode.c	2007-01-31 22:15:41.000000000 +0200
+++ linux-2.6.20-rc6-mm3/fs/inode.c	2007-01-31 22:19:30.000000000 +0200
@@ -1355,7 +1355,7 @@ void inode_double_unlock(struct inode *i
 }
 EXPORT_SYMBOL(inode_double_unlock);
 
-static __initdata unsigned long ihash_entries;
+static __initdata unsigned long ihash_entries = 0l;
 static int __init set_ihash_entries(char *str)
 {
 	if (!str)
diff -urNp linux-2.6.20-rc6-mm3.org/fs/nfs/nfsroot.c linux-2.6.20-rc6-mm3/fs/nfs/nfsroot.c
--- linux-2.6.20-rc6-mm3.org/fs/nfs/nfsroot.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/fs/nfs/nfsroot.c	2007-01-31 22:19:30.000000000 +0200
@@ -289,7 +289,7 @@ static int __init root_nfs_parse(char *n
  */
 static int __init root_nfs_name(char *name)
 {
-	static char buf[NFS_MAXPATHLEN] __initdata;
+	static char buf[NFS_MAXPATHLEN] __initdata = { 0, };
 	char *cp;
 
 	/* Set some default values */

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 23/34] __initdata cleanup -  ide
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (21 preceding siblings ...)
  2007-02-09 15:26 ` [PATCH 22/34] __initdata cleanup - fs Alon Bar-Lev
@ 2007-02-09 15:27 ` Alon Bar-Lev
  2007-02-09 15:28 ` [PATCH 24/34] __initdata cleanup - init Alon Bar-Lev
                   ` (11 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:27 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, bzolnier


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/drivers/ide/ide.c linux-2.6.20-rc6-mm3/drivers/ide/ide.c
--- linux-2.6.20-rc6-mm3.org/drivers/ide/ide.c	2007-01-31 22:15:39.000000000 +0200
+++ linux-2.6.20-rc6-mm3/drivers/ide/ide.c	2007-01-31 22:19:30.000000000 +0200
@@ -1483,27 +1483,27 @@ static int __init match_parm (char *s, c
 }
 
 #ifdef CONFIG_BLK_DEV_ALI14XX
-static int __initdata probe_ali14xx;
+static int __initdata probe_ali14xx = 0;
 extern int ali14xx_init(void);
 #endif
 #ifdef CONFIG_BLK_DEV_UMC8672
-static int __initdata probe_umc8672;
+static int __initdata probe_umc8672 = 0;
 extern int umc8672_init(void);
 #endif
 #ifdef CONFIG_BLK_DEV_DTC2278
-static int __initdata probe_dtc2278;
+static int __initdata probe_dtc2278 = 0;
 extern int dtc2278_init(void);
 #endif
 #ifdef CONFIG_BLK_DEV_HT6560B
-static int __initdata probe_ht6560b;
+static int __initdata probe_ht6560b = 0;
 extern int ht6560b_init(void);
 #endif
 #ifdef CONFIG_BLK_DEV_QD65XX
-static int __initdata probe_qd65xx;
+static int __initdata probe_qd65xx = 0;
 extern int qd65xx_init(void);
 #endif
 
-static int __initdata is_chipset_set[MAX_HWIFS];
+static int __initdata is_chipset_set[MAX_HWIFS] = {0};
 
 /*
  * ide_setup() gets called VERY EARLY during initialization,

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 24/34] __initdata cleanup - init
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (22 preceding siblings ...)
  2007-02-09 15:27 ` [PATCH 23/34] __initdata cleanup - ide Alon Bar-Lev
@ 2007-02-09 15:28 ` Alon Bar-Lev
  2007-02-09 15:30 ` [PATCH 25/34] __initdata cleanup - input Alon Bar-Lev
                   ` (10 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:28 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/init/do_mounts.c linux-2.6.20-rc6-mm3/init/do_mounts.c
--- linux-2.6.20-rc6-mm3.org/init/do_mounts.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/init/do_mounts.c	2007-01-31 22:19:30.000000000 +0200
@@ -18,11 +18,11 @@
 
 extern int get_filesystem_list(char * buf);
 
-int __initdata rd_doload;	/* 1 = load RAM disk, 0 = don't load */
+int __initdata rd_doload = 0;	/* 1 = load RAM disk, 0 = don't load */
 
 int root_mountflags = MS_RDONLY | MS_SILENT;
-char * __initdata root_device_name;
-static char __initdata saved_root_name[64];
+char * __initdata root_device_name = NULL;
+static char __initdata saved_root_name[64] = "";
 
 dev_t ROOT_DEV;
 
@@ -214,21 +214,21 @@ static int __init root_dev_setup(char *l
 
 __setup("root=", root_dev_setup);
 
-static char * __initdata root_mount_data;
+static char * __initdata root_mount_data = NULL;
 static int __init root_data_setup(char *str)
 {
 	root_mount_data = str;
 	return 1;
 }
 
-static char * __initdata root_fs_names;
+static char * __initdata root_fs_names = NULL;
 static int __init fs_names_setup(char *str)
 {
 	root_fs_names = str;
 	return 1;
 }
 
-static unsigned int __initdata root_delay;
+static unsigned int __initdata root_delay = 0;
 static int __init root_delay_setup(char *str)
 {
 	root_delay = simple_strtoul(str, NULL, 0);
diff -urNp linux-2.6.20-rc6-mm3.org/init/do_mounts_initrd.c linux-2.6.20-rc6-mm3/init/do_mounts_initrd.c
--- linux-2.6.20-rc6-mm3.org/init/do_mounts_initrd.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/init/do_mounts_initrd.c	2007-01-31 22:19:30.000000000 +0200
@@ -13,7 +13,7 @@
 unsigned long initrd_start, initrd_end;
 int initrd_below_start_ok;
 unsigned int real_root_dev;	/* do_proc_dointvec cannot handle kdev_t */
-static int __initdata old_fd, root_fd;
+static int __initdata old_fd = 0, root_fd = 0;
 static int __initdata mount_initrd = 1;
 
 static int __init no_initrd(char *str)
diff -urNp linux-2.6.20-rc6-mm3.org/init/do_mounts_md.c linux-2.6.20-rc6-mm3/init/do_mounts_md.c
--- linux-2.6.20-rc6-mm3.org/init/do_mounts_md.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/init/do_mounts_md.c	2007-01-31 22:19:30.000000000 +0200
@@ -12,7 +12,7 @@
  * The code for that is here.
  */
 
-static int __initdata raid_noautodetect, raid_autopart;
+static int __initdata raid_noautodetect = 0, raid_autopart = 0;
 
 static struct {
 	int minor;
@@ -20,9 +20,9 @@ static struct {
 	int level;
 	int chunk;
 	char *device_names;
-} md_setup_args[256] __initdata;
+} md_setup_args[256] __initdata = {{0}};
 
-static int md_setup_ents __initdata;
+static int md_setup_ents __initdata = 0;
 
 extern int mdp_major;
 /*
diff -urNp linux-2.6.20-rc6-mm3.org/init/initramfs.c linux-2.6.20-rc6-mm3/init/initramfs.c
--- linux-2.6.20-rc6-mm3.org/init/initramfs.c	2007-01-31 22:15:41.000000000 +0200
+++ linux-2.6.20-rc6-mm3/init/initramfs.c	2007-01-31 22:19:30.000000000 +0200
@@ -7,7 +7,7 @@
 #include <linux/string.h>
 #include <linux/syscalls.h>
 
-static __initdata char *message;
+static __initdata char *message = NULL;
 static void __init error(char *x)
 {
 	if (!message)
@@ -33,7 +33,7 @@ static __initdata struct hash {
 	mode_t mode;
 	struct hash *next;
 	char name[N_ALIGN(PATH_MAX)];
-} *head[32];
+} *head[32] = {0};
 
 static inline int hash(int major, int minor, int ino)
 {
@@ -84,12 +84,12 @@ static void __init free_hash(void)
 
 /* cpio header parsing */
 
-static __initdata unsigned long ino, major, minor, nlink;
-static __initdata mode_t mode;
-static __initdata unsigned long body_len, name_len;
-static __initdata uid_t uid;
-static __initdata gid_t gid;
-static __initdata unsigned rdev;
+static __initdata unsigned long ino = 0l, major = 0l, minor = 0l, nlink = 0l;
+static __initdata mode_t mode = 0;
+static __initdata unsigned long body_len = 0l, name_len = 0l;
+static __initdata uid_t uid = 0;
+static __initdata gid_t gid = 0;
+static __initdata unsigned rdev = 0;
 
 static void __init parse_header(char *s)
 {
@@ -125,13 +125,13 @@ static __initdata enum state {
 	CopyFile,
 	GotSymlink,
 	Reset
-} state, next_state;
+} state = Start, next_state = Start;
 
-static __initdata char *victim;
-static __initdata unsigned count;
-static __initdata loff_t this_header, next_header;
+static __initdata char *victim = NULL;
+static __initdata unsigned count = 0;
+static __initdata loff_t this_header = 0, next_header = 0;
 
-static __initdata int dry_run;
+static __initdata int dry_run = 0;
 
 static inline void eat(unsigned n)
 {
@@ -140,9 +140,9 @@ static inline void eat(unsigned n)
 	count -= n;
 }
 
-static __initdata char *collected;
-static __initdata int remains;
-static __initdata char *collect;
+static __initdata char *collected = NULL;
+static __initdata int remains = 0;
+static __initdata char *collect = NULL;
 
 static void __init read_into(char *buf, unsigned size, enum state next)
 {
@@ -158,7 +158,7 @@ static void __init read_into(char *buf, 
 	}
 }
 
-static __initdata char *header_buf, *symlink_buf, *name_buf;
+static __initdata char *header_buf = NULL, *symlink_buf = NULL, *name_buf = NULL;
 
 static int __init do_start(void)
 {
@@ -257,7 +257,7 @@ static void __init clean_path(char *path
 	}
 }
 
-static __initdata int wfd;
+static __initdata int wfd = 0;
 
 static int __init do_name(void)
 {
@@ -491,7 +491,7 @@ static char * __init unpack_to_rootfs(ch
 	return message;
 }
 
-static int __initdata do_retain_initrd;
+static int __initdata do_retain_initrd = 0;
 
 static int __init retain_initrd_param(char *str)
 {
diff -urNp linux-2.6.20-rc6-mm3.org/init/main.c linux-2.6.20-rc6-mm3/init/main.c
--- linux-2.6.20-rc6-mm3.org/init/main.c	2007-01-31 22:15:41.000000000 +0200
+++ linux-2.6.20-rc6-mm3/init/main.c	2007-01-31 22:19:30.000000000 +0200
@@ -122,7 +122,7 @@ void (*late_time_init)(void);
 extern void softirq_init(void);
 
 /* Untouched command line saved by arch-specific code. */
-char __initdata boot_command_line[COMMAND_LINE_SIZE];
+char __initdata boot_command_line[COMMAND_LINE_SIZE] = "";
 /* Untouched saved command line (eg. for /proc) */
 char *saved_command_line;
 /* Command line for parameter parsing */
@@ -470,7 +470,7 @@ static int __init do_early_param(char *p
 void __init parse_early_param(void)
 {
 	static __initdata int done = 0;
-	static __initdata char tmp_cmdline[COMMAND_LINE_SIZE];
+	static __initdata char tmp_cmdline[COMMAND_LINE_SIZE] = "";
 
 	if (done)
 		return;
@@ -640,7 +640,7 @@ asmlinkage void __init start_kernel(void
 	rest_init();
 }
 
-static int __initdata initcall_debug;
+static int __initdata initcall_debug = 0;
 
 static int __init initcall_debug_setup(char *str)
 {

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 25/34] __initdata cleanup - input
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (23 preceding siblings ...)
  2007-02-09 15:28 ` [PATCH 24/34] __initdata cleanup - init Alon Bar-Lev
@ 2007-02-09 15:30 ` Alon Bar-Lev
  2007-02-09 15:31 ` [PATCH 26/34] __initdata cleanup - intel-rng Alon Bar-Lev
                   ` (9 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:30 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, dmitry.torokhov, dtor


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/drivers/input/joystick/db9.c linux-2.6.20-rc6-mm3/drivers/input/joystick/db9.c
--- linux-2.6.20-rc6-mm3.org/drivers/input/joystick/db9.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/drivers/input/joystick/db9.c	2007-01-31 23:18:42.000000000 +0200
@@ -50,7 +50,7 @@ struct db9_config {
 };
 
 #define DB9_MAX_PORTS		3
-static struct db9_config db9[DB9_MAX_PORTS] __initdata;
+static struct db9_config db9[DB9_MAX_PORTS] __initdata = {{{0}}};
 
 module_param_array_named(dev, db9[0].args, int, &db9[0].nargs, 0);
 MODULE_PARM_DESC(dev, "Describes first attached device (<parport#>,<type>)");
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/input/joystick/gamecon.c linux-2.6.20-rc6-mm3/drivers/input/joystick/gamecon.c
--- linux-2.6.20-rc6-mm3.org/drivers/input/joystick/gamecon.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/drivers/input/joystick/gamecon.c	2007-01-31 23:18:54.000000000 +0200
@@ -51,7 +51,7 @@ struct gc_config {
 	int nargs;
 };
 
-static struct gc_config gc[GC_MAX_PORTS] __initdata;
+static struct gc_config gc[GC_MAX_PORTS] __initdata = {{{0}}};
 
 module_param_array_named(map, gc[0].args, int, &gc[0].nargs, 0);
 MODULE_PARM_DESC(map, "Describes first set of devices (<parport#>,<pad1>,<pad2>,..<pad5>)");
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/input/joystick/turbografx.c linux-2.6.20-rc6-mm3/drivers/input/joystick/turbografx.c
--- linux-2.6.20-rc6-mm3.org/drivers/input/joystick/turbografx.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/drivers/input/joystick/turbografx.c	2007-01-31 23:19:07.000000000 +0200
@@ -51,7 +51,7 @@ struct tgfx_config {
 	int nargs;
 };
 
-static struct tgfx_config tgfx[TGFX_MAX_PORTS] __initdata;
+static struct tgfx_config tgfx[TGFX_MAX_PORTS] __initdata = {{{0}}};
 
 module_param_array_named(map, tgfx[0].args, int, &tgfx[0].nargs, 0);
 MODULE_PARM_DESC(map, "Describes first set of devices (<parport#>,<js1>,<js2>,..<js7>");
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/input/keyboard/amikbd.c linux-2.6.20-rc6-mm3/drivers/input/keyboard/amikbd.c
--- linux-2.6.20-rc6-mm3.org/drivers/input/keyboard/amikbd.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/drivers/input/keyboard/amikbd.c	2007-01-31 22:19:30.000000000 +0200
@@ -215,7 +215,7 @@ static int __init amikbd_init(void)
 		set_bit(i, amikbd_dev->keybit);
 
 	for (i = 0; i < MAX_NR_KEYMAPS; i++) {
-		static u_short temp_map[NR_KEYS] __initdata;
+		static u_short temp_map[NR_KEYS] __initdata = {0};
 		if (!key_maps[i])
 			continue;
 		memset(temp_map, 0, sizeof(temp_map));

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 26/34] __initdata cleanup - intel-rng
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (24 preceding siblings ...)
  2007-02-09 15:30 ` [PATCH 25/34] __initdata cleanup - input Alon Bar-Lev
@ 2007-02-09 15:31 ` Alon Bar-Lev
  2007-02-09 15:31 ` [PATCH 27/34] __initdata cleanup - mm Alon Bar-Lev
                   ` (8 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:31 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, jgarzik


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/drivers/char/hw_random/intel-rng.c linux-2.6.20-rc6-mm3/drivers/char/hw_random/intel-rng.c
--- linux-2.6.20-rc6-mm3.org/drivers/char/hw_random/intel-rng.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/drivers/char/hw_random/intel-rng.c	2007-01-31 22:19:30.000000000 +0200
@@ -143,7 +143,7 @@ static const struct pci_device_id pci_tb
 };
 MODULE_DEVICE_TABLE(pci, pci_tbl);
 
-static __initdata int no_fwh_detect;
+static __initdata int no_fwh_detect = 0;
 module_param(no_fwh_detect, int, 0);
 MODULE_PARM_DESC(no_fwh_detect, "Skip FWH detection:\n"
                                 " positive value - skip if FWH space locked read-only\n"
@@ -219,7 +219,7 @@ static struct hwrng intel_rng = {
 
 
 #ifdef CONFIG_SMP
-static char __initdata waitflag;
+static char __initdata waitflag = 0;
 
 static void __init intel_init_wait(void *unused)
 {

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 27/34] __initdata cleanup - mm
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (25 preceding siblings ...)
  2007-02-09 15:31 ` [PATCH 26/34] __initdata cleanup - intel-rng Alon Bar-Lev
@ 2007-02-09 15:31 ` Alon Bar-Lev
  2007-02-09 15:32 ` [PATCH 28/34] __initdata cleanup - mtd Alon Bar-Lev
                   ` (7 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:31 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, linux-mm


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/mm/page_alloc.c linux-2.6.20-rc6-mm3/mm/page_alloc.c
--- linux-2.6.20-rc6-mm3.org/mm/page_alloc.c	2007-01-31 22:15:42.000000000 +0200
+++ linux-2.6.20-rc6-mm3/mm/page_alloc.c	2007-01-31 22:19:30.000000000 +0200
@@ -101,9 +101,9 @@ static char * const zone_names[MAX_NR_ZO
 
 int min_free_kbytes = 1024;
 
-unsigned long __meminitdata nr_kernel_pages;
-unsigned long __meminitdata nr_all_pages;
-static unsigned long __initdata dma_reserve;
+unsigned long __meminitdata nr_kernel_pages = 0l;
+unsigned long __meminitdata nr_all_pages = 0l;
+static unsigned long __initdata dma_reserve = 0l;
 
 #ifdef CONFIG_ARCH_POPULATES_NODE_MAP
   /*
@@ -126,13 +126,13 @@ static unsigned long __initdata dma_rese
     #endif
   #endif
 
-  struct node_active_region __initdata early_node_map[MAX_ACTIVE_REGIONS];
-  int __initdata nr_nodemap_entries;
-  unsigned long __initdata arch_zone_lowest_possible_pfn[MAX_NR_ZONES];
-  unsigned long __initdata arch_zone_highest_possible_pfn[MAX_NR_ZONES];
+  struct node_active_region __initdata early_node_map[MAX_ACTIVE_REGIONS] = {{0}};
+  int __initdata nr_nodemap_entries = 0;
+  unsigned long __initdata arch_zone_lowest_possible_pfn[MAX_NR_ZONES] = {0};
+  unsigned long __initdata arch_zone_highest_possible_pfn[MAX_NR_ZONES] = {0};
 #ifdef CONFIG_MEMORY_HOTPLUG_RESERVE
-  unsigned long __initdata node_boundary_start_pfn[MAX_NUMNODES];
-  unsigned long __initdata node_boundary_end_pfn[MAX_NUMNODES];
+  unsigned long __initdata node_boundary_start_pfn[MAX_NUMNODES] = {0};
+  unsigned long __initdata node_boundary_end_pfn[MAX_NUMNODES] = {0};
 #endif /* CONFIG_MEMORY_HOTPLUG_RESERVE */
 #endif /* CONFIG_ARCH_POPULATES_NODE_MAP */
 
@@ -1776,7 +1776,7 @@ static int __meminit build_zonelists_nod
 
 #ifdef CONFIG_NUMA
 #define MAX_NODE_LOAD (num_online_nodes())
-static int __meminitdata node_load[MAX_NUMNODES];
+static int __meminitdata node_load[MAX_NUMNODES] = {0};
 /**
  * find_next_best_node - find the next node that should appear in a given node's fallback list
  * @node: node whose fallback list we're appending
diff -urNp linux-2.6.20-rc6-mm3.org/mm/slab.c linux-2.6.20-rc6-mm3/mm/slab.c
--- linux-2.6.20-rc6-mm3.org/mm/slab.c	2007-01-31 22:15:42.000000000 +0200
+++ linux-2.6.20-rc6-mm3/mm/slab.c	2007-01-31 22:19:30.000000000 +0200
@@ -305,7 +305,7 @@ struct kmem_list3 {
  * Need this for bootstrapping a per node allocator.
  */
 #define NUM_INIT_LISTS (2 * MAX_NUMNODES + 1)
-struct kmem_list3 __initdata initkmem_list3[NUM_INIT_LISTS];
+struct kmem_list3 __initdata initkmem_list3[NUM_INIT_LISTS] = {{{0}}};
 #define	CACHE_CACHE 0
 #define	SIZE_AC 1
 #define	SIZE_L3 (1 + MAX_NUMNODES)

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 28/34] __initdata cleanup - mtd
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (26 preceding siblings ...)
  2007-02-09 15:31 ` [PATCH 27/34] __initdata cleanup - mm Alon Bar-Lev
@ 2007-02-09 15:32 ` Alon Bar-Lev
  2007-02-09 15:33 ` [PATCH 29/34] __initdata cleanup - net Alon Bar-Lev
                   ` (6 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:32 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, dwmw2


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/drivers/mtd/devices/block2mtd.c linux-2.6.20-rc6-mm3/drivers/mtd/devices/block2mtd.c
--- linux-2.6.20-rc6-mm3.org/drivers/mtd/devices/block2mtd.c	2007-01-31 22:15:40.000000000 +0200
+++ linux-2.6.20-rc6-mm3/drivers/mtd/devices/block2mtd.c	2007-01-31 22:19:30.000000000 +0200
@@ -424,7 +424,7 @@ static inline void kill_final_newline(ch
 
 #ifndef MODULE
 static int block2mtd_init_called = 0;
-static __initdata char block2mtd_paramline[80 + 12]; /* 80 for device, 12 for erase size */
+static __initdata char block2mtd_paramline[80 + 12] = {0}; /* 80 for device, 12 for erase size */
 #endif
 
 

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 29/34] __initdata cleanup - net
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (27 preceding siblings ...)
  2007-02-09 15:32 ` [PATCH 28/34] __initdata cleanup - mtd Alon Bar-Lev
@ 2007-02-09 15:33 ` Alon Bar-Lev
  2007-02-09 15:33 ` [PATCH 30/34] __initdata cleanup - parallel Alon Bar-Lev
                   ` (5 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:33 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, patrick, davem, kuznet,
	pekkas, jmorris


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/net/decnet/dn_dev.c linux-2.6.20-rc6-mm3/net/decnet/dn_dev.c
--- linux-2.6.20-rc6-mm3.org/net/decnet/dn_dev.c	2007-01-31 22:15:42.000000000 +0200
+++ linux-2.6.20-rc6-mm3/net/decnet/dn_dev.c	2007-01-31 22:19:30.000000000 +0200
@@ -1461,7 +1461,7 @@ static struct rtnetlink_link dnet_rtnetl
 
 };
 
-static int __initdata addr[2];
+static int __initdata addr[2] = {0, 0};
 module_param_array(addr, int, NULL, 0444);
 MODULE_PARM_DESC(addr, "The DECnet address of this machine: area,node");
 
diff -urNp linux-2.6.20-rc6-mm3.org/net/ipv4/route.c linux-2.6.20-rc6-mm3/net/ipv4/route.c
--- linux-2.6.20-rc6-mm3.org/net/ipv4/route.c	2007-01-31 22:15:42.000000000 +0200
+++ linux-2.6.20-rc6-mm3/net/ipv4/route.c	2007-01-31 22:19:30.000000000 +0200
@@ -3103,7 +3103,7 @@ static int ip_rt_acct_read(char *buffer,
 #endif /* CONFIG_PROC_FS */
 #endif /* CONFIG_NET_CLS_ROUTE */
 
-static __initdata unsigned long rhash_entries;
+static __initdata unsigned long rhash_entries = 0l;
 static int __init set_rhash_entries(char *str)
 {
 	if (!str)
diff -urNp linux-2.6.20-rc6-mm3.org/net/ipv4/tcp.c linux-2.6.20-rc6-mm3/net/ipv4/tcp.c
--- linux-2.6.20-rc6-mm3.org/net/ipv4/tcp.c	2007-01-31 22:15:42.000000000 +0200
+++ linux-2.6.20-rc6-mm3/net/ipv4/tcp.c	2007-01-31 22:19:30.000000000 +0200
@@ -2385,7 +2385,7 @@ EXPORT_SYMBOL(__tcp_put_md5sig_pool);
 extern void __skb_cb_too_small_for_tcp(int, int);
 extern struct tcp_congestion_ops tcp_reno;
 
-static __initdata unsigned long thash_entries;
+static __initdata unsigned long thash_entries = 0l;
 static int __init set_thash_entries(char *str)
 {
 	if (!str)

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 30/34] __initdata cleanup - parallel
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (28 preceding siblings ...)
  2007-02-09 15:33 ` [PATCH 29/34] __initdata cleanup - net Alon Bar-Lev
@ 2007-02-09 15:33 ` Alon Bar-Lev
  2007-02-09 15:34 ` [PATCH 31/34] __initdata cleanup - pnp Alon Bar-Lev
                   ` (4 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:33 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, philb, tim, andrea


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/drivers/parport/parport_gsc.c linux-2.6.20-rc6-mm3/drivers/parport/parport_gsc.c
--- linux-2.6.20-rc6-mm3.org/drivers/parport/parport_gsc.c	2007-01-31 22:15:40.000000000 +0200
+++ linux-2.6.20-rc6-mm3/drivers/parport/parport_gsc.c	2007-01-31 22:19:30.000000000 +0200
@@ -350,7 +350,7 @@ struct parport *__devinit parport_gsc_pr
 
 #define PARPORT_GSC_OFFSET 0x800
 
-static int __initdata parport_count;
+static int __initdata parport_count = 0;
 
 static int __devinit parport_init_chip(struct parisc_device *dev)
 {

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 31/34] __initdata cleanup - pnp
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (29 preceding siblings ...)
  2007-02-09 15:33 ` [PATCH 30/34] __initdata cleanup - parallel Alon Bar-Lev
@ 2007-02-09 15:34 ` Alon Bar-Lev
  2007-02-09 15:34 ` [PATCH 32/34] __initdata cleanup - scsi Alon Bar-Lev
                   ` (3 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:34 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, ambx1


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/drivers/pnp/pnpacpi/core.c linux-2.6.20-rc6-mm3/drivers/pnp/pnpacpi/core.c
--- linux-2.6.20-rc6-mm3.org/drivers/pnp/pnpacpi/core.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/drivers/pnp/pnpacpi/core.c	2007-01-31 22:19:30.000000000 +0200
@@ -236,7 +236,7 @@ static acpi_status __init pnpacpi_add_de
 	return AE_OK;
 }
 
-int pnpacpi_disabled __initdata;
+int pnpacpi_disabled __initdata = 0;
 static int __init pnpacpi_init(void)
 {
 	if (acpi_disabled || pnpacpi_disabled) {

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 32/34] __initdata cleanup - scsi
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (30 preceding siblings ...)
  2007-02-09 15:34 ` [PATCH 31/34] __initdata cleanup - pnp Alon Bar-Lev
@ 2007-02-09 15:34 ` Alon Bar-Lev
  2007-02-09 15:35 ` [PATCH 33/34] __initdata cleanup - serial Alon Bar-Lev
                   ` (2 subsequent siblings)
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:34 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, James.Bottomley


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/drivers/scsi/aha1542.c linux-2.6.20-rc6-mm3/drivers/scsi/aha1542.c
--- linux-2.6.20-rc6-mm3.org/drivers/scsi/aha1542.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/drivers/scsi/aha1542.c	2007-01-31 22:19:30.000000000 +0200
@@ -943,7 +943,7 @@ fail:
 }
 
 #ifndef MODULE
-static char *setup_str[MAXBOARDS] __initdata;
+static char *setup_str[MAXBOARDS] __initdata = {0};
 static int setup_idx = 0;
 
 static void __init aha1542_setup(char *str, int *ints)
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/scsi/pluto.c linux-2.6.20-rc6-mm3/drivers/scsi/pluto.c
--- linux-2.6.20-rc6-mm3.org/drivers/scsi/pluto.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/drivers/scsi/pluto.c	2007-01-31 22:19:30.000000000 +0200
@@ -47,7 +47,7 @@ static struct ctrl_inquiry {
 	Scsi_Cmnd cmd;
 	char inquiry[256];
 	fc_channel *fc;
-} *fcs __initdata;
+} *fcs __initdata = NULL;
 static int fcscount __initdata = 0;
 static atomic_t fcss __initdata = ATOMIC_INIT(0);
 DECLARE_MUTEX_LOCKED(fc_sem);

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 33/34] __initdata cleanup - serial
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (31 preceding siblings ...)
  2007-02-09 15:34 ` [PATCH 32/34] __initdata cleanup - scsi Alon Bar-Lev
@ 2007-02-09 15:35 ` Alon Bar-Lev
  2007-02-09 15:35 ` [PATCH 34/34] __initdata cleanup - video Alon Bar-Lev
  2007-02-09 17:00 ` [PATCH 00/34] __initdata cleanup Heiko Carstens
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:35 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml, linux-serial


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/drivers/serial/8250_early.c linux-2.6.20-rc6-mm3/drivers/serial/8250_early.c
--- linux-2.6.20-rc6-mm3.org/drivers/serial/8250_early.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/drivers/serial/8250_early.c	2007-01-31 22:19:30.000000000 +0200
@@ -41,8 +41,8 @@ struct early_uart_device {
 	unsigned int baud;
 };
 
-static struct early_uart_device early_device __initdata;
-static int early_uart_registered __initdata;
+static struct early_uart_device early_device __initdata = {{{{0}}}};
+static int early_uart_registered __initdata = 0;
 
 static unsigned int __init serial_in(struct uart_port *port, int offset)
 {

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [PATCH 34/34] __initdata cleanup - video
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (32 preceding siblings ...)
  2007-02-09 15:35 ` [PATCH 33/34] __initdata cleanup - serial Alon Bar-Lev
@ 2007-02-09 15:35 ` Alon Bar-Lev
  2007-02-09 17:00 ` [PATCH 00/34] __initdata cleanup Heiko Carstens
  34 siblings, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 15:35 UTC (permalink / raw)
  To: linux-kernel, akpm, bwalle, rmk+lkml


Trivial.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Bernhard Walle <bwalle@suse.de>

---

diff -urNp linux-2.6.20-rc6-mm3.org/drivers/video/console/sticore.c linux-2.6.20-rc6-mm3/drivers/video/console/sticore.c
--- linux-2.6.20-rc6-mm3.org/drivers/video/console/sticore.c
+++ linux-2.6.20-rc6-mm3/drivers/video/console/sticore.c
@@ -289,9 +289,9 @@ __setup("sti=", sti_setup);
 
 
 static char __initdata	*font_name[MAX_STI_ROMS] = { "VGA8x16", };
-static int __initdata	font_index[MAX_STI_ROMS], 
-			font_height[MAX_STI_ROMS],
-			font_width[MAX_STI_ROMS];
+static int __initdata	font_index[MAX_STI_ROMS] = {0}, 
+			font_height[MAX_STI_ROMS] = {0},
+			font_width[MAX_STI_ROMS] = {0};
 #ifndef MODULE
 static int __init sti_font_setup(char *str)
 {
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/video/skeletonfb.c linux-2.6.20-rc6-mm3/drivers/video/skeletonfb.c
--- linux-2.6.20-rc6-mm3.org/drivers/video/skeletonfb.c
+++ linux-2.6.20-rc6-mm3/drivers/video/skeletonfb.c
@@ -123,7 +123,7 @@ static struct fb_info info;
      * Each one represents the state of the hardware. Most hardware have
      * just one hardware state. These here represent the default state(s). 
      */
-static struct xxx_par __initdata current_par;
+static struct xxx_par __initdata current_par = {0};
 
 int xxxfb_init(void);
 int xxxfb_setup(char*);
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/video/stifb.c linux-2.6.20-rc6-mm3/drivers/video/stifb.c
--- linux-2.6.20-rc6-mm3.org/drivers/video/stifb.c
+++ linux-2.6.20-rc6-mm3/drivers/video/stifb.c
@@ -111,7 +111,7 @@ struct stifb_info {
 	u32 pseudo_palette[16];
 };
 
-static int __initdata stifb_bpp_pref[MAX_STI_ROMS];
+static int __initdata stifb_bpp_pref[MAX_STI_ROMS] = {0};
 
 /* ------------------- chipset specific functions -------------------------- */
 
@@ -1298,7 +1298,7 @@ out_err0:
 	return -ENXIO;
 }
 
-static int stifb_disabled __initdata;
+static int stifb_disabled __initdata = 0;
 
 int __init
 stifb_setup(char *options);
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/video/vesafb.c linux-2.6.20-rc6-mm3/drivers/video/vesafb.c
--- linux-2.6.20-rc6-mm3.org/drivers/video/vesafb.c
+++ linux-2.6.20-rc6-mm3/drivers/video/vesafb.c
@@ -49,8 +49,8 @@ static struct fb_fix_screeninfo vesafb_f
 
 static int   inverse    __read_mostly;
 static int   mtrr       __read_mostly;		/* disable mtrr */
-static int   vram_remap __initdata;		/* Set amount of memory to be used */
-static int   vram_total __initdata;		/* Set total amount of memory */
+static int   vram_remap __initdata = 0;		/* Set amount of memory to be used */
+static int   vram_total __initdata = 0;		/* Set total amount of memory */
 static int   pmi_setpal __read_mostly = 1;	/* pmi for palette changes ??? */
 static int   ypan       __read_mostly;		/* 0..nothing, 1..ypan, 2..ywrap */
 static void  (*pmi_start)(void) __read_mostly;

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [PATCH 01/34] __initdata cleanup - alpha
  2007-02-09 15:13 ` [PATCH 01/34] __initdata cleanup - alpha Alon Bar-Lev
@ 2007-02-09 16:47   ` Jiri Slaby
  2007-02-09 16:52     ` Alon Bar-Lev
  0 siblings, 1 reply; 45+ messages in thread
From: Jiri Slaby @ 2007-02-09 16:47 UTC (permalink / raw)
  To: Alon Bar-Lev; +Cc: linux-kernel, akpm, bwalle, rmk+lkml, rth

Alon Bar-Lev napsal(a):
> Trivial.
> 
> Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
> Signed-off-by: Bernhard Walle <bwalle@suse.de>
> 
> ---
> 
> diff -urNp linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/setup.c linux-2.6.20-rc6-mm3/arch/alpha/kernel/setup.c
> --- linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/setup.c	2007-01-31 22:15:30.000000000 +0200
> +++ linux-2.6.20-rc6-mm3/arch/alpha/kernel/setup.c	2007-01-31 22:19:30.000000000 +0200
> @@ -122,7 +122,7 @@ static void get_sysnames(unsigned long, 
>  			 char **, char **);
>  static void determine_cpu_caches (unsigned int);
>  
> -static char __initdata command_line[COMMAND_LINE_SIZE];
> +static char __initdata command_line[COMMAND_LINE_SIZE] = "";

Why is this "= 0" to static global variables needed?

regards,
-- 
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [PATCH 01/34] __initdata cleanup - alpha
  2007-02-09 16:47   ` Jiri Slaby
@ 2007-02-09 16:52     ` Alon Bar-Lev
  2007-02-09 17:11       ` Jiri Slaby
  0 siblings, 1 reply; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 16:52 UTC (permalink / raw)
  To: Jiri Slaby; +Cc: linux-kernel, akpm, bwalle, rmk+lkml, rth

On 2/9/07, Jiri Slaby <jirislaby@gmail.com> wrote:
> > -static char __initdata command_line[COMMAND_LINE_SIZE];
> > +static char __initdata command_line[COMMAND_LINE_SIZE] = "";
>
> Why is this "= 0" to static global variables needed?

Please review http://lkml.org/lkml/2007/1/22/267

Best Regards,
Alon Bar-Lev.

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [PATCH 00/34] __initdata cleanup
       [not found] <200702091711.34441.alon.barlev@gmail.com>
                   ` (33 preceding siblings ...)
  2007-02-09 15:35 ` [PATCH 34/34] __initdata cleanup - video Alon Bar-Lev
@ 2007-02-09 17:00 ` Heiko Carstens
  2007-02-09 17:25   ` Alon Bar-Lev
  2007-02-09 17:37   ` Roman Zippel
  34 siblings, 2 replies; 45+ messages in thread
From: Heiko Carstens @ 2007-02-09 17:00 UTC (permalink / raw)
  To: Alon Bar-Lev
  Cc: linux-kernel, akpm, bwalle, rmk+lkml, spyro, davej, hpa, Riley,
	tony.luck, geert, zippel, ralf, matthew, grundler, kyle, paulus,
	schwidefsky, lethal, davem, uclinux-v850, ak, vojtech, chris,
	len.brown, lenb, herbert, viro, bzolnier, dmitry.torokhov, dtor,
	jgarzik, linux-mm, dwmw2, patrick, kuznet, pekkas, jmorris,
	philb, tim, andrea, ambx1, James.Bottomley, linux-serial

On Fri, Feb 09, 2007 at 05:11:32PM +0200, Alon Bar-Lev wrote:
>  
> Follow-up Russell King comment at http://lkml.org/lkml/2007/1/22/267
>
> All __initdata variables should be initialized so they won't end up
> in BSS.
>  
> There is no dependency between patches or even hunks.
>  
> Some architecture patches are untested, this is documented as "UNTESTED"
>  
> Against 2.6.20-rc6-mm3.

To quote parts of that:

Anyway, here's what the GCC manual has to say about use of
__attribute__((section)) on variables:

`section ("SECTION-NAME")'
     Use the `section' attribute with an _initialized_ definition of a
     _global_ variable, as shown in the example.  GCC issues a warning
     and otherwise ignores the `section' attribute in uninitialized
     variable declarations.

     You may only use the `section' attribute with a fully initialized
     global definition because of the way linkers work.  The linker
     requires each object be defined once, with the exception that
     uninitialized variables tentatively go in the `common' (or `bss')
     section and can be multiply "defined".  You can force a variable
     to be initialized with the `-fno-common' flag or the `nocommon'
     attribute.

And the top-level Makefile has:

CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
                   -fno-strict-aliasing -fno-common

Note the -fno-common.

And indeed all the __initdata annotated local and global variables on
s390 are in the init.data section. So I'm wondering what this patch
series is about. Or I must have missed something.

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [PATCH 01/34] __initdata cleanup - alpha
  2007-02-09 16:52     ` Alon Bar-Lev
@ 2007-02-09 17:11       ` Jiri Slaby
  0 siblings, 0 replies; 45+ messages in thread
From: Jiri Slaby @ 2007-02-09 17:11 UTC (permalink / raw)
  To: Alon Bar-Lev; +Cc: Jiri Slaby, linux-kernel, akpm, bwalle, rmk+lkml, rth

Alon Bar-Lev napsal(a):
> On 2/9/07, Jiri Slaby <jirislaby@gmail.com> wrote:
>> > -static char __initdata command_line[COMMAND_LINE_SIZE];
>> > +static char __initdata command_line[COMMAND_LINE_SIZE] = "";
>>
>> Why is this "= 0" to static global variables needed?
> 
> Please review http://lkml.org/lkml/2007/1/22/267

Ok, thanks,
-- 
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [PATCH 00/34] __initdata cleanup
  2007-02-09 17:00 ` [PATCH 00/34] __initdata cleanup Heiko Carstens
@ 2007-02-09 17:25   ` Alon Bar-Lev
  2007-02-09 17:37   ` Roman Zippel
  1 sibling, 0 replies; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 17:25 UTC (permalink / raw)
  To: Heiko Carstens
  Cc: linux-kernel, akpm, bwalle, rmk+lkml, spyro, davej, hpa, Riley,
	tony.luck, geert, zippel, ralf, matthew, grundler, kyle, paulus,
	schwidefsky, lethal, davem, uclinux-v850, ak, vojtech, chris,
	len.brown, lenb, herbert, viro, bzolnier, dmitry.torokhov, dtor,
	jgarzik, linux-mm, dwmw2, patrick, kuznet, pekkas, jmorris,
	philb, tim, andrea, ambx1, James.Bottomley, linux-serial

On Friday 09 February 2007, Heiko Carstens wrote:
> And the top-level Makefile has:
> 
> CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
>                    -fno-strict-aliasing -fno-common
> 
> Note the -fno-common.
> 
> And indeed all the __initdata annotated local and global variables on
> s390 are in the init.data section. So I'm wondering what this patch
> series is about. Or I must have missed something.
> 

Hmmm... You have a valid point!
So it reduces the patch to the following.
>From the previous discussion I was afraid that I added some invalid variables.

Thanks!

Best Regards,
Alon Bar-Lev.

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/e820.c linux-2.6.20-rc6-mm3/arch/x86_64/kernel/e820.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/e820.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/e820.c
@@ -402,10 +402,10 @@ static int __init sanitize_e820_map(stru
 		struct e820entry *pbios; /* pointer to original bios entry */
 		unsigned long long addr; /* address for this change point */
 	};
-	static struct change_member change_point_list[2*E820MAX] __initdata;
-	static struct change_member *change_point[2*E820MAX] __initdata;
-	static struct e820entry *overlap_list[E820MAX] __initdata;
-	static struct e820entry new_bios[E820MAX] __initdata;
+	static struct change_member change_point_list[2*E820MAX] __initdata = {{0}};
+	static struct change_member *change_point[2*E820MAX] __initdata = {0};
+	static struct e820entry *overlap_list[E820MAX] __initdata = {0};
+	static struct e820entry new_bios[E820MAX] __initdata = {{0}};
 	struct change_member *change_tmp;
 	unsigned long current_type, last_type;
 	unsigned long long last_addr;
diff -urNp linux-2.6.20-rc6-mm3.org/fs/nfs/nfsroot.c linux-2.6.20-rc6-mm3/fs/nfs/nfsroot.c
--- linux-2.6.20-rc6-mm3.org/fs/nfs/nfsroot.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/fs/nfs/nfsroot.c	2007-01-31 22:19:30.000000000 +0200
@@ -289,7 +289,7 @@ static int __init root_nfs_parse(char *n
  */
 static int __init root_nfs_name(char *name)
 {
-	static char buf[NFS_MAXPATHLEN] __initdata;
+	static char buf[NFS_MAXPATHLEN] __initdata = { 0, };
 	char *cp;
 
 	/* Set some default values */
diff -urNp linux-2.6.20-rc6-mm3.org/init/main.c linux-2.6.20-rc6-mm3/init/main.c
--- linux-2.6.20-rc6-mm3.org/init/main.c	2007-01-31 22:15:41.000000000 +0200
+++ linux-2.6.20-rc6-mm3/init/main.c	2007-01-31 22:19:30.000000000 +0200
@@ -470,7 +470,7 @@ static int __init do_early_param(char *p
 void __init parse_early_param(void)
 {
 	static __initdata int done = 0;
-	static __initdata char tmp_cmdline[COMMAND_LINE_SIZE];
+	static __initdata char tmp_cmdline[COMMAND_LINE_SIZE] = "";
 
 	if (done)
 		return;
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/input/keyboard/amikbd.c linux-2.6.20-rc6-mm3/drivers/input/keyboard/amikbd.c
--- linux-2.6.20-rc6-mm3.org/drivers/input/keyboard/amikbd.c	2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/drivers/input/keyboard/amikbd.c	2007-01-31 22:19:30.000000000 +0200
@@ -215,7 +215,7 @@ static int __init amikbd_init(void)
 		set_bit(i, amikbd_dev->keybit);
 
 	for (i = 0; i < MAX_NR_KEYMAPS; i++) {
-		static u_short temp_map[NR_KEYS] __initdata;
+		static u_short temp_map[NR_KEYS] __initdata = {0};
 		if (!key_maps[i])
 			continue;
 		memset(temp_map, 0, sizeof(temp_map));

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [PATCH 00/34] __initdata cleanup
  2007-02-09 17:00 ` [PATCH 00/34] __initdata cleanup Heiko Carstens
  2007-02-09 17:25   ` Alon Bar-Lev
@ 2007-02-09 17:37   ` Roman Zippel
  2007-02-09 21:33     ` Andrew Morton
  1 sibling, 1 reply; 45+ messages in thread
From: Roman Zippel @ 2007-02-09 17:37 UTC (permalink / raw)
  To: Heiko Carstens
  Cc: Alon Bar-Lev, linux-kernel, akpm, bwalle, rmk+lkml, spyro, davej,
	hpa, Riley, tony.luck, geert, ralf, matthew, grundler, kyle,
	paulus, schwidefsky, lethal, davem, uclinux-v850, ak, vojtech,
	chris, len.brown, lenb, herbert, viro, bzolnier, dmitry.torokhov,
	dtor, jgarzik, linux-mm, dwmw2, patrick, kuznet, pekkas, jmorris,
	philb, tim, andrea, ambx1, James.Bottomley, linux-serial

Hi,

On Fri, 9 Feb 2007, Heiko Carstens wrote:

> And indeed all the __initdata annotated local and global variables on
> s390 are in the init.data section. So I'm wondering what this patch
> series is about. Or I must have missed something.

I think it reaches back to times when gcc 2.7.* was still supported, which 
does behave as described in the documentation. gcc 2.95 and newer don't 
require explicit initialization anymore, so this has become a non-issue.

bye, Roman

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [PATCH 18/34] __initdata cleanup - x86_64
  2007-02-09 15:24 ` [PATCH 18/34] __initdata cleanup - x86_64 Alon Bar-Lev
@ 2007-02-09 19:35   ` Andi Kleen
  2007-02-09 19:45     ` Bernhard Walle
  0 siblings, 1 reply; 45+ messages in thread
From: Andi Kleen @ 2007-02-09 19:35 UTC (permalink / raw)
  To: Alon Bar-Lev; +Cc: linux-kernel, akpm, bwalle, rmk+lkml, vojtech

On Fri, Feb 09, 2007 at 05:24:28PM +0200, Alon Bar-Lev wrote:
> 
> Trivial.

What is this change good for?

I didn't think any x86_64 binutils had trouble with bss initdata

-Andi

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [PATCH 18/34] __initdata cleanup - x86_64
  2007-02-09 19:35   ` Andi Kleen
@ 2007-02-09 19:45     ` Bernhard Walle
  0 siblings, 0 replies; 45+ messages in thread
From: Bernhard Walle @ 2007-02-09 19:45 UTC (permalink / raw)
  To: Andi Kleen; +Cc: Alon Bar-Lev, linux-kernel, akpm, rmk+lkml, vojtech

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

* Andi Kleen <ak@muc.de> [2007-02-09 20:35]:
> On Fri, Feb 09, 2007 at 05:24:28PM +0200, Alon Bar-Lev wrote:
> > 
> > Trivial.
> 
> What is this change good for?

It was because http://lkml.org/lkml/2007/1/22/267. But since the
kernel is compiled with -fno-common, it's superflous.


Regards,
Bernhard

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [PATCH 00/34] __initdata cleanup
  2007-02-09 17:37   ` Roman Zippel
@ 2007-02-09 21:33     ` Andrew Morton
  2007-02-09 21:48       ` Alon Bar-Lev
  0 siblings, 1 reply; 45+ messages in thread
From: Andrew Morton @ 2007-02-09 21:33 UTC (permalink / raw)
  To: Roman Zippel
  Cc: Heiko Carstens, Alon Bar-Lev, linux-kernel, bwalle, rmk+lkml,
	spyro, davej, hpa, Riley, tony.luck, geert, ralf, matthew,
	grundler, kyle, paulus, schwidefsky, lethal, davem, uclinux-v850,
	ak, vojtech, chris, len.brown, lenb, herbert, viro, bzolnier,
	dmitry.torokhov, dtor, jgarzik, linux-mm, dwmw2, patrick, kuznet,
	pekkas, jmorris, philb, tim, andrea, ambx1, James.Bottomley,
	linux-serial

On Fri, 9 Feb 2007 18:37:34 +0100 (CET)
Roman Zippel <zippel@linux-m68k.org> wrote:

> Hi,
> 
> On Fri, 9 Feb 2007, Heiko Carstens wrote:
> 
> > And indeed all the __initdata annotated local and global variables on
> > s390 are in the init.data section. So I'm wondering what this patch
> > series is about. Or I must have missed something.
> 
> I think it reaches back to times when gcc 2.7.* was still supported, which 
> does behave as described in the documentation. gcc 2.95 and newer don't 
> require explicit initialization anymore, so this has become a non-issue.
> 

Yes, nobody's been observing any problems arising from this, and if this
memory was really uninitialised, people would be hitting problems.

I don't want to have to require that all __attribute__((section)) storage
be initialised - people will surely forget to do it and things will slip
through.

If we really do have a problem here it'd be better to fix it in some
central and global fashion: either by ensuring that each architecture's
startup code will zero this memory or by some compiler/linker option such
as -fno-common.


^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [PATCH 00/34] __initdata cleanup
  2007-02-09 21:33     ` Andrew Morton
@ 2007-02-09 21:48       ` Alon Bar-Lev
  2007-02-09 22:11         ` Andrew Morton
  0 siblings, 1 reply; 45+ messages in thread
From: Alon Bar-Lev @ 2007-02-09 21:48 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, bwalle, rmk+lkml

On 2/9/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> If we really do have a problem here it'd be better to fix it in some
> central and global fashion: either by ensuring that each architecture's
> startup code will zero this memory or by some compiler/linker option such
> as -fno-common.

Great,
But what about the variables that are not in global scope?
As I understand from init.h description:
"Don't forget to initialize data not at file scope, i.e. within a function,
as gcc otherwise puts the data into the bss section and not into the init
section."

Best Regards,
Alon Bar-Lev.

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [PATCH 00/34] __initdata cleanup
  2007-02-09 21:48       ` Alon Bar-Lev
@ 2007-02-09 22:11         ` Andrew Morton
  0 siblings, 0 replies; 45+ messages in thread
From: Andrew Morton @ 2007-02-09 22:11 UTC (permalink / raw)
  To: Alon Bar-Lev; +Cc: linux-kernel, bwalle, rmk+lkml

On Fri, 9 Feb 2007 23:48:36 +0200
"Alon Bar-Lev" <alon.barlev@gmail.com> wrote:

> On 2/9/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> > If we really do have a problem here it'd be better to fix it in some
> > central and global fashion: either by ensuring that each architecture's
> > startup code will zero this memory or by some compiler/linker option such
> > as -fno-common.
> 
> Great,
> But what about the variables that are not in global scope?
> As I understand from init.h description:
> "Don't forget to initialize data not at file scope, i.e. within a function,
> as gcc otherwise puts the data into the bss section and not into the init
> section."
> 

It could be that this is referring to a toolchain which we don't use any
more.  That comment has been there for at least seven years.

This:

--- a/fs/open.c~a
+++ a/fs/open.c
@@ -223,6 +223,8 @@ static long do_sys_truncate(const char _
 	struct inode * inode;
 	int error;
 
+	static char blobwozzle[100] __initdata;
+
 	error = -EINVAL;
 	if (length < 0)	/* sorry, but loff_t says... */
 		goto out;
_

puts the array in .init.data on my fairly old toolchain.

^ permalink raw reply	[flat|nested] 45+ messages in thread

end of thread, other threads:[~2007-02-09 22:11 UTC | newest]

Thread overview: 45+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <200702091711.34441.alon.barlev@gmail.com>
2007-02-09 15:13 ` [PATCH 01/34] __initdata cleanup - alpha Alon Bar-Lev
2007-02-09 16:47   ` Jiri Slaby
2007-02-09 16:52     ` Alon Bar-Lev
2007-02-09 17:11       ` Jiri Slaby
2007-02-09 15:13 ` [PATCH 02/34] __initdata cleanup - arm Alon Bar-Lev
2007-02-09 15:14 ` [PATCH 03/34] __initdata cleanup - avr32 Alon Bar-Lev
2007-02-09 15:15 ` [PATCH 04/34] __initdata cleanup - frv Alon Bar-Lev
2007-02-09 15:15 ` [PATCH 05/34] __initdata cleanup - h8300 Alon Bar-Lev
2007-02-09 15:16 ` [PATCH 06/34] __initdata cleanup - i386 Alon Bar-Lev
2007-02-09 15:17 ` [PATCH 07/34] __initdata cleanup - ia64 Alon Bar-Lev
2007-02-09 15:18 ` [PATCH 08/34] __initdata cleanup - m32r Alon Bar-Lev
2007-02-09 15:19 ` [PATCH 09/34] __initdata cleanup - m68knommu Alon Bar-Lev
2007-02-09 15:19 ` [PATCH 10/34] __initdata cleanup - mips Alon Bar-Lev
2007-02-09 15:20 ` [PATCH 11/34] __initdata cleanup - parisc Alon Bar-Lev
2007-02-09 15:21 ` [PATCH 12/34] __initdata cleanup - powerpc Alon Bar-Lev
2007-02-09 15:21 ` [PATCH 13/34] __initdata cleanup - ppc Alon Bar-Lev
2007-02-09 15:22 ` [PATCH 14/34] __initdata cleanup - s390 Alon Bar-Lev
2007-02-09 15:22 ` [PATCH 15/34] __initdata cleanup - sh Alon Bar-Lev
2007-02-09 15:23 ` [PATCH 16/34] __initdata cleanup - sparc64 Alon Bar-Lev
2007-02-09 15:23 ` [PATCH 17/34] __initdata cleanup - v850 Alon Bar-Lev
2007-02-09 15:24 ` [PATCH 18/34] __initdata cleanup - x86_64 Alon Bar-Lev
2007-02-09 19:35   ` Andi Kleen
2007-02-09 19:45     ` Bernhard Walle
2007-02-09 15:24 ` [PATCH 19/34] __initdata cleanup - xtensa Alon Bar-Lev
2007-02-09 15:25 ` [PATCH 20/34] __initdata cleanup - acpi Alon Bar-Lev
2007-02-09 15:25 ` [PATCH 21/34] __initdata cleanup - aes Alon Bar-Lev
2007-02-09 15:26 ` [PATCH 22/34] __initdata cleanup - fs Alon Bar-Lev
2007-02-09 15:27 ` [PATCH 23/34] __initdata cleanup - ide Alon Bar-Lev
2007-02-09 15:28 ` [PATCH 24/34] __initdata cleanup - init Alon Bar-Lev
2007-02-09 15:30 ` [PATCH 25/34] __initdata cleanup - input Alon Bar-Lev
2007-02-09 15:31 ` [PATCH 26/34] __initdata cleanup - intel-rng Alon Bar-Lev
2007-02-09 15:31 ` [PATCH 27/34] __initdata cleanup - mm Alon Bar-Lev
2007-02-09 15:32 ` [PATCH 28/34] __initdata cleanup - mtd Alon Bar-Lev
2007-02-09 15:33 ` [PATCH 29/34] __initdata cleanup - net Alon Bar-Lev
2007-02-09 15:33 ` [PATCH 30/34] __initdata cleanup - parallel Alon Bar-Lev
2007-02-09 15:34 ` [PATCH 31/34] __initdata cleanup - pnp Alon Bar-Lev
2007-02-09 15:34 ` [PATCH 32/34] __initdata cleanup - scsi Alon Bar-Lev
2007-02-09 15:35 ` [PATCH 33/34] __initdata cleanup - serial Alon Bar-Lev
2007-02-09 15:35 ` [PATCH 34/34] __initdata cleanup - video Alon Bar-Lev
2007-02-09 17:00 ` [PATCH 00/34] __initdata cleanup Heiko Carstens
2007-02-09 17:25   ` Alon Bar-Lev
2007-02-09 17:37   ` Roman Zippel
2007-02-09 21:33     ` Andrew Morton
2007-02-09 21:48       ` Alon Bar-Lev
2007-02-09 22:11         ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).