LKML Archive on
help / color / mirror / Atom feed
From: Russell King <>
To: Imre Deak <>
Subject: Re: [PATCH] DEV: zero: use correct pgprot for zeromapping
Date: Sat, 10 Feb 2007 09:39:54 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sat, Feb 10, 2007 at 11:15:21AM +0200, Imre Deak wrote:
> Instead of PAGE_COPY use the pgprot bits established already at
> original mapping time of the VMA. This will also include any
> architecture specific bits setup through protection_map.
> zeromap_page_range will take care of COW'ing the passed pgprot.

NAK.  What if PAGE_COPY is used elsewhere and ends up accidentally
allowing write access?

I think the right solution is to make PAGE_COPY a variable in the same
way that PAGE_KERNEL is, and adjust it as appropriate.

Russell King
 Linux kernel    2.6 ARM Linux   -
 maintainer of:

  reply	other threads:[~2007-02-10  9:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-10  9:15 Imre Deak
2007-02-10  9:39 ` Russell King [this message]
2007-02-10 10:03   ` Imre Deak
2007-02-10 17:29     ` [PATCH] ARM: VM: fix user page protection values (was Re: [PATCH] DEV: zero: use correct pgprot for zeromapping) Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \
    --subject='Re: [PATCH] DEV: zero: use correct pgprot for zeromapping' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).