LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: Levitsky Maxim <maximlevitsky@yahoo.com>,
	linux-kernel@vger.kernel.org, tori@unhappy.mine.nu,
	netdev@vger.kernel.org, sebastien.hinderer@loria.fr
Subject: Re: [PATCH] [NETDEV] [000]  dmfe : fix bugs and add features
Date: Sat, 10 Feb 2007 16:22:26 +0100	[thread overview]
Message-ID: <20070210152226.GA3482@interface.famille.thibault.fr> (raw)
In-Reply-To: <45CCE46E.9010902@garzik.org>

Hi,

Jeff Garzik, le Fri 09 Feb 2007 16:15:26 -0500, a écrit :
> Levitsky Maxim wrote:
> >Before some time I decided to fix suspend/resume on my Davicom
> >network card.  During development I also fixed couple of bugs and
> >added support for link detection and WOL Note : 2.6.20 already has
> >support for link detection , but it is broken when card has external
> >PHY, like mine.
> >
> >So here it goes:
> >
> >[PATCH] [NET] [001] dmfe : trivial/spelling fixes
> >[PATCH] [NET] [002] dmfe : Fix possible oops
> >[PATCH] [NET] [003] dmfe : fix link detection
> >[PATCH] [NET] [004] dmfe : Add suspend/resume support
> >[PATCH] [NET] [005] dmfe : Add support for wake-on-lan
> 
> >Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe: 
> >support basic carrier detection) breaks networking on my Davicom DM9009. 
> >ethtool always reports there is no link.  tcpdump shows incoming 
> >packets, but TX is disabled.  Reverting the above patch fixes the 
> >problem.
> 
> What about the above report?
> 
> I would rather fix this first, before applying more patches on top of a 
> problematic patch...

My patch wasn't implementing anything actually: it was just making the
existing-since-long link detection code available in ethtools.

Samuel

  reply	other threads:[~2007-02-10 15:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-07 18:26 Levitsky Maxim
2007-02-09 21:15 ` Jeff Garzik
2007-02-10 15:22   ` Samuel Thibault [this message]
2007-02-11 21:12   ` Maxim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070210152226.GA3482@interface.famille.thibault.fr \
    --to=samuel.thibault@ens-lyon.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maximlevitsky@yahoo.com \
    --cc=netdev@vger.kernel.org \
    --cc=sebastien.hinderer@loria.fr \
    --cc=tori@unhappy.mine.nu \
    --subject='Re: [PATCH] [NETDEV] [000]  dmfe : fix bugs and add features' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).