LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christopher Li <sparse@chrisli.org>
To: Andi Kleen <ak@suse.de>
Cc: linux-sparse@vger.kernel.org,
	linux kernel mail list <linux-kernel@vger.kernel.org>,
	Josh Triplett <josh@freedesktop.org>
Subject: Re: [ANNOUNCE] sparse-0.2-cl2 is now available
Date: Sat, 10 Feb 2007 21:17:58 -0800	[thread overview]
Message-ID: <20070211051758.GA2113@chrisli.org> (raw)
In-Reply-To: <p73hctthq8q.fsf@bingen.suse.de>

On Sat, Feb 10, 2007 at 06:33:25PM +0100, Andi Kleen wrote:
> Interesting. Did you find any kernel bugs with this?

In short, not very useful yet.

The current run of of sparse-0.2-cl2 on git default i386 config
will find about 6 place kernel using allocated memory without NULL
check. But Linus said most of them is not worthy checking because
it is in the early stage of the kernel initializations.
It just can't fail on those small memory allocation. May be one
of them worth adding the NULL check.

For interrupt and spinlock checking, it less noisier than the current
sparse context level checking. The new checker code can identify inline
function call, so it has more information. But it is still too noisy.
I did not look at every interrupt and spinlock warning. From what I saw,
it show limit of the checker itself rather than a bug in kernel.

A lot of false positive is come from we don't have enough information
inside a single function.

e.g. sparse has not way to know some function only get called with interrupt
disabled (or some lock already hold). So it assume interrupt is still
enable and generate wrong warnings. Another example is that some helper
function will wrap the locking function. Complain about the exit with locking
hold is wrong.

I am hoping adding the cross function checking will reduce those false positive.
Any way, it need more information to reduce false positive.

I am still working on the cross function checking. May be it will become
more useful one day.

Chris



  reply	other threads:[~2007-02-11  5:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070204085329.GA6520@chrisli.org>
2007-02-10  0:00 ` Christopher Li
2007-02-10 17:33   ` Andi Kleen
2007-02-11  5:17     ` Christopher Li [this message]
2007-02-11  5:50       ` Al Viro
2007-02-11  6:02         ` Christopher Li
2007-02-11 10:41           ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070211051758.GA2113@chrisli.org \
    --to=sparse@chrisli.org \
    --cc=ak@suse.de \
    --cc=josh@freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    --subject='Re: [ANNOUNCE] sparse-0.2-cl2 is now available' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).