LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "J.A. Magallón" <jamagallon@ono.com>
To: Neil Brown <neilb@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: Bio device too big | kernel BUG at mm/filemap.c:537!
Date: Mon, 12 Feb 2007 09:51:27 +0100	[thread overview]
Message-ID: <20070212095127.7ec4b22d@werewolf-wl> (raw)
In-Reply-To: <17865.3776.511594.763544@notabene.brown>

On Wed, 7 Feb 2007 10:26:56 +1100, Neil Brown <neilb@suse.de> wrote:

> On Tuesday February 6, neilb@suse.de wrote:
> > 
> > This patch should fix the worst of the offences, but I'd like to
> > experiment and think a bit more before I submit it to stable.
> > And probably test it too - as yet I have only compile and brain
> > tested.
> 
> Ok, I've experimented and tested and now I know what was causing the
> double-unlock.
> 
> The following patch is suitable for 2.6.20.1 and mainline.  There is
> room for a bit more improvement, but only for performance, not
> correctness.  I'll look into that later.
> 

> +	blk_recount_segments(q, bi);

I needed to export blk_recount_segments() to build raid as a module:

--- linux/block/ll_rw_blk.c.orig	2007-02-12 09:46:55.000000000 +0100
+++ linux/block/ll_rw_blk.c	2007-02-12 09:45:57.000000000 +0100
@@ -1258,6 +1258,8 @@
 	bio->bi_flags |= (1 << BIO_SEG_VALID);
 }
 
+EXPORT_SYMBOL(blk_recount_segments);
+
 static int blk_phys_contig_segment(request_queue_t *q, struct bio *bio,
 				   struct bio *nxt)
 {

--
J.A. Magallon <jamagallon()ono!com>     \               Software is like sex:
                                         \         It's better when it's free
Mandriva Linux release 2007.1 (Cooker) for i586
Linux 2.6.19-jam06 (gcc 4.1.2 20070115 (prerelease) (4.1.2-0.20070115.1mdv2007.1)) #1 SMP PREEMPT

      parent reply	other threads:[~2007-02-12  8:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-06  4:08 Kai
2007-02-06  4:37 ` Andrew Morton
2007-02-06  5:24   ` Neil Brown
2007-02-06 23:26     ` [PATCH] " Neil Brown
2007-02-07  1:15       ` Andrew Morton
2007-02-07  1:30         ` Neil Brown
2007-02-07  1:40           ` Andrew Morton
2007-02-07 16:26       ` Kai
2007-02-07 22:08         ` Neil Brown
2007-02-09 17:15           ` Kai
2007-02-12  8:51       ` J.A. Magallón [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070212095127.7ec4b22d@werewolf-wl \
    --to=jamagallon@ono.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --subject='Re: [PATCH] Re: Bio device too big | kernel BUG at mm/filemap.c:537'\!'' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).