LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Rainer Weikusat <rainer.weikusat@sncag.com>
Cc: Rainer Weikusat <rweikusat@sncag.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Oleg Verych <olecom@flower.upol.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Adrian Bunk <bunk@stusta.de>
Subject: Re: unfixed regression in 2.6.20-rc6 (since 2.6.19)
Date: Mon, 12 Feb 2007 08:37:59 -0800	[thread overview]
Message-ID: <20070212163759.GA15603@kroah.com> (raw)
In-Reply-To: <87abzj5tz5.fsf@semtex.sncag.com>

On Mon, Feb 12, 2007 at 03:30:22PM +0100, Rainer Weikusat wrote:
> Greg KH <greg@kroah.com> writes:
> > On Tue, Jan 30, 2007 at 06:40:10PM +0100, Rainer Weikusat wrote:
> >> Greg KH <greg@kroah.com> writes:
> >> 
> >> [...]
> >> 
> >> > Rainer's problem is a real bug in the USB driver code, which we need to
> >> > work on getting fixed,
> >
> > Ok, here's an updated version, that should tell us where things are
> > going wrong (if they are.)
> >
> > Can you try this out with debugging enabled for the driver:
> > 	modprobe keyspan debug=1
> >
> > and let me know what the output of the kernel log is when you plug your
> > device in?
> 
> I can do all sorts of things, but frankly, I just need my device to
> work (which it does again, courtesy of myself). Apart from that, this
> is still just what a SCO-person would call 'a structural copy' of my
> code with no functional changes, especially none that could result in
> any additional output. I believe it will work as well. Mine does, so
> I am not going to test a different one for the sake of having done so.

Well, as others have reported that this fix works for them, I've sent it
on to Linus and will add it to the 2.6.20-stable tree too.

> If you want to fix it only if you can claim to have written the code,
> fine. If you'll never fix it --- fine as well.

I do not claim I have rewritten the code, if you look, you get full
authorship credit for this fix, I just say I restructured it a bit.

> In either case, I have already put more time into this as I have
> available.

If you still have problems, please let me know.

thanks,

greg k-h

  reply	other threads:[~2007-02-12 16:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-25 15:20 Rainer Weikusat
2007-01-25 18:51 ` Greg KH
2007-01-26 10:43   ` Rainer Weikusat
2007-01-26 17:48     ` Greg KH
2007-01-28 13:34       ` Rainer Weikusat
2007-01-29  1:22         ` Oleg Verych
2007-01-29 23:43           ` Greg KH
2007-01-30 17:40             ` Rainer Weikusat
2007-02-04  4:39               ` Greg KH
2007-02-12 14:30                 ` Rainer Weikusat
2007-02-12 16:37                   ` Greg KH [this message]
2007-02-12 17:10                     ` Rainer Weikusat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070212163759.GA15603@kroah.com \
    --to=greg@kroah.com \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olecom@flower.upol.cz \
    --cc=rainer.weikusat@sncag.com \
    --cc=rweikusat@sncag.com \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: unfixed regression in 2.6.20-rc6 (since 2.6.19)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).