LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joy Latten <latten@austin.ibm.com>
To: ce@ruault.com
Cc: davem@davemloft.net, herbert@gondor.apana.org.au,
	linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: Re:[BUG] 2.6.20 Oopses in xfrm_audit_log
Date: Mon, 12 Feb 2007 11:44:30 -0600	[thread overview]
Message-ID: <200702121744.l1CHiUD2026684@faith.austin.ibm.com> (raw)

>i upgraded to vanilla kernel 2.6.20 and while i was using strongswan 
>2.8.2 to setup an IPSEC VPN i got the following kernel Ooops.
>I had successfully established the same tunnel a few times, but key 
>renegotiation caused a problem ( both ends did not renegotiate at the 
>same time so the tunnel was frozen ), i decided to kill the tunnel and 
>start a new one ( using ipsec auto --down tunnel & ipsec auto --up 
>tunnel ), while i was doing so, i got the oops.
>
>BUG: unable to handle kernel NULL pointer dereference at virtual address 
>00000188
> printing eip:
>c02fb85c
>*pde = 00000000
>Oops: 0000 [#1]
>PREEMPT
>Modules linked in: xfrm4_mode_tunnel usblp deflate zlib_deflate twofish 
>twofish_common serpent blowfish des cbc ecb blkcipher xcbc sha256 sha1 
>crypto_null xfrm4_tunnel tunnel4 ipcomp esp4 ah4 af_key autofs4 asb100 
>hwmon_vid hidp rfcomm l2cap bluetooth sunrpc nf_conntrack_netbios_ns 
>ipt_LOG xt_limit xt_mark xt_state xt_tcpudp iptable_filter 
>ipt_MASQUERADE iptable_nat nf_nat nf_conntrack_ipv4 xt_MARK 
>iptable_mangle ip_tables x_tables binfmt_misc sd_mod ipv6 sg hfsplus 
>video button ac lp parport_pc parport floppy nvram usb_storage scsi_mod 
>libusual usbhid hid ehci_hcd snd_via82xx snd_ac97_codec ac97_bus 
>ohci1394 snd_seq_dummy uhci_hcd ieee1394 snd_seq_oss snd_seq_midi_event 
>snd_seq snd_pcm_oss snd_mixer_oss snd_pcm snd_timer snd_page_alloc 
>snd_mpu401_uart snd_rawmidi snd_seq_device snd via_agp agpgart 
>i2c_viapro soundcore eepro100 i2c_core b44 pcspkr mii shpchp usbcore dm_mod
>CPU:    0
>EIP:    0060:[<c02fb85c>]    Not tainted VLI
>EFLAGS: 00010246   (2.6.20 #1)
>EIP is at xfrm_audit_log+0x4cc/0x580
>eax: ecb71061   ebx: c039d160   ecx: 00000000   edx: 00000021
>esi: 000001f4   edi: 00000255   ebp: 00000000   esp: e8cd5a18
>ds: 007b   es: 007b   ss: 0068
>Process pluto (pid: 27486, ti=e8cd4000 task=d3557070 task.ti=e8cd4000)
>Stack: c17d2ea0 c0354bf1 e183f9c0 00000003 c03ac59c e1399800 00000001 
>00000003
>       f8d0a450 00000000 00000001 00000286 e8cd5a6c c011506b 00000000 
>00000286
>       f73cb8c0 00000246 c17d2ea0 00000000 00000000 f73cb8c0 f8d03c67 
>00000000
>Call Trace:
> [<c011506b>] __wake_up+0x4b/0x80
> [<f8d03c67>] pfkey_broadcast+0x137/0x1b0 [af_key]
> [<f8d03e5f>] pfkey_send_policy_notify+0xef/0x1a0 [af_key]
> [<c011d90e>] local_bh_enable+0x2e/0xa0
> [<c0306107>] xfrm_get_policy+0x2b7/0x2f0
> [<c0305e50>] xfrm_get_policy+0x0/0x2f0
> [<c0304702>] xfrm_user_rcv_msg+0x102/0x1b0
> [<c0304600>] xfrm_user_rcv_msg+0x0/0x1b0
> [<c02b3782>] netlink_run_queue+0x82/0x120
> [<c03045e8>] xfrm_netlink_rcv+0x28/0x40
> [<c02b3d42>] netlink_data_ready+0x12/0x50
> [<c02b2931>] netlink_sendskb+0x21/0x40
> [<c02b3c50>] netlink_sendmsg+0x230/0x310
> [<c02993cd>] sock_aio_write+0x11d/0x130
> [<c01d538a>] avc_has_perm+0x5a/0x70
> [<c0163ed5>] do_sync_write+0xd5/0x120
> [<c012c960>] autoremove_wake_function+0x0/0x50
> [<c01648c7>] vfs_write+0x177/0x180
> [<c0164ea1>] sys_write+0x41/0x70
> [<c0102f14>] syscall_call+0x7/0xb
> =======================
>Code: 8b 44 24 70 c1 e2 08 c1 e8 08 09 c2 0f b7 c2 89 44 24 08 8b 44 24 
>48 89 04 24 e8 10 eb e3 ff e9 bc fc ff ff 8b 8c 24 c0 00 00 00 <8b> 91 
>88 01 00 00 0f b7 99 82 00 00 00 85 d2 0f 85 64 fc ff ff
>EIP: [<c02fb85c>] xfrm_audit_log+0x4cc/0x580 SS:ESP 0068:e8cd5a18
>
>

This is similar to another bug reported last month.
Here is the patch I sent out then. Please let me know
how it goes.

Regards,
Joy

Signed-off-by: Joy Latten <latten@austin.ibm.com>


diff -urpN linux-2.6.19.orig/net/xfrm/xfrm_policy.c linux-2.6.19/net/xfrm/xfrm_policy.c
--- linux-2.6.19.orig/net/xfrm/xfrm_policy.c	2007-01-02 14:24:14.000000000 -0600
+++ linux-2.6.19/net/xfrm/xfrm_policy.c	2007-01-02 14:28:24.000000000 -0600
@@ -2003,6 +2003,9 @@ void xfrm_audit_log(uid_t auid, u32 sid,
 	if (audit_enabled == 0)
 		return;
 
+	if ((x == NULL) && (xp == NULL))
+		return;
+
 	audit_buf = audit_log_start(current->audit_context, GFP_ATOMIC, type);
 	if (audit_buf == NULL)
 	return;
diff -urpN linux-2.6.19.orig/net/xfrm/xfrm_user.c linux-2.6.19/net/xfrm/xfrm_user.c
--- linux-2.6.19.orig/net/xfrm/xfrm_user.c	2007-01-02 14:24:14.000000000 -0600
+++ linux-2.6.19/net/xfrm/xfrm_user.c	2007-01-02 14:28:14.000000000 -0600
@@ -1268,10 +1268,6 @@ static int xfrm_get_policy(struct sk_buf
 		xp = xfrm_policy_bysel_ctx(type, p->dir, &p->sel, tmp.security, delete);
 		security_xfrm_policy_free(&tmp);
 	}
-	if (delete)
-		xfrm_audit_log(NETLINK_CB(skb).loginuid, NETLINK_CB(skb).sid,
-			       AUDIT_MAC_IPSEC_DELSPD, (xp) ? 1 : 0, xp, NULL);
-
 	if (xp == NULL)
 		return -ENOENT;
 
@@ -1289,6 +1285,10 @@ static int xfrm_get_policy(struct sk_buf
 	} else {
 		if ((err = security_xfrm_policy_delete(xp)) != 0)
 			goto out;
+
+		xfrm_audit_log(NETLINK_CB(skb).loginuid, NETLINK_CB(skb).sid,
+			       AUDIT_MAC_IPSEC_DELSPD, (xp) ? 1 : 0, xp, NULL);
+
 		c.data.byid = p->index;
 		c.event = nlh->nlmsg_type;
 		c.seq = nlh->nlmsg_seq;

             reply	other threads:[~2007-02-12 18:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-12 17:44 Joy Latten [this message]
2007-02-12 20:50 ` [BUG] " David Miller
2007-02-12 21:04 ` Charles-Edouard Ruault
2007-02-12 21:46 ` David Miller
2007-02-13  1:02   ` James Morris
2007-02-15  8:22 ` Charles-Edouard Ruault
2007-02-26 10:36 ` Charles-Edouard Ruault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702121744.l1CHiUD2026684@faith.austin.ibm.com \
    --to=latten@austin.ibm.com \
    --cc=ce@ruault.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --subject='Re:[BUG] 2.6.20 Oopses in xfrm_audit_log' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).