LKML Archive on
help / color / mirror / Atom feed
From: Nick Piggin <>
To: Martin Schwidefsky <>
Cc: Andrew Morton <>, Hugh Dickins <>,
	Linux Memory Management <>,
	Linux Kernel <>
Subject: Re: [patch 0/3] 2.6.20 fix for PageUptodate memorder problem (try 3)
Date: Tue, 13 Feb 2007 06:52:29 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <1171147495.31563.5.camel@localhost>

On Sat, Feb 10, 2007 at 11:44:55PM +0100, Martin Schwidefsky wrote:
> On Sat, 2007-02-10 at 03:31 +0100, Nick Piggin wrote:
> > SetNewPageUptodate does not do the S390 page_test_and_clear_dirty, so
> > I'd like to make sure that's OK.
> An I/O operation on s390 will set the dirty bit for a page. That is the

Oh, OK.

> reason to have SetPageUptodate clear the per page dirty bit when the
> page is made uptodate the first time. Otherwise we end up writing each
> page back to its backing device at least once. If SetNewPageUptodate is
> used on new anonymous pages exclusively I don't see a problem in
> omitting the page_test_clear_dirty.

Thanks for the confirmation.

I'll obviously have to resend a new patchset because I made a silly
paper-bag bug with this one. May I say that the s390 specific part of
the change is acked-by: you?

  reply	other threads:[~2007-02-13  5:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-10  2:31 Nick Piggin
2007-02-10  2:31 ` [patch 1/3] mm: make read_cache_page synchronous Nick Piggin
2007-02-10  2:31 ` [patch 2/3] fs: buffer don't PageUptodate without page locked Nick Piggin
2007-02-10  2:31 ` [patch 3/3] mm: fix PageUptodate memorder Nick Piggin
2007-02-10 22:44 ` [patch 0/3] 2.6.20 fix for PageUptodate memorder problem (try 3) Martin Schwidefsky
2007-02-13  5:52   ` Nick Piggin [this message]
2007-02-13  9:25     ` Martin Schwidefsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [patch 0/3] 2.6.20 fix for PageUptodate memorder problem (try 3)' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).