LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: randy.dunlap@oracle.com, linux-usb-devel@lists.sourceforge.net,
	cebbert@redhat.com
Cc: linux-kernel@vger.kernel.org, davej@redhat.com
Subject: Re: [linux-usb-devel] Is this bug too obvious?
Date: Tue, 13 Feb 2007 17:06:23 -0800	[thread overview]
Message-ID: <20070214010623.E0FA7218500@adsl-69-226-248-13.dsl.pltn13.pacbell.net> (raw)
In-Reply-To: <20070213164946.f70d1c8e.randy.dunlap@oracle.com>

No bug; read net/ethernet/eth.c to see what that parameter means.

> > drivers/usb/net/usbnet.c:
> > 
> > int
> > usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
> > {
> >         struct usbnet                   *dev;
> >         struct net_device               *net;
> >         struct usb_host_interface       *interface;
> >         struct driver_info              *info;
> >         struct usb_device               *xdev;
> >         int                             status;
> > 
> > 	...
> > 
> >         net = alloc_etherdev(sizeof(*dev));
> >                                     ^^^^
> > 	                            *net ???

It's allocating *extra* space ... used just a few lines later:

        dev = netdev_priv(net);


  reply	other threads:[~2007-02-14  1:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-14  0:41 Chuck Ebbert
2007-02-14  0:49 ` Randy Dunlap
2007-02-14  1:06   ` David Brownell [this message]
2007-02-14  1:06 ` Daniel Barkalow
2007-02-14  1:13   ` Chuck Ebbert
2007-02-16 22:34     ` usbnet/rndis (was: Is this bug too obvious?) Pete Zaitcev
2007-02-16 23:37       ` [linux-usb-devel] " David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070214010623.E0FA7218500@adsl-69-226-248-13.dsl.pltn13.pacbell.net \
    --to=david-b@pacbell.net \
    --cc=cebbert@redhat.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=randy.dunlap@oracle.com \
    --subject='Re: [linux-usb-devel] Is this bug too obvious?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).