LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: minyard@acm.org
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch 4/4] ipmi: add new IPMI nmi watchdog handling
Date: Wed, 14 Feb 2007 19:57:18 -0800	[thread overview]
Message-ID: <20070214195718.e78458cf.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070214201257.GD5364@localdomain>

On Wed, 14 Feb 2007 14:12:57 -0600 Corey Minyard <minyard@acm.org> wrote:

> 
> Convert over to the new NMI handling for getting IPMI watchdog
> timeouts via an NMI.  This add config options to know if there
> is the ability to receive NMIs and if it has an NMI post processing
> call.  Then it modifies the IPMI watchdog to take advantage of
> this so that it can know if an NMI comes in.
> 
> It also adds testing that the IPMI NMI watchdog works.
> 
> Signed-off-by: Corey Minyard <minyard@acm.org>
> 
> Index: linux-2.6.19-rc6/arch/i386/Kconfig.debug
> ===================================================================
> --- linux-2.6.19-rc6.orig/arch/i386/Kconfig.debug
> +++ linux-2.6.19-rc6/arch/i386/Kconfig.debug
> @@ -4,6 +4,10 @@ config TRACE_IRQFLAGS_SUPPORT
>  	bool
>  	default y
>  
> +config HAVE_STANDARD_NOTIFY_DIE
> +	bool
> +	default y
> +

This is all fairly unpleasant.

What architecture is preventing us from using DIE_NMI_POST on all
architectures which support ipmi?  ia64?

It would be better to simply require that all ipmi-using architectures
implement notify_die(DIE_NMI_POST, ...).


  reply	other threads:[~2007-02-15  3:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-14 20:12 Corey Minyard
2007-02-15  3:57 ` Andrew Morton [this message]
2007-02-15  4:05   ` Paul Mackerras
2007-02-15  4:16     ` Andrew Morton
2007-02-15 15:49       ` Corey Minyard
2007-02-15 22:21         ` Andrew Morton
2007-02-16  0:26           ` Corey Minyard
2007-02-19 20:14           ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070214195718.e78458cf.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --subject='Re: [patch 4/4] ipmi: add new IPMI nmi watchdog handling' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).