LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Igor Stoppa <igor.stoppa@nokia.com>
Cc: ext Nigel Cunningham <ncunningham@linuxmail.org>,
	Alan <alan@lxorguk.ukuu.org.uk>,
	pm list <linux-pm@lists.osdl.org>,
	LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [linux-pm] [RFC][PATCH] PM: Document requirements for basic PM support in	drivers
Date: Wed, 14 Feb 2007 22:24:22 +0100	[thread overview]
Message-ID: <200702142224.25619.rjw@sisk.pl> (raw)
In-Reply-To: <1171467700.16413.12.camel@Dogbert.NOE.nokia.com>

On Wednesday, 14 February 2007 16:41, Igor Stoppa wrote:
> On Tue, 2007-02-13 at 10:47 +1100, ext Nigel Cunningham wrote:
> > Hi.
> > 
> > On Tue, 2007-02-13 at 00:23 +0100, Rafael J. Wysocki wrote:
> > > Hi,
> > > 
> > > Here's my attempt to document the requirements with respect to the basic PM
> > > support in drivers and the testing of that.  Comments welcome.
> > > 
> > > Greetings,
> > > Rafael
> > > 
> > > ---
> > >  Documentation/SubmittingDrivers         |   10 ++
> > >  Documentation/power/drivers-testing.txt |  119 ++++++++++++++++++++++++++++++++
> > >  2 files changed, 129 insertions(+)
> > > 
> > > Index: linux-2.6.20-git4/Documentation/SubmittingDrivers
> > > ===================================================================
> > > --- linux-2.6.20-git4.orig/Documentation/SubmittingDrivers
> > > +++ linux-2.6.20-git4/Documentation/SubmittingDrivers
> > > @@ -87,6 +87,16 @@ Clarity:	It helps if anyone can see how 
> > >  		driver that intentionally obfuscates how the hardware works
> > >  		it will go in the bitbucket.
> > >  
> > > +PM support:	Since Linux is used on many portable and desktop systems, your
> > > +		driver is likely to be used on such a system and therefore it
> > > +		should support basic power management by implementing, if
> > > +		necessary, the .suspend and .resume methods used during the
> > > +		system-wide suspend and resume transitions.  You should verify
> > > +		that your driver correctly handles the suspend and resume, but
> > > +		if you are unable to ensure that, please at least define the
> > > +		.suspend method returning the -ENOSYS ("Function not
> > > +		implemented") error.
> > > +
> > >  Control:	In general if there is active maintainance of a driver by
> > >  		the author then patches will be redirected to them unless
> > >  		they are totally obvious and without need of checking.
> > > Index: linux-2.6.20-git4/Documentation/power/drivers-testing.txt
> > > ===================================================================
> > > --- /dev/null
> > > +++ linux-2.6.20-git4/Documentation/power/drivers-testing.txt
> > > @@ -0,0 +1,119 @@
> > > +Testing suspend and resume support in drivers
> > > +	(C) 2007 Rafael J. Wysocki <rjw@sisk.pl>
> > > +
> > > +Unfortunately, to effectively test the support for the system-wide suspend and
> > > +resume transitions in a driver, it is necessary to suspend and resume a fully
> > > +functional system with this driver loaded.  Moreover, that should be done many
> > > +times, preferably many times in a row, and separately for the suspend to disk
> > > +(STD) and the suspend to RAM (STR) transitions, because each of these cases
> > > +involves different ordering of operations and different interactions with the
> > > +machine's BIOS.
> > > +
> > > +Of course, for this purpose the test system has to be known to suspend and
> > > +resume without the driver being tested.  Thus, if possible, you should first
> > > +resolve all suspend/resume-related problems in the test system before you start
> > > +testing the new driver.
> > > +
> > > +I. Preparing the test system
> > > +
> > > +1. To verify that the STD works, you can try to suspend in the "reboot" mode:
> > > +
> > > +# echo reboot > /sys/power/disk
> > > +# echo disk > /sys/power/state
> > > +
> > > +and the system should suspend, reboot, resume and get back to the command prompt
> > > +where you have started the transition.  If that happens, the STD is most likely
> > > +to work correctly, but you can repeat the test a couple of times in a row for
> > > +confidence.  You should also test the "platform" and "shutdown" modes of
> > 
> > I would say "you need to repeat the test at least a couple of times...",
> > perhaps adding something along the lines of "This is necessary because
> > some problems only show up on a second attempt at suspending and
> > resuming a driver. You can think of it as the driver coming back 'dazed
> > and confused' after the first cycle, and only being properly killed by
> > the second attempt."
> 
> "at least a couple of times" sounds very optimistic :-D

Usually two times are enough to trigger the problem in such cases.

> > 
> > > +suspend:
> > > +
> > > +# echo platform > /sys/power/disk
> > > +# echo disk > /sys/power/state
> > > +
> > > +or
> > > +
> > > +# echo shutdown > /sys/power/disk
> > > +# echo disk > /sys/power/state
> > > +
> > > +in which cases you will have to press the power button to make the system
> > > +resume.  If that works, you are ready to test the STD with the new driver
> > > +loaded.  Otherwise, you have to identify what is wrong.
> > > +
> > > +a) To verify if there are any drivers that cause problems you can run the STD
> > > +in the test mode:
> > > +
> > > +# echo test > /sys/power/disk
> > > +# echo disk > /sys/power/state
> > > +
> > > +in which case the system should freeze tasks, suspend devices, disable nonboot
> > > +CPUs (if any), wait for 5 seconds, enable nonboot CPUs, resume devices, thaw
> > > +tasks and return to your command prompt.  If that fails, most likely there is
> > > +a driver that fails to either suspend or resume (in the latter case the system
> > > +may hang or be unstable after the test, so please take that into consideration).
> > > +To find this driver, you can carry out a binary search according to the rules:
> > > +- if the test fails, unload a half of the drivers currently loaded and repeat
> > > +(that would probably involve rebooting the system, so always note what drivers
> > > +have been loaded before the test),
> > > +- if the test succeeds, load a half of the drivers you have unloaded most
> > > +recently and repeat.
> > > +
> > > +Once you have found the failing driver (there can be more than just one of
> > > +them), you have to unload it every time before the STD transition.  In that case
> > > +please make sure to report the problem with the driver.
> > 
> > It is also possible that a cycle can still fail after you have unloaded
> > all modules. In that case, you would want to look in your kernel
> > configuration for possibilities that can be modularised (testing again
> > with them as modules), and possibly also try boot time options such as
> > noapic or noacpi.
> 
> The first step, imho, would be to identify all the peripherals requiired
> for a barebone configuration to run (i.e. serial console) and verify
> that at least those can reliably go through several suspend/resume
> cycles. Then the dicotomic approach can be used.

I think in most configurations init=/bin/bash loads the minimal set of drivers
needed.  If anyone has certain special need, he will certainly figure out
what to do. :-)

> > 
> > > +
> > > +b) If the test mode of STD works, you can boot the system with "init=/bin/bash"
> > > +and attempt to suspend in the "reboot", "shutdown" and "platform" modes.  If
> > > +that does not work, there probably is a problem with one of the low level
> > > +drivers and you generally cannot do much about it except for reporting it
> > > +(fortunately, that does not happen very often these days).  Otherwise, there is
> > 
> > Oh. Perhaps some of the suggestions from above belong here?
> > 
> > > +a problem with a modular driver and you can find it by loading a half of the
> > > +modules you normally use and binary searching in accordance with the algorithm:
> > > +- if there are n modules loaded and the attempt to suspend and resume fails,
> > > +unload n/2 of the modules and try again (that would probably involve rebooting
> > > +the system),
> > > +- if there are n modules loaded and the attempt to suspend and resume succeeds,
> > > +load n/2 modules more and try again.
> > > +
> > > +Again, if you find the offending module(s), it(they) must be unloaded every time
> > > +before the STD transition, and please report the problem with it(them).
> > > +
> > > +2. To verify that the STR works, it is generally more convenient to use the
> > > +s2ram tool available from http://suspend.sf.net and documented at
> > > +http://en.opensuse.org/s2ram .  However, before doing that it is recommended to
> > > +carry out the procedure described in section 1.
> > > +
> > > +Assume you have resolved the problems with the STD and you have found some
> > > +failing drivers.  These drivers are also likely to fail during the STR or
> > > +during the resume, so it is better to unload them every time before the STR
> > > +transition.  Now, you can follow the instructions at
> > > +http://en.opensuse.org/s2ram to test the system, but if it does not work
> > > +"out of the box", you may need to boot it with "init=/bin/bash" and test
> > > +s2ram in the minimal configuration.  In that case, you may be able to search
> > > +for failing drivers by following the procedure analogous to the one described in
> > > +1b).  If you find some failing drivers, you will have to unload them every time
> > > +before the STR transition (ie. before you run s2ram), and please report the
> > > +problem with them.
> > > +
> > > +II. Testing the driver
> > > +
> > > +Once you have resolved the suspend/resume-related problems with your test system
> > > +without the new driver, you are ready to test it:
> Why not first get the driver working against the barebone configuration?

You can start from the barebone and go towards more complete configurations or
start with a more-or-less complete system and simplify the configuration if
there are problems.  Anyway, however, you need to test against the complete
system eventually, I think.

Greetings,
Rafael

      reply	other threads:[~2007-02-14 21:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-12 23:23 Rafael J. Wysocki
2007-02-12 23:47 ` Nigel Cunningham
2007-02-14 15:41   ` [linux-pm] " Igor Stoppa
2007-02-14 21:24     ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702142224.25619.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=igor.stoppa@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=ncunningham@linuxmail.org \
    --cc=pavel@ucw.cz \
    --subject='Re: [linux-pm] [RFC][PATCH] PM: Document requirements for basic PM support in	drivers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).