LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo@kvack.org>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Marcelo Tosatti <marcelo@kvack.org>,
	Jordan Crouse <jordan.crouse@amd.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use movntq version of fast_clear_page/fast_copy_page on Geode
Date: Thu, 15 Feb 2007 13:01:16 -0200	[thread overview]
Message-ID: <20070215150116.GA5751@dmt.media.mit.edu> (raw)
In-Reply-To: <20070214211646.74b0ad87@localhost.localdomain>

On Wed, Feb 14, 2007 at 09:16:46PM +0000, Alan wrote:
> On Wed, 14 Feb 2007 17:08:39 -0200
> Marcelo Tosatti <marcelo@kvack.org> wrote:
> 
> > 
> > movntq instruction is supported by Geode CPU's, so use
> > fast_clear_page/fast_copy_page versions that have it.
> 
> Is it actually faster for macro performance not just microbenchmarking ?

A COW intensive private mmap() benchmark shows the kernel spending
_more_ time inside mmx_copy_page() with movntq than with movq.

So its not clear whether the patch is actually a win, please drop it.


  reply	other threads:[~2007-02-15 15:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-14 19:08 Marcelo Tosatti
2007-02-14 19:55 ` Dave Jones
2007-02-14 20:17   ` Marcelo Tosatti
2007-02-14 20:47     ` Dave Jones
2007-02-14 21:23     ` Arjan van de Ven
2007-02-14 21:16 ` Alan
2007-02-15 15:01   ` Marcelo Tosatti [this message]
2007-02-14 19:17 Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070215150116.GA5751@dmt.media.mit.edu \
    --to=marcelo@kvack.org \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jordan.crouse@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] use movntq version of fast_clear_page/fast_copy_page on Geode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).