LKML Archive on
help / color / mirror / Atom feed
From: Corey Minyard <>
To: Andrew Morton <>
Cc: Linux Kernel <>
Subject: Re: [patch 3/4] ipmi: add pci remove handling
Date: Thu, 15 Feb 2007 09:53:18 -0600	[thread overview]
Message-ID: <20070215155318.GA24870@localdomain> (raw)
In-Reply-To: <>

On Thu, Feb 15, 2007 at 02:27:45AM -0800, Andrew Morton wrote:
> Judging from the patch headers you were working against 2.6.19, which is
> most optimistic.  Please always prepare and test patches against the
> latest kernel.

Well, I had it applied against a 2.6.20 kernel, but I messed up the
testing of it.  Sorry, my bad.

New patch...

Add pci_remove handling to the driver, so it will clean up if
the device is hot-removed.

Signed-off-by: Corey Minyard <>

Index: linux-2.6.20/drivers/char/ipmi/ipmi_si_intf.c
--- linux-2.6.20.orig/drivers/char/ipmi/ipmi_si_intf.c
+++ linux-2.6.20/drivers/char/ipmi/ipmi_si_intf.c
@@ -2191,12 +2191,15 @@ static int __devinit ipmi_pci_probe(stru
 		info->irq_setup = std_irq_setup;
 	info->dev = &pdev->dev;
+	pdev->dev.driver_data = info;
 	return try_smi_init(info);
 static void __devexit ipmi_pci_remove(struct pci_dev *pdev)
+	struct smi_info *info = pdev->dev.driver_data;
+	cleanup_one_si(info);
 #ifdef CONFIG_PM

  reply	other threads:[~2007-02-15 15:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-14 20:06 Corey Minyard
2007-02-15 10:27 ` Andrew Morton
2007-02-15 15:53   ` Corey Minyard [this message]
2007-02-16 13:16     ` Rolf Eike Beer
2007-02-16 16:13       ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070215155318.GA24870@localdomain \ \ \ \
    --subject='Re: [patch 3/4] ipmi: add pci remove handling' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).