LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Len Brown <lenb@kernel.org>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
	Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: loosen dependancy on rtc cmos
Date: Thu, 15 Feb 2007 21:12:08 -0800	[thread overview]
Message-ID: <200702152112.08970.david-b@pacbell.net> (raw)
In-Reply-To: <200702152338.47151.lenb@kernel.org>

On Thursday 15 February 2007 8:38 pm, Len Brown wrote:

> So I've taken Andi's advice and checked in the patches below.

OK; that simplifies things for me, good!  I can discard that patch
(broken by Andi's pcspkr change anyway), stop worring about whether
most folk will even see that driver, and make time to look at the
ACPI hooks for RTC wakeup, instead.  :)


But it would be nice to see the PNP bus infrastructure upgraded in
various ways too, now that its availability is less iffy.

 - Add something analagous to platform_driver_probe() so that the
   init code can be removed after it runs.

 - Add shutdown() calls to the PNP bus.  Otherwise e.g. one must
   use shutdown notifiers for PNP interfaces, while normal driver
   model code works for other interfaces to such hardware.

Transitioning from "legacy" drivers to PNP (for PCs) and platform_bus
(other platforms) is a bit awkward because of differences like those.
Drivers still need too many different modes; it's too complicated to
have a core with different bus glues as thin veneers ... the glue must
be thicker (and thus error prone).  Similarly, I/O space resource
reservation acts differently.

I can hope that having PNPACPI be more common will start nudging
more drivers to get rid of their "legacy" modes, or at least focus
on "Real Driver" modes that don't involve poking at hardware and
hoping it doesn't bite back.  ;)

- Dave



> commit 243b66e76ab722cdec1921d7f80c0cb808131c37
> Author: Len Brown <len.brown@intel.com>
> Date:   Thu Feb 15 22:34:36 2007 -0500
> 
>     ACPI: always enable CONFIG_PNPACPI on CONFIG_ACPI kernels
>     
>     We removed the ACPI motherboard driver which handled
>     the ACPI=y, PNP=n case, so now we need to enforce that
>     PNP & PNPACPI are always enabled for ACPI kernels.
>     
>     Most major distros ship this way this already.
>     
>     Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
>     Signed-off-by: Len Brown <len.brown@intel.com>
> 


> commit 8d4956c201c2f7683289f70095443c59a39f94ef
> Author: Len Brown <len.brown@intel.com>
> Date:   Thu Feb 15 22:46:42 2007 -0500
> 
>     ACPI: remove non-PNPACPI version of get_rtc_dev()
>     
>     It isn't needed in ACPI code anymore because
>     now ACPI always includes PNPACPI.
>     
>     Cc: David Brownell <david-b@pacbell.net>
>     Signed-off-by: Len Brown <len.brown@intel.com>
> 


  reply	other threads:[~2007-02-16  5:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-14 18:09 Dave Jones
2007-02-14 19:55 ` David Brownell
2007-02-14 23:20   ` Len Brown
2007-02-14 23:47     ` David Brownell
2007-02-16  4:38       ` Len Brown
2007-02-16  5:12         ` David Brownell [this message]
2007-02-17  0:36           ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702152112.08970.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=bjorn.helgaas@hp.com \
    --cc=davej@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: loosen dependancy on rtc cmos' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).