LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/1] -  acpi_unload_table_id() always returns error
@ 2007-02-15 20:08 John Keller
  2007-02-16  4:29 ` Len Brown
  0 siblings, 1 reply; 3+ messages in thread
From: John Keller @ 2007-02-15 20:08 UTC (permalink / raw)
  To: linux-acpi; +Cc: ayoung, linux-ia64, linux-kernel, John Keller

acpi_unload_table_id() is always returning an error status.
Also, once the matching table is found, don't bother looking
for another match.


Signed-off-by: John Keller <jpk@sgi.com>
---


Index: release/drivers/acpi/tables/tbxface.c
===================================================================
--- release.orig/drivers/acpi/tables/tbxface.c	2007-02-13 08:20:42.000000000 -0600
+++ release/drivers/acpi/tables/tbxface.c	2007-02-15 14:04:07.855248010 -0600
@@ -338,9 +338,9 @@ acpi_status acpi_unload_table_id(acpi_ow
 	int i;
 	acpi_status status = AE_NOT_EXIST;
 
-	ACPI_FUNCTION_TRACE(acpi_unload_table);
+	ACPI_FUNCTION_TRACE(acpi_unload_table_id);
 
-	/* Find table from the requested type list */
+	/* Find table in the global table list */
 	for (i = 0; i < acpi_gbl_root_table_list.count; ++i) {
 		if (id != acpi_gbl_root_table_list.tables[i].owner_id) {
 			continue;
@@ -352,8 +352,9 @@ acpi_status acpi_unload_table_id(acpi_ow
 		* simply a position within the hierarchy
 		*/
 		acpi_tb_delete_namespace_by_owner(i);
-		acpi_tb_release_owner_id(i);
+		status = acpi_tb_release_owner_id(i);
 		acpi_tb_set_table_loaded_flag(i, FALSE);
+		break;
 	}
 	return_ACPI_STATUS(status);
 }

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] -  acpi_unload_table_id() always returns error
  2007-02-15 20:08 [PATCH 1/1] - acpi_unload_table_id() always returns error John Keller
@ 2007-02-16  4:29 ` Len Brown
  2007-02-16 13:53   ` John Keller
  0 siblings, 1 reply; 3+ messages in thread
From: Len Brown @ 2007-02-16  4:29 UTC (permalink / raw)
  To: John Keller; +Cc: linux-acpi, ayoung, linux-ia64, linux-kernel

Thanks for the fix, John.
Do you grant Intel permission to apply it to the upstream ACPICA tree (with its non-GPL license)?

-Len

On Thursday 15 February 2007 15:08, John Keller wrote:
> acpi_unload_table_id() is always returning an error status.
> Also, once the matching table is found, don't bother looking
> for another match.
> 
> 
> Signed-off-by: John Keller <jpk@sgi.com>
> ---
> 
> 
> Index: release/drivers/acpi/tables/tbxface.c
> ===================================================================
> --- release.orig/drivers/acpi/tables/tbxface.c	2007-02-13 08:20:42.000000000 -0600
> +++ release/drivers/acpi/tables/tbxface.c	2007-02-15 14:04:07.855248010 -0600
> @@ -338,9 +338,9 @@ acpi_status acpi_unload_table_id(acpi_ow
>  	int i;
>  	acpi_status status = AE_NOT_EXIST;
>  
> -	ACPI_FUNCTION_TRACE(acpi_unload_table);
> +	ACPI_FUNCTION_TRACE(acpi_unload_table_id);
>  
> -	/* Find table from the requested type list */
> +	/* Find table in the global table list */
>  	for (i = 0; i < acpi_gbl_root_table_list.count; ++i) {
>  		if (id != acpi_gbl_root_table_list.tables[i].owner_id) {
>  			continue;
> @@ -352,8 +352,9 @@ acpi_status acpi_unload_table_id(acpi_ow
>  		* simply a position within the hierarchy
>  		*/
>  		acpi_tb_delete_namespace_by_owner(i);
> -		acpi_tb_release_owner_id(i);
> +		status = acpi_tb_release_owner_id(i);
>  		acpi_tb_set_table_loaded_flag(i, FALSE);
> +		break;
>  	}
>  	return_ACPI_STATUS(status);
>  }
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] -  acpi_unload_table_id() always returns error
  2007-02-16  4:29 ` Len Brown
@ 2007-02-16 13:53   ` John Keller
  0 siblings, 0 replies; 3+ messages in thread
From: John Keller @ 2007-02-16 13:53 UTC (permalink / raw)
  To: Len Brown; +Cc: John Keller, linux-acpi, ayoung, linux-ia64, linux-kernel

Yes.

      I understand and agree this project and the contribution
      are public and that a record of the contribution (including all
      personal information I submit with it, including my sign-off) is
      maintained indefinitely. I thereby license this patch to be
      redistributed under any license (GPL or non-GPL) consistent
      with the project.

John


> 
> Thanks for the fix, John.
> Do you grant Intel permission to apply it to the upstream ACPICA tree (with its non-GPL license)?
> 
> -Len
> 
> On Thursday 15 February 2007 15:08, John Keller wrote:
> > acpi_unload_table_id() is always returning an error status.
> > Also, once the matching table is found, don't bother looking
> > for another match.
> > 
> > 
> > Signed-off-by: John Keller <jpk@sgi.com>
> > ---
> > 
> > 
> > Index: release/drivers/acpi/tables/tbxface.c
> > ===================================================================
> > --- release.orig/drivers/acpi/tables/tbxface.c	2007-02-13 08:20:42.000000000 -0600
> > +++ release/drivers/acpi/tables/tbxface.c	2007-02-15 14:04:07.855248010 -0600
> > @@ -338,9 +338,9 @@ acpi_status acpi_unload_table_id(acpi_ow
> >  	int i;
> >  	acpi_status status = AE_NOT_EXIST;
> >  
> > -	ACPI_FUNCTION_TRACE(acpi_unload_table);
> > +	ACPI_FUNCTION_TRACE(acpi_unload_table_id);
> >  
> > -	/* Find table from the requested type list */
> > +	/* Find table in the global table list */
> >  	for (i = 0; i < acpi_gbl_root_table_list.count; ++i) {
> >  		if (id != acpi_gbl_root_table_list.tables[i].owner_id) {
> >  			continue;
> > @@ -352,8 +352,9 @@ acpi_status acpi_unload_table_id(acpi_ow
> >  		* simply a position within the hierarchy
> >  		*/
> >  		acpi_tb_delete_namespace_by_owner(i);
> > -		acpi_tb_release_owner_id(i);
> > +		status = acpi_tb_release_owner_id(i);
> >  		acpi_tb_set_table_loaded_flag(i, FALSE);
> > +		break;
> >  	}
> >  	return_ACPI_STATUS(status);
> >  }
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-02-16 13:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-15 20:08 [PATCH 1/1] - acpi_unload_table_id() always returns error John Keller
2007-02-16  4:29 ` Len Brown
2007-02-16 13:53   ` John Keller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).