LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: David Brownell <david-b@pacbell.net>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	Andi Kleen <ak@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	ebiederm@xmission.com, kai@germaschewski.name,
	Russell King <rmk@arm.linux.org.uk>,
	rusty@rustcorp.com.au
Subject: Re: [patch 2.6.20-git] remove modpost false warnings on ARM
Date: Fri, 16 Feb 2007 09:26:48 +0100	[thread overview]
Message-ID: <20070216082648.GA11771@uranus.ravnborg.org> (raw)
In-Reply-To: <200702151910.46397.david-b@pacbell.net>

On Thu, Feb 15, 2007 at 07:10:45PM -0800, David Brownell wrote:
> This patch stops "modpost" from issuing erroneous modpost warnings on ARM
> builds, which it's been doing since since maybe last summer.  A canonical
> example would be driver method table entries:
> 
>   WARNING: <path> - Section mismatch: reference to .exit.text:<name>_remove
> 	from .data after '$d' (at offset 0x4)
> 
> That "$d" symbol is generated by tools conformant with ARM ABI specs; in
> this case it's a symbol **in the middle of** a "<name>_driver" struct.
> 
> The erroneous warnings appear to be issued because "modpost" whitelists
> references from "<name>_driver" data into init and exit sections ... but
> doesn't know should also include those "$d" mapping symbols, which are
> not otherwise associated with "<name>_driver" symbols.
> 
> This patch prevents the modpost symbol lookup code from ever returning
> those mapping symbols, so it will return a whitelisted symbol instead.
> Then things work as expected.
> 
> Now to revert various code-bloating "fixes" that got merged because of
> this modpost bug....
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Acked-by: Sam Ravnborg <sam@ravnborg.org>

And if I get my dev machine operational before akpm merges this I
will take care of having it merged.

      parent reply	other threads:[~2007-02-16  8:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-12 16:31 [patch 2.6.20-rc4-git] " David Brownell
2007-01-12 16:38 ` Russell King
2007-01-12 20:13   ` David Brownell
2007-02-16  3:10 ` [patch 2.6.20-git] " David Brownell
2007-02-16  3:28   ` Rusty Russell
2007-02-16  8:26   ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070216082648.GA11771@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=david-b@pacbell.net \
    --cc=ebiederm@xmission.com \
    --cc=kai@germaschewski.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=rusty@rustcorp.com.au \
    --subject='Re: [patch 2.6.20-git] remove modpost false warnings on ARM' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).