LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeff Garzik <jeff@garzik.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [git patches] libata updates (mostly fixes)
Date: Fri, 16 Feb 2007 13:03:12 +0100	[thread overview]
Message-ID: <20070216120312.GL13958@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0702151546130.20368@woody.linux-foundation.org>

On Thu, Feb 15, 2007 at 03:48:04PM -0800, Linus Torvalds wrote:
> 
> 
> On Thu, 15 Feb 2007, Jeff Garzik wrote:
> > 
> > diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
> > index db185f3..d51f0f1 100644
> > --- a/arch/ia64/Kconfig
> > +++ b/arch/ia64/Kconfig
> > @@ -22,6 +22,7 @@ config IA64
> >  
> >  config 64BIT
> >  	bool
> > +	select ATA_NONSTANDARD if ATA
> >  	default y
> 
> Ok, this is just _strange_.
> 
> Tying ATA_NONSTANDARD into ia64 by tying it to the 64BIT config variable 
> may work (well, I _assume_ it does), but it's just psychedelic.
> 
> How about adding a separate config entry like
> 
> 	config IA64_ATA
> 		bool
> 		depends on ATA
> 		select ATA_NONSTANDARD
> 		default y
> 
> which kind of makes sense when you squint just the right way..


What about simply providing asm/libata-portmap.h on all architectures 
instead of this ATA_NONSTANDARD trickery?


> 		Linus

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


      parent reply	other threads:[~2007-02-16 12:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-15 23:34 Jeff Garzik
2007-02-15 23:43 ` Jeff Garzik
2007-02-21 11:25   ` [PATCH] libata: test major version in ata_id_is_sata() Tejun Heo
2007-02-23 10:37     ` Jeff Garzik
2007-02-15 23:48 ` [git patches] libata updates (mostly fixes) Linus Torvalds
2007-02-15 23:51   ` Linus Torvalds
2007-02-16  2:09   ` Jeff Garzik
2007-02-16 12:03   ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070216120312.GL13958@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [git patches] libata updates (mostly fixes)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).