LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nick Piggin <npiggin@suse.de>
To: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [patch] mm: NUMA replicated pagecache
Date: Fri, 16 Feb 2007 14:35:46 +0100	[thread overview]
Message-ID: <20070216133545.GB3036@wotan.suse.de> (raw)
In-Reply-To: <1171582169.5114.86.camel@localhost>

On Thu, Feb 15, 2007 at 06:29:29PM -0500, Lee Schermerhorn wrote:
> 
> I've attached another patch that closes one race and fixes a context
> problem [irq/preemption state] in __unreplicate_page_range().  This
> makes the locking even uglier :-(.
> 
> I get further with this patch.  Boot all the way up and can run fine
> with page replication.  However, I still get a NULL pcd in
> find_get_page_readonly() when attempting a highly parallel kernel build
> [16cpu/4node numa platform].  I'm still trying to track that down.

OK, before you get further with your testing, I have done a rework. Sorry
you had to wade through that last lot of uncommented spaghetti. This
upcoming version should actually be a reasonable base to do testing and
development on.

> Question about locking:  looks like the pcache_descriptor members are
> protected by the tree_lock of the mapping, right?

Yes. I figured that this would be cleanest and simplest for now. This
locking model is retained in the rework.

Nick

      reply	other threads:[~2007-02-16 13:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-13  6:09 Nick Piggin
2007-02-13  6:09 ` Nick Piggin
2007-02-14  4:28 ` Nick Piggin
2007-02-14 18:57 ` Christoph Lameter
2007-02-15  0:07   ` Nick Piggin
2007-02-14 19:00 ` Christoph Lameter
2007-02-15  0:10   ` Nick Piggin
2007-02-15  0:13     ` Christoph Lameter
2007-02-14 20:32 ` Lee Schermerhorn
2007-02-15  0:38   ` Nick Piggin
2007-02-15 23:29     ` Lee Schermerhorn
2007-02-16 13:35       ` Nick Piggin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070216133545.GB3036@wotan.suse.de \
    --to=npiggin@suse.de \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --subject='Re: [patch] mm: NUMA replicated pagecache' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).