From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965214AbXBQLuu (ORCPT ); Sat, 17 Feb 2007 06:50:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965215AbXBQLuu (ORCPT ); Sat, 17 Feb 2007 06:50:50 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:57415 "EHLO amd.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965214AbXBQLuu (ORCPT ); Sat, 17 Feb 2007 06:50:50 -0500 Date: Sat, 17 Feb 2007 12:50:29 +0100 From: Pavel Machek To: Maxim Cc: netdev@kernel.org, linux-kernel@vger.kernel.org Subject: Re: Subject: [PATCH 2.6.20 004/005] dmfe: Add support for suspend/resume Message-ID: <20070217115029.GF9120@elf.ucw.cz> References: <200702152253.53680.maximlevitsky@gmail.com> <200702152311.54407.maximlevitsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200702152311.54407.maximlevitsky@gmail.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > @@ -2050,11 +2047,56 @@ static struct pci_device_id dmfe_pci_tbl > MODULE_DEVICE_TABLE(pci, dmfe_pci_tbl); > > > + > +static int dmfe_suspend(struct pci_dev *pci_dev, pm_message_t state) > +{ > + struct net_device *dev = pci_get_drvdata(pci_dev); > + struct dmfe_board_info *db = netdev_priv(dev); > + > + /* Disable upper layer interface */ > + netif_device_detach (dev); > + > + /* Disable Tx/Rx */ > + db->cr6_data &= ~(CR6_RXSC | CR6_TXSC); > + update_cr6(db->cr6_data, dev->base_addr); > + > + /* Disable Interrupt */ > + outl (0, dev->base_addr + DCR7); > + outl (inl (dev->base_addr + DCR5), dev->base_addr + DCR5); Please no space between function and "(". > + /* Fre RX buffers */ Free? > + dmfe_free_rxbuffer (db); > + /* Power down device*/ " */" > + pci_set_power_state (pci_dev, pci_choose_state (pci_dev,state)); Let it be ", state", and delete spaces between function and "(". > +static int dmfe_resume (struct pci_dev *pci_dev) delete spaces between function and "(". > + pci_restore_state(pci_dev); > + pci_set_power_state(pci_dev ,PCI_D0); > + ", " Otherwise looks ok to me. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html