LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] make xfs_buftarg_list static again
@ 2007-02-20  0:07 Adrian Bunk
  2007-02-20  0:41 ` David Chinner
  2007-02-20  1:08 ` [xfs-masters] " Timothy Shimmin
  0 siblings, 2 replies; 3+ messages in thread
From: Adrian Bunk @ 2007-02-20  0:07 UTC (permalink / raw)
  To: David Chinner; +Cc: xfs-masters, linux-kernel

xfs_buftarg_list became global for no good reason.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---
--- linux-2.6.20-mm2/fs/xfs/linux-2.6/xfs_buf.c.old	2007-02-18 22:55:40.000000000 +0100
+++ linux-2.6.20-mm2/fs/xfs/linux-2.6/xfs_buf.c	2007-02-18 22:56:08.000000000 +0100
@@ -1424,7 +1424,7 @@
 /*
  *	buftarg list for delwrite queue processing
  */
-LIST_HEAD(xfs_buftarg_list);
+static LIST_HEAD(xfs_buftarg_list);
 static DEFINE_SPINLOCK(xfs_buftarg_lock);
 
 STATIC void


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] make xfs_buftarg_list static again
  2007-02-20  0:07 [2.6 patch] make xfs_buftarg_list static again Adrian Bunk
@ 2007-02-20  0:41 ` David Chinner
  2007-02-20  1:08 ` [xfs-masters] " Timothy Shimmin
  1 sibling, 0 replies; 3+ messages in thread
From: David Chinner @ 2007-02-20  0:41 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: xfs-masters, linux-kernel, tes

On Tue, Feb 20, 2007 at 01:07:47AM +0100, Adrian Bunk wrote:
> xfs_buftarg_list became global for no good reason.

Fallout from a much larger patch. Looks like there were a couple
of STATIC -> static conversions stuffed up. Thanks for catching
this, Adrian.

Tim - another one for you ;)

> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> ---
> --- linux-2.6.20-mm2/fs/xfs/linux-2.6/xfs_buf.c.old	2007-02-18 22:55:40.000000000 +0100
> +++ linux-2.6.20-mm2/fs/xfs/linux-2.6/xfs_buf.c	2007-02-18 22:56:08.000000000 +0100
> @@ -1424,7 +1424,7 @@
>  /*
>   *	buftarg list for delwrite queue processing
>   */
> -LIST_HEAD(xfs_buftarg_list);
> +static LIST_HEAD(xfs_buftarg_list);
>  static DEFINE_SPINLOCK(xfs_buftarg_lock);
>  
>  STATIC void

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [xfs-masters] [2.6 patch] make xfs_buftarg_list static again
  2007-02-20  0:07 [2.6 patch] make xfs_buftarg_list static again Adrian Bunk
  2007-02-20  0:41 ` David Chinner
@ 2007-02-20  1:08 ` Timothy Shimmin
  1 sibling, 0 replies; 3+ messages in thread
From: Timothy Shimmin @ 2007-02-20  1:08 UTC (permalink / raw)
  To: xfs-masters, David Chinner, bunk; +Cc: linux-kernel

Hi Adrian,

--On 20 February 2007 1:07:47 AM +0100 Adrian Bunk <bunk@stusta.de> wrote:

> xfs_buftarg_list became global for no good reason.
>

That's true. I'll make the change for git if Dave has no objections.

It happened because in the SGI tree we want it global for use in kdb by xfsidbg.o,
and that used to happen in the CONFIG_XFS_DEBUG case where STATIC would define
to nothing - looks like it is global always in our tree now since Dave's patch.
i.e. it was actually becoming global previously via STATIC on CONFIG_XFS_DEBUG
but one wouldn't have noticed that :) AFAICT.
Hmmm, I'll talk to Dave about this.

--Tim

> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
> --- linux-2.6.20-mm2/fs/xfs/linux-2.6/xfs_buf.c.old	2007-02-18 22:55:40.000000000 +0100
> +++ linux-2.6.20-mm2/fs/xfs/linux-2.6/xfs_buf.c	2007-02-18 22:56:08.000000000 +0100
> @@ -1424,7 +1424,7 @@
>  /*
>   *	buftarg list for delwrite queue processing
>   */
> -LIST_HEAD(xfs_buftarg_list);
> +static LIST_HEAD(xfs_buftarg_list);
>  static DEFINE_SPINLOCK(xfs_buftarg_lock);
>
>  STATIC void
>
>





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-02-20  1:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-20  0:07 [2.6 patch] make xfs_buftarg_list static again Adrian Bunk
2007-02-20  0:41 ` David Chinner
2007-02-20  1:08 ` [xfs-masters] " Timothy Shimmin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).