LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: Jaya Kumar <jayakumar.lkml@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-fbdev-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	jsimmons@infradead.org, Geert.Uytterhoeven@sonycom.com
Subject: Re: [PATCH 2.6.20 1/1] fbdev,mm: hecuba/E-Ink fbdev driver
Date: Tue, 20 Feb 2007 13:38:48 +0900	[thread overview]
Message-ID: <20070220043848.GA4092@linux-sh.org> (raw)
In-Reply-To: <45a44e480702192013s7d49d05ai31e576f0448a485e@mail.gmail.com>

On Mon, Feb 19, 2007 at 11:13:04PM -0500, Jaya Kumar wrote:
> On 2/18/07, Paul Mundt <lethal@linux-sh.org> wrote:
> >Given that, this would have to be something that's dealt with at the
> >subsystem level rather than in individual drivers, hence the desire to
> >see something like this more generically visible.
> >
> 
> Hi Peter, Paul, fbdev folk,
> 
> Ok. Here's what I'm thinking for abstracting this:
> 
> fbdev drivers would setup fb_mmap with their own_mmap as usual. In
> own_mmap, they would do what they normally do and setup a vm_ops. They
> are free to have their own nopage handler but would set the
> page_mkwrite handler to be fbdev_deferred_io_mkwrite().

The vast majority of drivers do not implement ->fb_mmap(), and with
proper abstraction, this should be something that's possible as a direct
alternative to drivers/video/fbmem.c:fb_mmap() for the people that want
it. Of course it's just as easy to do something like the sbuslib.c route
and then have drivers set their ->fb_mmap() from that too.

> fbdev_deferred_io_mkwrite would build up the list of touched pages and
> pass it to a delayed workqueue which would then mkclean on each page
> and then pass a copy of that page list down to a driver's callback
> function. The fbdev driver's callback function can then do the actual
> IO to the framebuffer or coalesce DMA based on the provided page list.
> 
That works for me, though I'd prefer for struct page_list to be done with
a scatterlist, then it's trivial to setup from the workqueue context
without having to shuffle things around.

  reply	other threads:[~2007-02-20  4:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-17 10:42 Jaya Kumar
2007-02-17 12:34 ` Peter Zijlstra
2007-02-17 13:25   ` Jaya Kumar
2007-02-17 13:59     ` Paul Mundt
2007-02-18 11:31       ` Jaya Kumar
2007-02-18 23:57         ` Paul Mundt
2007-02-20  4:13           ` Jaya Kumar
2007-02-20  4:38             ` Paul Mundt [this message]
2007-02-20  6:11               ` Jaya Kumar
2007-02-21 16:46                 ` Jaya Kumar
2007-02-20  8:07             ` Geert Uytterhoeven
2007-02-21 16:55               ` Jaya Kumar
2007-02-21 21:52                 ` James Simmons
2007-02-21 23:22                   ` Jaya Kumar
2007-02-28 16:50                     ` [Linux-fbdev-devel] [PATCH 2.6.20 1/1] fbdev, mm: " James Simmons
2007-02-21 23:43                 ` Antonino A. Daplas
2007-02-21 23:47                   ` Jaya Kumar
2007-02-21 23:43             ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070220043848.GA4092@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=jayakumar.lkml@gmail.com \
    --cc=jsimmons@infradead.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --subject='Re: [PATCH 2.6.20 1/1] fbdev,mm: hecuba/E-Ink fbdev driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).