LKML Archive on
help / color / mirror / Atom feed
From: Alan <>
To: David Gibson <>
Cc: Andrew Morton <>, <>,
	<>, <>
Subject: Re: [PATCH 1/2] Define FIXED_PORT flag for serial_core
Date: Tue, 20 Feb 2007 13:07:01 +0000	[thread overview]
Message-ID: <20070220130701.00503673@localhost.localdomain> (raw)
In-Reply-To: <>

On Tue, 20 Feb 2007 14:19:51 +1100 (EST)
David Gibson <> wrote:

> At present, the serial core always allows setserial in userspace to
> change the port address, irq and base clock of any serial port.  That
> makes sense for legacy ISA ports, but not for (say) embedded ns16550
> compatible serial ports at peculiar addresses.  In these cases, the
> kernel code configuring the ports must know exactly where they are,
> and their clocking arrangements (which can be unusual on embedded
> boards).  It doesn't make sense for userspace to change these
> settings.
> Therefore, this patch defines a UPF_FIXED_PORT flag for the uart_port
> structure.  If this flag is set when the serial port is configured,
> any attempts to alter the port's type, io address, irq or base clock
> with setserial are ignored.
> In addition this patch uses the new flag for on-chip serial ports
> probed in arch/powerpc/kernel/legacy_serial.c, and for other
> hard-wired serial ports probed by drivers/serial/of_serial.c.
> Signed-off-by: David Gibson <>
Acked-by: Alan Cox <>

  reply	other threads:[~2007-02-20 12:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-20  3:17 Use resource_size_t for serial MMIO addresses David Gibson
2007-02-20  3:19 ` [PATCH 1/2] Define FIXED_PORT flag for serial_core David Gibson
2007-02-20 13:07   ` Alan [this message]
2007-02-28 22:26   ` Russell King
2007-02-28 23:44     ` David Gibson
2007-03-01 10:30       ` Russell King
2007-03-02  1:57         ` David Gibson
2007-02-20  3:19 ` [PATCH 2/2] Use resource_size_t for serial port IO addresses David Gibson
2007-02-20 13:06   ` Alan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070220130701.00503673@localhost.localdomain \ \ \ \ \ \ \
    --subject='Re: [PATCH 1/2] Define FIXED_PORT flag for serial_core' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).