LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@kvack.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Chris Mason <chris.mason@oracle.com>,
	"Ananiev, Leonid I" <leonid.i.ananiev@intel.com>,
	Zach Brown <zach.brown@oracle.com>,
	linux-aio@kvack.org, linux-kernel@vger.kernel.org,
	Suparna bhattacharya <suparna@in.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event
Date: Tue, 20 Feb 2007 11:06:15 -0500	[thread overview]
Message-ID: <20070220160615.GT31205@kvack.org> (raw)
In-Reply-To: <1171987310.6271.23.camel@heimdal.trondhjem.org>

On Tue, Feb 20, 2007 at 11:01:50AM -0500, Trond Myklebust wrote:
> We don't try to resolve "conflicting" writes between ordinary mmap() and
> write(), so why should we be doing it for mmap and O_DIRECT?

Yes we do -- both writes will succeed.  More importantly, if one modifies 
the first 512 bytes of a page and the other modifies the last 512 bytes of 
the page, both writes will show up in the completed result.  This is not the 
case with the -EIO bailout.

> mmap() is designed to violate the ordinary mutex locks for write(), so
> if a conflict arises, whether it be with O_DIRECT or ordinary writes
> then it is a case of "last writer wins".

Except that we're not handling cases like the one mentioned above, which 
is quite broken.

		-ben
-- 
"Time is of no importance, Mr. President, only life is important."
Don't Email: <dont@kvack.org>.

  reply	other threads:[~2007-02-20 16:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-19 20:35 Zach Brown
2007-02-19 20:47 ` Benjamin LaHaise
2007-02-19 21:07   ` Zach Brown
2007-02-19 20:58 ` Ananiev, Leonid I
2007-02-19 21:50   ` Chris Mason
2007-02-20  0:21     ` Benjamin LaHaise
2007-02-20  0:26       ` Zach Brown
2007-02-20  0:28       ` Chris Mason
2007-02-20 16:01       ` Trond Myklebust
2007-02-20 16:06         ` Benjamin LaHaise [this message]
2007-02-20 16:06         ` Arjan van de Ven
2007-02-20 16:19           ` Chris Mason
2007-02-20 16:08         ` Chris Mason
2007-02-20 16:29           ` Trond Myklebust
2007-02-20 16:38             ` Trond Myklebust
2007-02-20 18:40             ` Zach Brown
2007-02-21  0:05               ` Trond Myklebust
2007-02-20 14:08 ` Ananiev, Leonid I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070220160615.GT31205@kvack.org \
    --to=bcrl@kvack.org \
    --cc=akpm@linux-foundation.org \
    --cc=chris.mason@oracle.com \
    --cc=leonid.i.ananiev@intel.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suparna@in.ibm.com \
    --cc=trond.myklebust@fys.uio.no \
    --cc=zach.brown@oracle.com \
    --subject='Re: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).