LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] libata: Use new id_to_dma_mode function to tidy reporting in more drivers (minimally tested)
@ 2007-02-20 18:15 Alan
2007-02-25 20:57 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Alan @ 2007-02-20 18:15 UTC (permalink / raw)
To: jgarzik, akpm, linux-kernel
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-mm2/drivers/ata/pata_it821x.c linux-2.6.20-mm2/drivers/ata/pata_it821x.c
--- linux.vanilla-2.6.20-mm2/drivers/ata/pata_it821x.c 2007-02-20 13:37:58.000000000 +0000
+++ linux-2.6.20-mm2/drivers/ata/pata_it821x.c 2007-02-20 14:22:10.000000000 +0000
@@ -503,10 +503,12 @@
/* We do need the right mode information for DMA or PIO
and this comes from the current configuration flags */
if (dma_enabled & (1 << (5 + i))) {
+ ata_dev_printk(dev, KERN_INFO, "configured for DMA\n");
dev->xfer_mode = XFER_MW_DMA_0;
dev->xfer_shift = ATA_SHIFT_MWDMA;
dev->flags &= ~ATA_DFLAG_PIO;
} else {
+ ata_dev_printk(dev, KERN_INFO, "configured for PIO\n");
dev->xfer_mode = XFER_PIO_0;
dev->xfer_shift = ATA_SHIFT_PIO;
dev->flags |= ATA_DFLAG_PIO;
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-mm2/drivers/ata/ata_generic.c linux-2.6.20-mm2/drivers/ata/ata_generic.c
--- linux.vanilla-2.6.20-mm2/drivers/ata/ata_generic.c 2007-02-20 13:37:58.000000000 +0000
+++ linux-2.6.20-mm2/drivers/ata/ata_generic.c 2007-02-20 13:42:50.000000000 +0000
@@ -90,10 +90,10 @@
/* We do need the right mode information for DMA or PIO
and this comes from the current configuration flags */
if (dma_enabled & (1 << (5 + i))) {
- dev->xfer_mode = XFER_MW_DMA_0;
- dev->xfer_shift = ATA_SHIFT_MWDMA;
+ ata_id_to_dma_mode(dev, XFER_MW_DMA_0);
dev->flags &= ~ATA_DFLAG_PIO;
} else {
+ ata_dev_printk(dev, KERN_INFO, "configured for PIO\n");
dev->xfer_mode = XFER_PIO_0;
dev->xfer_shift = ATA_SHIFT_PIO;
dev->flags |= ATA_DFLAG_PIO;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libata: Use new id_to_dma_mode function to tidy reporting in more drivers (minimally tested)
2007-02-20 18:15 [PATCH] libata: Use new id_to_dma_mode function to tidy reporting in more drivers (minimally tested) Alan
@ 2007-02-25 20:57 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-02-25 20:57 UTC (permalink / raw)
To: Alan; +Cc: akpm, linux-kernel, IDE/ATA development list
Alan wrote:
> Signed-off-by: Alan Cox <alan@redhat.com>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-25 20:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-20 18:15 [PATCH] libata: Use new id_to_dma_mode function to tidy reporting in more drivers (minimally tested) Alan
2007-02-25 20:57 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).