LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@tv-sign.ru>
To: Christoph Lameter <clameter@sgi.com>
Cc: Max Krasnyansky <maxk@qualcomm.com>, Ingo Molnar <mingo@elte.hu>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
Gautham shenoy <ego@in.ibm.com>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: slab: start_cpu_timer/cache_reap CONFIG_HOTPLUG_CPU problems
Date: Tue, 20 Feb 2007 23:05:50 +0300 [thread overview]
Message-ID: <20070220200550.GA85@tv-sign.ru> (raw)
In-Reply-To: <Pine.LNX.4.64.0702201041340.14643@schroedinger.engr.sgi.com>
On 02/20, Christoph Lameter wrote:
>
> On Tue, 20 Feb 2007, Max Krasnyansky wrote:
>
> > > > Well seems that we have a set of unresolved issues with workqueues and cpu
> > > > hotplug.
> >
> > How about storing 'cpu' explicitly in the work queue instead of relying on the
> > smp_processor_id() and friends ? That way there is no ambiguity when
> > threads/timers get
> > moved around.
>
> The slab functionality is designed to work on the processor with the
> queue. These tricks will only cause more trouble in the future. The
> cache_reaper needs to be either disabled or run on the right processor. It
> should never run on the wrong processor.
I personally agree. Besides, cache_reaper is not alone. Note the comment
in debug_smp_processor_id() about cpu-bound processes. The slab does correct
thing right now, stops the timer on CPU_DEAD. Other problems imho should be
solved by fixing cpu-hotplug. Gautham and Srivatsa are working on that.
Oleg.
next prev parent reply other threads:[~2007-02-20 20:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-29 1:13 Oleg Nesterov
2007-01-29 16:54 ` Christoph Lameter
2007-01-29 17:19 ` Oleg Nesterov
2007-01-29 17:27 ` Christoph Lameter
2007-01-29 18:27 ` Oleg Nesterov
2007-01-29 19:09 ` Christoph Lameter
2007-01-29 19:29 ` Oleg Nesterov
2007-01-29 19:25 ` Christoph Lameter
2007-01-29 19:49 ` Oleg Nesterov
2007-01-29 20:29 ` Christoph Lameter
2007-01-29 21:05 ` Oleg Nesterov
2007-01-29 21:48 ` Christoph Lameter
2007-01-29 22:14 ` Oleg Nesterov
2007-02-20 18:39 ` Max Krasnyansky
2007-02-20 18:45 ` Christoph Lameter
2007-02-20 20:05 ` Oleg Nesterov [this message]
2007-02-20 21:22 ` Max Krasnyansky
2007-02-20 21:35 ` Christoph Lameter
2007-02-20 22:01 ` Max Krasnyansky
2007-02-20 22:14 ` Christoph Lameter
2007-02-20 22:48 ` SLAB cache reaper on isolated cpus Max Krasnyansky
2007-02-20 23:19 ` Christoph Lameter
2007-02-21 3:41 ` Max Krasnyansky
2007-02-20 21:05 ` slab: start_cpu_timer/cache_reap CONFIG_HOTPLUG_CPU problems Max Krasnyansky
2007-02-20 21:34 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070220200550.GA85@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=mingo@elte.hu \
--cc=vatsa@in.ibm.com \
--cc=venkatesh.pallipadi@intel.com \
--subject='Re: slab: start_cpu_timer/cache_reap CONFIG_HOTPLUG_CPU problems' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).