LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
Randy Dunlap <rdunlap@xenotime.net>,
Dave Jones <davej@redhat.com>,
Chuck Wolber <chuckw@quantumlinux.com>,
Chris Wedgwood <reviews@ml.cw.f00f.org>,
Michael Krufky <mkrufky@linuxtv.org>,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
alan@lxorguk.ukuu.org.uk,
Grant Likely <grant.likely@secretlab.ca>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: [patch 02/21] V4L: Fix quickcam communicator driver for big endian architectures
Date: Tue, 20 Feb 2007 17:36:42 -0800 [thread overview]
Message-ID: <20070221013642.GC30227@kroah.com> (raw)
In-Reply-To: <20070221013619.GA30227@kroah.com>
[-- Attachment #1: V4L-Fix-quickcam-communicator-driver-for-big-endian-architectures.patch --]
[-- Type: text/plain, Size: 1309 bytes --]
-stable review patch. If anyone has any objections, please let us know.
------------------
Host endianess does not affect the order that pixel rgb data comes
in from the quickcam (the values are bytes, not words or longs). The
driver is erroniously swapping the order of rgb values for big endian
machines. This patch is needed get the Quickcam communicator working
on big endian machines (tested on powerpc)
(cherry picked from commit c6d704c8c4453f05717ba88792f70f8babf95268)
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/media/video/usbvideo/quickcam_messenger.h | 14 --------------
1 file changed, 14 deletions(-)
--- linux-2.6.19.4.orig/drivers/media/video/usbvideo/quickcam_messenger.h
+++ linux-2.6.19.4/drivers/media/video/usbvideo/quickcam_messenger.h
@@ -35,27 +35,13 @@ struct rgb {
};
struct bayL0 {
-#ifdef __BIG_ENDIAN
- u8 r;
- u8 g;
-#elif __LITTLE_ENDIAN
u8 g;
u8 r;
-#else
-#error not byte order defined
-#endif
};
struct bayL1 {
-#ifdef __BIG_ENDIAN
- u8 g;
- u8 b;
-#elif __LITTLE_ENDIAN
u8 b;
u8 g;
-#else
-#error not byte order defined
-#endif
};
struct cam_size {
--
next prev parent reply other threads:[~2007-02-21 1:38 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070221012758.925122216@mini.kroah.org>
2007-02-21 1:36 ` [patch 00/21] 2.6.19-stable review Greg KH
2007-02-21 1:36 ` [patch 01/21] V4L: cx88: Fix lockup on suspend Greg KH
2007-02-22 1:00 ` Chuck Ebbert
2007-02-22 1:14 ` Michael Krufky
2007-02-21 1:36 ` Greg KH [this message]
2007-02-21 1:36 ` [patch 03/21] V4L: fix ks0127 status flags Greg KH
2007-02-21 1:36 ` [patch 04/21] V4L: tveeprom: autodetect LG TAPC G701D as tuner type 37 Greg KH
2007-02-21 1:37 ` [patch 05/21] V4L: buf_qbuf: fix videobuf_queue->stream corruption and lockup Greg KH
2007-02-21 1:37 ` [patch 06/21] net/smc911x: match up spin lock/unlock Greg KH
2007-02-21 1:37 ` [patch 07/21] rtc-pcf8563: detect polarity of century bit automatically Greg KH
2007-02-21 1:37 ` [patch 08/21] aio: fix buggy put_ioctx call in aio_complete - v2 Greg KH
2007-02-21 1:37 ` [patch 09/21] x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted Greg KH
2007-02-21 1:37 ` [patch 10/21] ide: fix drive side 80c cable check Greg KH
2007-02-21 1:37 ` [patch 11/21] pata_amd: fix an obvious bug in cable detection Greg KH
2007-02-21 1:37 ` [patch 12/21] bcm43xx: Fix for oops on resume Greg KH
2007-02-21 1:38 ` [patch 13/21] bcm43xx: Fix for oops on ampdu status Greg KH
2007-02-21 1:38 ` [patch 14/21] usb-audio: work around wrong frequency in CM6501 descriptors Greg KH
2007-02-21 1:38 ` [patch 15/21] usbaudio - Fix Oops with broken usb descriptors Greg KH
2007-02-21 1:38 ` [patch 16/21] usbaudio - Fix Oops with unconventional sample rates Greg KH
2007-02-21 1:38 ` [patch 17/21] Use different constraint for gcc < 4.1 in bitops Greg KH
2007-02-21 1:38 ` [patch 18/21] prism54: correct assignment of DOT1XENABLE in WE-19 codepaths Greg KH
2007-02-21 1:38 ` [patch 19/21] net, 8139too.c: fix netpoll deadlock Greg KH
2007-02-21 1:38 ` [patch 20/21] Keys: Fix key serial number collision handling Greg KH
2007-02-21 1:39 ` [patch 21/21] knfsd: Fix a race in closing NFSd connections Greg KH
2007-02-21 13:36 ` [patch 00/21] 2.6.19-stable review Stefan Richter
2007-02-21 13:37 ` Stefan Richter
2007-03-09 5:35 ` Adrian Bunk
2007-02-21 16:38 ` Chuck Ebbert
2007-02-21 16:50 ` Chuck Ebbert
2007-02-21 19:31 ` Chuck Ebbert
2007-02-21 19:47 ` Andrew Morton
2007-02-21 20:09 ` Linus Torvalds
2007-02-21 22:45 ` Eric W. Biederman
2007-02-28 6:37 ` Eric W. Biederman
2007-02-28 8:51 ` Zwane Mwaikambo
2007-02-28 12:28 ` Eric W. Biederman
2007-02-28 19:52 ` [stable] " Greg KH
2007-02-28 23:25 ` Eric W. Biederman
2007-02-21 20:13 ` Eric W. Biederman
2007-02-21 20:21 ` Chuck Ebbert
2007-02-21 22:19 ` Andi Kleen
2007-02-21 22:20 ` Andi Kleen
2007-02-21 22:39 ` Chuck Ebbert
2007-02-22 1:19 ` Andi Kleen
2007-02-21 20:39 ` Greg KH
2007-02-21 20:44 ` Chuck Ebbert
2007-02-21 22:33 ` Chuck Ebbert
2007-02-21 22:35 ` Chuck Ebbert
2007-02-21 22:43 ` Chuck Ebbert
2007-02-22 16:09 ` Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070221013642.GC30227@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=chuckw@quantumlinux.com \
--cc=davej@redhat.com \
--cc=grant.likely@secretlab.ca \
--cc=jmforbes@linuxtx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mkrufky@linuxtv.org \
--cc=rdunlap@xenotime.net \
--cc=reviews@ml.cw.f00f.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=zwane@arm.linux.org.uk \
--subject='Re: [patch 02/21] V4L: Fix quickcam communicator driver for big endian architectures' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).