LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@tv-sign.ru>
To: Jarek Poplawski <jarkao2@o2.pl>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	David Howells <dhowells@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check()
Date: Wed, 21 Feb 2007 17:23:42 +0300	[thread overview]
Message-ID: <20070221142342.GB134@tv-sign.ru> (raw)
In-Reply-To: <20070221082345.GB1662@ff.dom.local>

On 02/21, Jarek Poplawski wrote:
>
> > On Wed, 21 Feb 2007 01:19:41 +0300
> > Oleg Nesterov <oleg@tv-sign.ru> wrote:
> > 
> > > +	p = container_of(work, struct net_bridge_port, carrier_check.work);
> > >  
> > >  	rtnl_lock();
> > > -	p = dev->br_port;
> > > -	if (!p)
> > > -		goto done;
> > >  	br = p->br;
> 
> It doesn't matter very much but I think this would look
> better after the first if check.

OK. I can re-send if this patch is otherwise correct.

Oleg.


  parent reply	other threads:[~2007-02-21 14:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-20 22:19 Oleg Nesterov
2007-02-21  0:24 ` Stephen Hemminger
2007-02-21  8:23   ` Jarek Poplawski
2007-02-21  9:29     ` Jarek Poplawski
2007-02-21 14:23     ` Oleg Nesterov [this message]
2007-02-21 18:55       ` [RFT] bridge: eliminate port_check workqueue Stephen Hemminger
2007-02-21 20:09         ` Oleg Nesterov
2007-02-21 21:19           ` Stephen Hemminger
2007-02-21 21:58             ` Oleg Nesterov
2007-02-22  8:46         ` Jarek Poplawski
2007-02-21 14:22   ` [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check() Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070221142342.GB134@tv-sign.ru \
    --to=oleg@tv-sign.ru \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=jarkao2@o2.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    --subject='Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).