LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] EXPORT_SYMBOL() time functions
@ 2007-02-21 13:12 Rolf Eike Beer
  2007-02-21 13:13 ` Rolf Eike Beer
  2007-02-21 13:32 ` Arjan van de Ven
  0 siblings, 2 replies; 6+ messages in thread
From: Rolf Eike Beer @ 2007-02-21 13:12 UTC (permalink / raw)
  To: Andrew Morton
  Cc: linux-kernel, Ingo Molnar, Thomas Gleixner, john stultz,
	Roman Zippel, Jeremy Fitzhardinge

[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]

These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f.
Now EXPORT_SYMBOL() them to allow them to be used in modules again.

Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>

---
commit 0a543599f4a9ea02b587bda26e0e11ae94774f61
tree aa815eab413d2575925b0964a1fa01d41439b26b
parent 6b8afc66b9d6893d3fa292b75769b58539836ff3
author Rolf Eike Beer <eike-kernel@sf-tec.de> Wed, 21 Feb 2007 14:10:12 +0100
committer Rolf Eike Beer <eike-kernel@sf-tec.de> Wed, 21 Feb 2007 14:10:12 +0100

 kernel/time.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/kernel/time.c b/kernel/time.c
index c6c80ea..0b351b2 100644
--- a/kernel/time.c
+++ b/kernel/time.c
@@ -635,6 +635,7 @@ timeval_to_jiffies(const struct timeval *value)
 		(((u64)usec * USEC_CONVERSION + USEC_ROUND) >>
 		 (USEC_JIFFIE_SC - SEC_JIFFIE_SC))) >> SEC_JIFFIE_SC;
 }
+EXPORT_SYMBOL(timeval_to_jiffies);
 
 void jiffies_to_timeval(const unsigned long jiffies, struct timeval *value)
 {
@@ -649,6 +650,7 @@ void jiffies_to_timeval(const unsigned long jiffies, struct timeval *value)
 	tv_usec /= NSEC_PER_USEC;
 	value->tv_usec = tv_usec;
 }
+EXPORT_SYMBOL(jiffies_to_timeval);
 
 /*
  * Convert jiffies/jiffies_64 to clock_t and back.
@@ -723,6 +725,7 @@ u64 nsec_to_clock_t(u64 x)
 #endif
 	return x;
 }
+EXPORT_SYMBOL(nsec_to_clock_t);
 
 #if (BITS_PER_LONG < 64)
 u64 get_jiffies_64(void)

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] EXPORT_SYMBOL() time functions
  2007-02-21 13:12 [PATCH] EXPORT_SYMBOL() time functions Rolf Eike Beer
@ 2007-02-21 13:13 ` Rolf Eike Beer
  2007-02-22  3:40   ` Christoph Hellwig
  2007-02-21 13:32 ` Arjan van de Ven
  1 sibling, 1 reply; 6+ messages in thread
From: Rolf Eike Beer @ 2007-02-21 13:13 UTC (permalink / raw)
  To: Andrew Morton
  Cc: linux-kernel, Ingo Molnar, Thomas Gleixner, john stultz,
	Roman Zippel, Jeremy Fitzhardinge

These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f.
Now EXPORT_SYMBOL() them to allow them to be used in modules again.

Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>

---

Sent once again, this time without PGP signature so importing into git is easier.

commit 0a543599f4a9ea02b587bda26e0e11ae94774f61
tree aa815eab413d2575925b0964a1fa01d41439b26b
parent 6b8afc66b9d6893d3fa292b75769b58539836ff3
author Rolf Eike Beer <eike-kernel@sf-tec.de> Wed, 21 Feb 2007 14:10:12 +0100
committer Rolf Eike Beer <eike-kernel@sf-tec.de> Wed, 21 Feb 2007 14:10:12 +0100

 kernel/time.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/kernel/time.c b/kernel/time.c
index c6c80ea..0b351b2 100644
--- a/kernel/time.c
+++ b/kernel/time.c
@@ -635,6 +635,7 @@ timeval_to_jiffies(const struct timeval *value)
 		(((u64)usec * USEC_CONVERSION + USEC_ROUND) >>
 		 (USEC_JIFFIE_SC - SEC_JIFFIE_SC))) >> SEC_JIFFIE_SC;
 }
+EXPORT_SYMBOL(timeval_to_jiffies);
 
 void jiffies_to_timeval(const unsigned long jiffies, struct timeval *value)
 {
@@ -649,6 +650,7 @@ void jiffies_to_timeval(const unsigned long jiffies, struct timeval *value)
 	tv_usec /= NSEC_PER_USEC;
 	value->tv_usec = tv_usec;
 }
+EXPORT_SYMBOL(jiffies_to_timeval);
 
 /*
  * Convert jiffies/jiffies_64 to clock_t and back.
@@ -723,6 +725,7 @@ u64 nsec_to_clock_t(u64 x)
 #endif
 	return x;
 }
+EXPORT_SYMBOL(nsec_to_clock_t);
 
 #if (BITS_PER_LONG < 64)
 u64 get_jiffies_64(void)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] EXPORT_SYMBOL() time functions
  2007-02-21 13:12 [PATCH] EXPORT_SYMBOL() time functions Rolf Eike Beer
  2007-02-21 13:13 ` Rolf Eike Beer
@ 2007-02-21 13:32 ` Arjan van de Ven
  2007-02-21 14:23   ` Rolf Eike Beer
  1 sibling, 1 reply; 6+ messages in thread
From: Arjan van de Ven @ 2007-02-21 13:32 UTC (permalink / raw)
  To: Rolf Eike Beer
  Cc: Andrew Morton, linux-kernel, Ingo Molnar, Thomas Gleixner,
	john stultz, Roman Zippel, Jeremy Fitzhardinge

On Wed, 2007-02-21 at 14:12 +0100, Rolf Eike Beer wrote:
> These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f.
> Now EXPORT_SYMBOL() them to allow them to be used in modules again.


please do not add random exports without users; exports eat up kernel
size and memory. At minimum specify which mainline modules use the
exports..



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] EXPORT_SYMBOL() time functions
  2007-02-21 13:32 ` Arjan van de Ven
@ 2007-02-21 14:23   ` Rolf Eike Beer
  0 siblings, 0 replies; 6+ messages in thread
From: Rolf Eike Beer @ 2007-02-21 14:23 UTC (permalink / raw)
  To: Arjan van de Ven
  Cc: Andrew Morton, linux-kernel, Ingo Molnar, Thomas Gleixner,
	john stultz, Roman Zippel, Jeremy Fitzhardinge

[-- Attachment #1: Type: text/plain, Size: 632 bytes --]

Arjan van de Ven wrote:
> On Wed, 2007-02-21 at 14:12 +0100, Rolf Eike Beer wrote:
> > These functions were inlines before
> > 8b9365d753d9870bb6451504c13570b81923228f. Now EXPORT_SYMBOL() them to
> > allow them to be used in modules again.
>
> please do not add random exports without users; exports eat up kernel
> size and memory. At minimum specify which mainline modules use the
> exports..

Nothing in mainline now. I just found out that the module I'm writing doesn't 
work anymore as timeval_to_jiffies() disappeared. If this is planned to go 
away from modules I should consider switching to timespec.

Eike

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] EXPORT_SYMBOL() time functions
  2007-02-21 13:13 ` Rolf Eike Beer
@ 2007-02-22  3:40   ` Christoph Hellwig
  2007-02-22  7:28     ` Rolf Eike Beer
  0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2007-02-22  3:40 UTC (permalink / raw)
  To: Rolf Eike Beer
  Cc: Andrew Morton, linux-kernel, Ingo Molnar, Thomas Gleixner,
	john stultz, Roman Zippel, Jeremy Fitzhardinge

On Wed, Feb 21, 2007 at 02:13:38PM +0100, Rolf Eike Beer wrote:
> These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f.
> Now EXPORT_SYMBOL() them to allow them to be used in modules again.

Just because they happened to be inlined that doesn't mean modules should
be using them.  In fact no intree module uses them exactly because they're
not intended to be used by this kind of code.  Please show the code you
want to use this for so we can see what you're really trying to do.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] EXPORT_SYMBOL() time functions
  2007-02-22  3:40   ` Christoph Hellwig
@ 2007-02-22  7:28     ` Rolf Eike Beer
  0 siblings, 0 replies; 6+ messages in thread
From: Rolf Eike Beer @ 2007-02-22  7:28 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Andrew Morton, linux-kernel, Ingo Molnar, Thomas Gleixner,
	john stultz, Roman Zippel, Jeremy Fitzhardinge

[-- Attachment #1: Type: text/plain, Size: 684 bytes --]

Christoph Hellwig wrote:
> On Wed, Feb 21, 2007 at 02:13:38PM +0100, Rolf Eike Beer wrote:
> > These functions were inlines before
> > 8b9365d753d9870bb6451504c13570b81923228f. Now EXPORT_SYMBOL() them to
> > allow them to be used in modules again.
>
> Just because they happened to be inlined that doesn't mean modules should
> be using them.  In fact no intree module uses them exactly because they're
> not intended to be used by this kind of code.  Please show the code you
> want to use this for so we can see what you're really trying to do.

Trying to convert a given user value (in milliseconds) to a timeout. No 
problem doing this with struct timespec.

Eike

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2007-02-22  7:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-21 13:12 [PATCH] EXPORT_SYMBOL() time functions Rolf Eike Beer
2007-02-21 13:13 ` Rolf Eike Beer
2007-02-22  3:40   ` Christoph Hellwig
2007-02-22  7:28     ` Rolf Eike Beer
2007-02-21 13:32 ` Arjan van de Ven
2007-02-21 14:23   ` Rolf Eike Beer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).