LKML Archive on
help / color / mirror / Atom feed
From: Rodolfo Giometti <>
To: Paul Sokolovsky <>
	Richard Purdie <>
Subject: Re: [PATCH 1/1] PXAFB: Support for backlight control
Date: Wed, 21 Feb 2007 17:12:10 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Feb 21, 2007 at 06:00:37PM +0200, Paul Sokolovsky wrote:
>   On the other hand, there's already
> drivers/video/backlight/backlight.c which provides generic BL support,
> implemented using notifier callback for FB core. Moreover, there's

My patch _uses_ that support.

> corgi_bl.c driver which, contrary to its name is a generic driver for
> embedded/PDA device backlight. It essentially subclassses pretty
> abstract backlight.c, and provides good implementation for most BL
> implementation. What you really need to do to use it, is to supply
> single machine-dependent method, set_bl_intensity(). That method is
> usually <10 lines.

I see, but in this manner you need to make a complete file for each
board, while with my patch you can just put few lines into machine's
definition file (a struct and 2 functions).

>   With this in mind, adhoc backlight handlers in pxafb and few other
> drivers are artifacts of older times. And it's sad they are tried to
> be resurrected instead of being removed.

IMHO, the actual backlight support is not so much, infact I'd like to
generalize it to support also backlighted keyboards (or input
devices). :)




GNU/Linux Solutions                  e-mail:
Linux Device Driver                   
Embedded Systems             
UNIX programming                     phone:     +39 349 2432127

  reply	other threads:[~2007-02-21 16:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-21 14:53 Rodolfo Giometti
2007-02-21 16:00 ` Paul Sokolovsky
2007-02-21 16:12   ` Rodolfo Giometti [this message]
2007-02-21 16:26     ` Paul Sokolovsky
2007-02-22  8:32       ` Rodolfo Giometti
2007-02-22 10:33         ` Paul Sokolovsky
2007-02-22 16:37           ` Rodolfo Giometti
2007-02-22 17:11             ` Richard Purdie
2007-02-28 16:54             ` [Linux-fbdev-devel] " James Simmons
2007-02-22  0:59 ` Richard Purdie
2007-02-22  8:28   ` Rodolfo Giometti
2007-02-22  9:27     ` Richard Purdie
2007-02-22  9:32       ` Rodolfo Giometti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 1/1] PXAFB: Support for backlight control' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).