LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rodolfo Giometti <giometti@enneenne.com>
To: Paul Sokolovsky <pmiscml@gmail.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
	linux-kernel@vger.kernel.org,
	linux-fbdev-devel@lists.sourceforge.net,
	Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH 1/1] PXAFB: Support for backlight control
Date: Wed, 21 Feb 2007 17:12:10 +0100	[thread overview]
Message-ID: <20070221161210.GL4641@enneenne.com> (raw)
In-Reply-To: <1056908425.20070221180037@gmail.com>

On Wed, Feb 21, 2007 at 06:00:37PM +0200, Paul Sokolovsky wrote:
> 
>   On the other hand, there's already
> drivers/video/backlight/backlight.c which provides generic BL support,
> implemented using notifier callback for FB core. Moreover, there's

My patch _uses_ that support.

> corgi_bl.c driver which, contrary to its name is a generic driver for
> embedded/PDA device backlight. It essentially subclassses pretty
> abstract backlight.c, and provides good implementation for most BL
> implementation. What you really need to do to use it, is to supply
> single machine-dependent method, set_bl_intensity(). That method is
> usually <10 lines.

I see, but in this manner you need to make a complete file for each
board, while with my patch you can just put few lines into machine's
definition file (a struct and 2 functions).

>   With this in mind, adhoc backlight handlers in pxafb and few other
> drivers are artifacts of older times. And it's sad they are tried to
> be resurrected instead of being removed.

IMHO, the actual backlight support is not so much, infact I'd like to
generalize it to support also backlighted keyboards (or input
devices). :)

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@enneenne.com
Linux Device Driver                             giometti@gnudd.com
Embedded Systems                     		giometti@linux.it
UNIX programming                     phone:     +39 349 2432127

  reply	other threads:[~2007-02-21 16:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-21 14:53 Rodolfo Giometti
2007-02-21 16:00 ` Paul Sokolovsky
2007-02-21 16:12   ` Rodolfo Giometti [this message]
2007-02-21 16:26     ` Paul Sokolovsky
2007-02-22  8:32       ` Rodolfo Giometti
2007-02-22 10:33         ` Paul Sokolovsky
2007-02-22 16:37           ` Rodolfo Giometti
2007-02-22 17:11             ` Richard Purdie
2007-02-28 16:54             ` [Linux-fbdev-devel] " James Simmons
2007-02-22  0:59 ` Richard Purdie
2007-02-22  8:28   ` Rodolfo Giometti
2007-02-22  9:27     ` Richard Purdie
2007-02-22  9:32       ` Rodolfo Giometti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070221161210.GL4641@enneenne.com \
    --to=giometti@enneenne.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmiscml@gmail.com \
    --cc=rpurdie@rpsys.net \
    --subject='Re: [PATCH 1/1] PXAFB: Support for backlight control' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).