LKML Archive on
help / color / mirror / Atom feed
From: Duncan Sands <>
To: Simon Arlott <>
Cc: Linux Kernel Mailing List <>
Subject: Re: [PATCH 1/2] usbatm: Increment module refcount when atm device is opened.
Date: Thu, 22 Feb 2007 10:48:00 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wednesday 21 February 2007 22:36:14 Simon Arlott wrote:
> Increment usbatm driver module refcount when atm device is opened,
> this prevents the driver for the device being removed if it's in use.
> (I continue to allow removing the driver without unplugging the device
> if it's not being used). No problems occur if the atm device is open
> while the device is unplugged.    

What for?  Did you see any problems with the way it works right now?
How it works now is that if the module is unloaded while the device is
in use, then the device is deregistered from the USB and ATM layers
before the module unload completes.  Thus there should be no problem
unloading the device at any moment.  I'm guessing that you want this
because of the better proc support you would like to add, which adds
an extra callback into the module.  This too should cause no problems
as long as the appropriate tweaks are made to the shutdown code.  I
plan to make those adjustments, but I didn't find time yet - sorry.

So this is a nack.

Best wishes,


  reply	other threads:[~2007-02-22  9:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-21 21:36 Simon Arlott
2007-02-22  9:48 ` Duncan Sands [this message]
2007-02-22 19:50   ` Simon Arlott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \
    --subject='Re: [PATCH 1/2] usbatm: Increment module refcount when atm device is opened.' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).