[RFC][PATCH -mm] mmc build fix (was: Re: mm snapshot broken-out-2007-02-21-22-18.tar.gz uploaded)

[RFC][PATCH -mm] mmc build fix (was: Re: mm snapshot broken-out-2007-02-21-22-18.tar.gz uploaded)

[Michal Piotrowski]

Hi,

akpm@linux-foundation.org napisał(a):
> The mm snapshot broken-out-2007-02-21-22-18.tar.gz has been uploaded to
> 
>    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-02-21-22-18.tar.gz
> 
> It contains the following patches against 2.6.21-rc1:
> 

Possible build fix for

drivers/built-in.o: In function `mmc_queue_thread':
/mnt/md0/devel/linux-work5/drivers/mmc/card/queue.c:76: undefined reference to `blk_queue_plugged'
make: *** [.tmp_vmlinux1] Error 1

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)

Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>

--- linux-work5-clean/drivers/mmc/card/queue.c	2007-02-22 16:04:38.000000000 +0100
+++ linux-work5/drivers/mmc/card/queue.c	2007-02-22 16:00:52.000000000 +0100
@@ -73,8 +73,7 @@ static int mmc_queue_thread(void *d)

 		spin_lock_irq(q->queue_lock);
 		set_current_state(TASK_INTERRUPTIBLE);
-		if (!blk_queue_plugged(q))
-			req = elv_next_request(q);
+		req = elv_next_request(q);
 		mq->req = req;
 		spin_unlock_irq(q->queue_lock);

Re: [RFC][PATCH -mm] mmc build fix

[Pierre Ossman]

Michal Piotrowski wrote:
> Hi,
> 
> akpm@linux-foundation.org napisał(a):
>> The mm snapshot broken-out-2007-02-21-22-18.tar.gz has been uploaded to
>>
>>    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-02-21-22-18.tar.gz
>>
>> It contains the following patches against 2.6.21-rc1:
>>
> 
> Possible build fix for
> 
> drivers/built-in.o: In function `mmc_queue_thread':
> /mnt/md0/devel/linux-work5/drivers/mmc/card/queue.c:76: undefined reference to `blk_queue_plugged'
> make: *** [.tmp_vmlinux1] Error 1
> 

Huh? Is blk_queue_plugged() deprecated?


-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org

Re: [RFC][PATCH -mm] mmc build fix

[Andrew Morton]

> On Thu, 22 Feb 2007 22:04:08 +0100 Pierre Ossman <drzeus-mmc@drzeus.cx> wrote:
> Michal Piotrowski wrote:
> > Hi,
> > 
> > akpm@linux-foundation.org napisał(a):
> >> The mm snapshot broken-out-2007-02-21-22-18.tar.gz has been uploaded to
> >>
> >>    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-02-21-22-18.tar.gz
> >>
> >> It contains the following patches against 2.6.21-rc1:
> >>
> > 
> > Possible build fix for
> > 
> > drivers/built-in.o: In function `mmc_queue_thread':
> > /mnt/md0/devel/linux-work5/drivers/mmc/card/queue.c:76: undefined reference to `blk_queue_plugged'
> > make: *** [.tmp_vmlinux1] Error 1
> > 
> 
> Huh? Is blk_queue_plugged() deprecated?
> 

Jens's tree makes it disappear.

I'll worry about this next week when I get back into action.  It could be
that the offending part of git-block.patch is gone by then.