LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>, stable@kernel.org
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>
Subject: Re: [patch 03/18] Dont leak NT bit into next task
Date: Thu, 22 Feb 2007 16:29:38 +0100	[thread overview]
Message-ID: <20070222152938.GP13958@stusta.de> (raw)
In-Reply-To: <erh57g$oeb$1@sea.gmane.org>

On Wed, Feb 21, 2007 at 11:00:15AM +0100, Giuseppe Bilotta wrote:
> On Wednesday 21 February 2007 02:49, Greg KH wrote:
> 
> >  /* frame pointer must be last for get_wchan */
> > -#define SAVE_CONTEXT    "pushq %%rbp ; movq %%rsi,%%rbp\n\t"
> > -#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp\n\t"
> > +#define SAVE_CONTEXT    "pushf ; pushq %%rbp ; movq %%rsi,%%rbp\n\t"
> > +#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp ; popf\t"
> 
> No idea if this is a problem or not, but you forgot a \n after popf.

A discussion of this issue is in the thread starting with [1]
(and I'd re-add the \n in -stable kernels with the patch below 
 (stolen from 2.6.16) no matter what happened in Linus' tree).

> Giuseppe "Oblomov" Bilotta

cu
Adrian

[1] http://lkml.org/lkml/2007/1/8/374


commit e02612a14b2b714e9d231d14c91e729f0f168299
Author: Adrian Bunk <bunk@stusta.de>
Date:   Tue Jan 9 03:36:59 2007 +0100

    x86_64: re-add a newline to RESTORE_CONTEXT
    
    RESTORE_CONTEXT lost a newline:
    http://www.mail-archive.com/kgdb-bugreport@lists.sourceforge.net/msg00559.html
    
    Reported by Steven M. Christey.
    
    Signed-off-by: Adrian Bunk <bunk@stusta.de>

diff --git a/include/asm-x86_64/system.h b/include/asm-x86_64/system.h
index 7b2c7aa..dacec59 100644
--- a/include/asm-x86_64/system.h
+++ b/include/asm-x86_64/system.h
@@ -21,7 +21,7 @@
 
 /* frame pointer must be last for get_wchan */
 #define SAVE_CONTEXT    "pushf ; pushq %%rbp ; movq %%rsi,%%rbp\n\t"
-#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp ; popf\t"
+#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp ; popf\n\t"
 
 #define __EXTRA_CLOBBER  \
 	,"rcx","rbx","rdx","r8","r9","r10","r11","r12","r13","r14","r15"

  parent reply	other threads:[~2007-02-22 15:29 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070221014413.282048309@mini.kroah.org>
2007-02-21  1:49 ` [patch 00/18] 2.6.18-stable review Greg KH
2007-02-21  1:49   ` [patch 01/18] bcm43xx: Fix for oops on resume Greg KH
2007-02-23  5:25     ` Pavel Machek
2007-02-25  2:30       ` Larry Finger
2007-02-25  8:53         ` Andrew Morton
2007-02-21  1:49   ` [patch 02/18] bcm43xx: Fix for oops on ampdu status Greg KH
2007-02-21  1:49   ` [patch 03/18] Dont leak NT bit into next task Greg KH
2007-02-21 10:00     ` Giuseppe Bilotta
2007-02-21 17:14       ` Jan Engelhardt
2007-02-21 17:20       ` Chuck Ebbert
2007-02-22 15:29       ` Adrian Bunk [this message]
2007-02-22 16:56         ` Andi Kleen
2007-02-21  1:50   ` [patch 04/18] SCSI: add missing cdb clearing in scsi_execute() Greg KH
2007-02-21  1:50   ` [patch 05/18] IB/srp: Fix FMR mapping for 32-bit kernels and addresses above 4G Greg KH
2007-02-21  1:50   ` [patch 06/18] i2c: fix broken ds1337 initialization Greg KH
2007-02-21  1:50   ` [patch 07/18] grow_buffers() infinite loop fix (CVE-2006-5757, CVE-2006-6060) Greg KH
2007-02-21  1:50   ` [patch 08/18] hfs_fill_super returns success even if no root inode (CVE-2006-6056) Greg KH
2007-02-21  1:50   ` [patch 09/18] IB/mad: Fix race between cancel and receive completion Greg KH
2007-02-21  1:50   ` [patch 10/18] dvb-core: fix bug in CRC-32 checking on 64-bit systems Greg KH
2007-02-21  1:50   ` [patch 11/18] v4l: cx2341x audio_properties is an u16, not u8 Greg KH
2007-02-21  1:50   ` [patch 12/18] v4l: cx88: Fix leadtek_eeprom tagging Greg KH
2007-02-21  1:51   ` [patch 13/18] V4L: cx88: Fix lockup on suspend Greg KH
2007-02-22  1:14     ` Michael Krufky
2007-02-23 23:50       ` Greg KH
2007-02-21  1:51   ` [patch 14/18] V4L: Fix quickcam communicator driver for big endian architectures Greg KH
2007-02-21  1:51   ` [patch 15/18] V4L: fix ks0127 status flags Greg KH
2007-02-21  1:51   ` [patch 16/18] V4L: tveeprom: autodetect LG TAPC G701D as tuner type 37 Greg KH
2007-02-21  1:51   ` [patch 17/18] V4L: buf_qbuf: fix videobuf_queue->stream corruption and lockup Greg KH
2007-02-21  1:51   ` [patch 18/18] x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted Greg KH
2007-02-21 11:55   ` [patch 00/18] 2.6.18-stable review S.Çağlar Onur
2007-02-21 17:34     ` [stable] " Greg KH
2007-02-21 18:30       ` S.Çağlar Onur
2007-02-21 18:45       ` Ismail Dönmez
2007-02-22  5:42       ` Willy Tarreau
2007-02-26  0:00       ` Adrian Bunk
2007-02-26  0:18     ` Adrian Bunk
2007-03-05 13:44       ` S.Çağlar Onur
2007-03-05 19:26         ` Greg KH
2007-03-05 20:13           ` S.Çağlar Onur
2007-02-23 20:21   ` Hugh Dickins
2007-02-23 20:34     ` [stable] " Chris Wright
2007-02-23 21:13       ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070222152938.GP13958@stusta.de \
    --to=bunk@stusta.de \
    --cc=ak@suse.de \
    --cc=giuseppe.bilotta@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    --subject='Re: [patch 03/18] Dont leak NT bit into next task' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).