LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Duncan Sands <duncan.sands@math.u-psud.fr>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Simon Arlott <254ad70138dc1cdf241hjzcr0007jhhw@thunder.lp0.eu>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-usb-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/2] usbatm: Detect usb device shutdown and ignore failed urbs.
Date: Fri, 23 Feb 2007 10:36:13 +0100	[thread overview]
Message-ID: <200702231036.14048.duncan.sands@math.u-psud.fr> (raw)
In-Reply-To: <20070222155318.19b423a9.zaitcev@redhat.com>

Hi Pete,

On Friday 23 February 2007 00:53:18 Pete Zaitcev wrote:
> On Thu, 22 Feb 2007 11:43:38 +0100, Duncan Sands <duncan.sands@math.u-psud.fr> wrote:
> > > +		/* the module/device has probably been removed */
> > > +		if (urb->status == -ESHUTDOWN)
> > > +			return;
> > > +
> > >  		if (printk_ratelimit())
> > >  			atm_warn(channel->usbatm, "%s: urb 0x%p failed (%d)!\n",
> > >  				__func__, urb, urb->status);
> > 
> > I would rather just suppress the warning in this case, and still do the delayed
> > schedule of the tasklet, in case this error was spurious and we're not really
> > about to be disconnected.
> 
> I disagree. If ESHUTDOWN is received, the endpoint is definitely gone.
> I can see why you might want to retry EPROTO, ELISEQ, etc. but this
> case is different.

if you get ESHUTDOWN, does that mean that you are about to be disconnected,
i.e. the disconnect method is about to be called?  Or is it possible for the
device to just sit there disabled, but not disconnected?

Thanks,

Duncan.

  reply	other threads:[~2007-02-23  9:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-21 21:39 Simon Arlott
2007-02-22 10:43 ` Duncan Sands
2007-02-22 23:53   ` Pete Zaitcev
2007-02-23  9:36     ` Duncan Sands [this message]
2007-02-23 16:16       ` [linux-usb-devel] " Alan Stern
2007-02-23 17:05         ` Duncan Sands
2007-02-23 18:11           ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702231036.14048.duncan.sands@math.u-psud.fr \
    --to=duncan.sands@math.u-psud.fr \
    --cc=254ad70138dc1cdf241hjzcr0007jhhw@thunder.lp0.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=zaitcev@redhat.com \
    --subject='Re: [PATCH 2/2] usbatm: Detect usb device shutdown and ignore failed urbs.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).