LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Brown <broonie@sirena.org.uk>
To: Bob Tracy <rct@gherkin.frus.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Tim Hockin <thockin@hockin.org>, Jeff Garzik <jgarzik@pobox.com>,
	Adrian Bunk <bunk@stusta.de>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: natsemi: Fix detection of vanilla natsemi cards
Date: Fri, 23 Feb 2007 14:26:22 +0000	[thread overview]
Message-ID: <20070223142621.GD9282@sirena.org.uk> (raw)
In-Reply-To: <20070223134740.E5ECADBA1@gherkin.frus.com>

On Fri, Feb 23, 2007 at 07:47:40AM -0600, Bob Tracy wrote:

> ACK except for a missing comma at the end of the line being replaced,
> which prevents the patch from applying cleanly.  Otherwise, this fixes
> the problem I was having.  Thanks!

Aargh.

--- linux.orig/drivers/net/natsemi.c	2007-02-23 11:13:03.000000000 +0000
+++ linux/drivers/net/natsemi.c	2007-02-23 11:12:00.000000000 +0000
@@ -260,7 +260,7 @@
 
 static const struct pci_device_id natsemi_pci_tbl[] __devinitdata = {
 	{ PCI_VENDOR_ID_NS, 0x0020, 0x12d9,     0x000c,     0, 0, 0 },
-	{ PCI_VENDOR_ID_NS, 0x0020, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
+	{ PCI_VENDOR_ID_NS, 0x0020, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1 },
 	{ }	/* terminate list */
 };
 MODULE_DEVICE_TABLE(pci, natsemi_pci_tbl);

-- 
"You grabbed my hand and we fell into it, like a daydream - or a fever."

  reply	other threads:[~2007-02-23 14:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070223020920.b9528e0e.akpm@linux-foundation.org>
2007-02-23 11:32 ` Mark Brown
2007-02-23 13:47   ` Bob Tracy
2007-02-23 14:26     ` Mark Brown [this message]
2007-02-25 15:37 Mark Brown
2007-02-27  9:31 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070223142621.GD9282@sirena.org.uk \
    --to=broonie@sirena.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@stusta.de \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rct@gherkin.frus.com \
    --cc=thockin@hockin.org \
    --subject='Re: natsemi: Fix detection of vanilla natsemi cards' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).