LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net> To: akpm@osdl.org, jens.axboe@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, gregkh@novell.com Subject: [Patch 2/2] cciss: supercedes add shutdown support (replaces reboot notifier) Date: Fri, 23 Feb 2007 14:42:39 -0600 [thread overview] Message-ID: <20070223204239.GA10570@beardog.cca.cpqcorp.net> (raw) Patch 2/2 This patch supercedes yesterdays cciss-shutdown patch. The primary difference is removing __devexit from cciss_remove_one. Instead of create another function I'd rather use the code that was intended to perform the cleanup and cache flush. I've tested as a loadable module and statically linked without error. Please consider this for inclusion. Signed-off-by: Mike Miller <mike.miller@hp.com> ------------------------------------------------------------------------------------------ diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 9d84ab3..b16f48c 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c @@ -3404,7 +3404,7 @@ #endif return -1; } -static void __devexit cciss_remove_one(struct pci_dev *pdev) +static void cciss_remove_one(struct pci_dev *pdev) { ctlr_info_t *tmp_ptr; int i, j; @@ -3428,9 +3428,10 @@ static void __devexit cciss_remove_one(s memset(flush_buf, 0, 4); return_code = sendcmd(CCISS_CACHE_FLUSH, i, flush_buf, 4, 0, 0, 0, NULL, TYPE_CMD); - if (return_code != IO_OK) { - printk(KERN_WARNING "Error Flushing cache on controller %d\n", - i); + if (return_code == IO_OK) { + printk(KERN_WARNING "Completed flushing cache on controller %d\n", i); + } else { + printk(KERN_WARNING "Error flushing cache on controller %d\n", i); } free_irq(hba[i]->intr[2], hba[i]); @@ -3481,6 +3482,7 @@ static struct pci_driver cciss_pci_drive .probe = cciss_init_one, .remove = __devexit_p(cciss_remove_one), .id_table = cciss_pci_device_id, /* id_table */ + .shutdown = cciss_remove_one, }; /*
next reply other threads:[~2007-02-23 20:42 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-02-23 20:42 Mike Miller (OS Dev) [this message] 2007-02-23 21:32 ` [Patch 2/2] cciss: supercedes add shutdown support (replaces reboot notifier) Greg KH 2007-02-23 21:44 ` Mike Miller (OS Dev) 2007-02-27 20:26 ` Andrew Morton 2007-03-05 22:06 ` [Patch 2/2] cciss: add struct pci_driver " Mike Miller (OS Dev)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070223204239.GA10570@beardog.cca.cpqcorp.net \ --to=mikem@beardog.cca.cpqcorp.net \ --cc=akpm@osdl.org \ --cc=gregkh@novell.com \ --cc=jens.axboe@oracle.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).