LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vojtech Pavlik <vojtech@suse.cz>
To: Milind Choudhary <milindchoudhary@gmail.com>
Cc: kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org,
	dmitry.torokhov@gmail.com, linux-input@atrey.karlin.mff.cuni.cz,
	linux-joystick@atrey.karlin.mff.cuni.cz
Subject: Re: [KJ][RFC][PATCH] BIT macro cleanup
Date: Sat, 24 Feb 2007 11:46:38 +0100	[thread overview]
Message-ID: <20070224104638.GA3609@suse.cz> (raw)
In-Reply-To: <3b44d3fb0702230014x4ee4a1dewdc624c54b3635e15@mail.gmail.com>

On Fri, Feb 23, 2007 at 01:44:41PM +0530, Milind Choudhary wrote:
> Hi all
> 	working towards the cleanup of BIT macro,
> I've added one to <linux/bitops.h> & cleaned some obvious users.
> 
> include/linux/input.h also has a BIT macro
> which does a wrap
> so currently i've done something like
> 
> +#undef BIT
> #define BIT(nr)        (1UL << ((nr) % BITS_PER_LONG))
 
Since the previous definition of

#define BIT(nr)		(1UL << (nr))

gives the same results as the above one for all reasonable usage
scenarios (you don't want to supply nr larger than BITS_PER_LONG),
why not just use the modulo version everywhere?

The only problem I see is that the compiler would not warn where nr IS
too large.

-- 
Vojtech Pavlik
Director SuSE Labs

      parent reply	other threads:[~2007-02-24 10:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3b44d3fb0702222056k1d2a9b57q69a3555a09a9058e@mail.gmail.com>
2007-02-23  8:14 ` Milind Choudhary
2007-02-23  8:56   ` Richard Knutsson
2007-02-23 10:15     ` Milind Choudhary
2007-02-23 14:10       ` Richard Knutsson
2007-02-23 14:57         ` Dmitry Torokhov
2007-02-23 16:08           ` Richard Knutsson
2007-02-23 17:05             ` Dmitry Torokhov
2007-02-23 18:15               ` Richard Knutsson
2007-02-23 18:37                 ` Dmitry Torokhov
2007-02-23 19:11                   ` Richard Knutsson
2007-02-23 21:58                     ` Dmitry Torokhov
2007-02-23 22:43                       ` Richard Knutsson
2007-02-24 11:11                         ` Vojtech Pavlik
2007-02-24 12:59                           ` Richard Knutsson
2007-02-25  3:39                             ` Dmitry Torokhov
2007-02-24 19:11                           ` Milind Arun Choudhary
2007-02-25 15:45                             ` Richard Knutsson
2007-02-25  3:37                           ` Dmitry Torokhov
2007-02-24 10:46   ` Vojtech Pavlik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070224104638.GA3609@suse.cz \
    --to=vojtech@suse.cz \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-joystick@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=milindchoudhary@gmail.com \
    --subject='Re: [KJ][RFC][PATCH] BIT macro cleanup' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).