LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: Tejun Heo <htejun@gmail.com>,
linux-ide@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Komuro <komurojun-mbn@nifty.com>
Subject: Re: [PATCH] libata: clear drvdata in ata_host_release()
Date: Sun, 25 Feb 2007 13:28:55 +0000 [thread overview]
Message-ID: <20070225132855.324a0b36@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <45E0EB9F.3050001@garzik.org>
On Sat, 24 Feb 2007 20:51:27 -0500
Jeff Garzik <jeff@garzik.org> wrote:
> Tejun Heo wrote:
> > ata_host_release() uses drvdata to determine ata_host to release and
> > clearing drvdata in ->remove_one causes NULL pointer deference. Clear
> > drvdata only in ata_host_release() after all resources are freed.
> >
> > This bug was first analyzed by Alan Cox for pata_pcmcia.
> >
> > Signed-off-by: Tejun Heo <htejun@gmail.com>
> > Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> > ---
> > Alan, this is the bug you talked about, right? I took the fix from
> > "[BUG] PATA_PCMCIA does not work" and expanded it. If this isn't the
> > one, please let me know. Thanks.
>
> Has a tester confirmed that this patch fixes the problem, and supercedes
> Alan's patch?
It doesn't appear to, instead it fixes further cases.
next prev parent reply other threads:[~2007-02-25 12:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070224074823.GA20322@htj.dyndns.org>
2007-02-25 1:51 ` Jeff Garzik
2007-02-25 13:28 ` Alan [this message]
2007-02-27 13:33 ` [PATCH] libata: clear drvdata in ata_host_release(), take#2 Tejun Heo
2007-03-02 1:16 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070225132855.324a0b36@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=komurojun-mbn@nifty.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH] libata: clear drvdata in ata_host_release()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).