LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] kconfig: abort configuration with recursive dependencies
@ 2007-02-25 23:18 Adrian Bunk
  0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2007-02-25 23:18 UTC (permalink / raw)
  To: zippel, Andrew Morton; +Cc: kbuild-devel, linux-kernel

A recursive kconfig dependency is a bug that has to be fixed, and that 
might currently not be noted until booting the built kernel.

Currently, the warning that a recursive dependency was detected scrolls 
away during "make oldconfig", and often people don't notice until they 
booted the kernel and note something like "Why is there no IPV6 support?".

This patch therefore lets the configuration fail if kconfig found a 
recursive dependency.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.20-mm2/scripts/kconfig/symbol.c.old	2007-02-25 19:27:07.000000000 +0100
+++ linux-2.6.20-mm2/scripts/kconfig/symbol.c	2007-02-25 19:30:32.000000000 +0100
@@ -792,7 +792,7 @@
 	struct property *prop;
 
 	if (sym->flags & SYMBOL_CHECK) {
-		printf("Warning! Found recursive dependency: %s", sym->name);
+		printf("Error: Found recursive dependency: %s", sym->name);
 		return sym;
 	}
 	if (sym->flags & SYMBOL_CHECKED)
@@ -820,7 +820,7 @@
 		printf(" %s", sym->name);
 		if (sym2 == sym) {
 			printf("\n");
-			sym2 = NULL;
+			exit(1);
 		}
 	}
 	sym->flags &= ~SYMBOL_CHECK;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-02-25 23:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-25 23:18 [2.6 patch] kconfig: abort configuration with recursive dependencies Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).