LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: Jiri Kosina <jikos@jikos.cz>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.21-rc1 dims my LCD
Date: Mon, 26 Feb 2007 12:20:35 -0300	[thread overview]
Message-ID: <20070226152035.GB2909@khazad-dum.debian.net> (raw)
In-Reply-To: <1172501357.5824.91.camel@localhost.localdomain>

On Mon, 26 Feb 2007, Richard Purdie wrote:
> > Richard, would you like a patch to -ENOSYS if a display power management
> > event reaches ibm-acpi?
> 
> The ibm backlight driver should really try and work with the system a
> little more. Even if it can't turn the display off, the power attribute
> should  minimise power usage as best it can. If that means just dimming
> the display, so be it. Ideally, I'd still prefer for it to gain support
> for turning the display off.

Well, the thinkpad firmware doesn't know how to turn the backlight off, or
doesn't export that AFAIK.  It *can* do it in hardware (cuts power to the
inverter or somesuch in the lid switch, etc) but I know of no way to do it
using the firmware.  If I ever find a way, I will certainly add it.

The video card *can* do it, but we are talking either intel fb or radeon fb
here, I'd need a way to communicate with them, or they should be getting the
same events and doing it anyway.

> In the update_status function, there are three sources of information
> you need to combine:
> 
> bd->props.brightness
> bd->props.power
> bd->props.fb_blank
> 
> Since the backlight class doesn't know the capabilities of the hardware,
> it is left to each implementation to combine these options in a way that
> makes sense. Currently ibm just looks at the first one but it could dim
> if the latter two are anything other than FB_BLANK_UNBLANK. See corgi_bl
> as an example (which also looks at its own variables too).

I will implement that, and as usual I will request your ACK since it deals
with your subsystem too.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  reply	other threads:[~2007-02-26 15:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-26  0:59 Jiri Kosina
2007-02-26 11:41 ` Richard Purdie
2007-02-26 12:35   ` Jiri Kosina
2007-02-26 14:21     ` Henrique de Moraes Holschuh
2007-02-26 14:49       ` Richard Purdie
2007-02-26 15:20         ` Henrique de Moraes Holschuh [this message]
2007-02-26 16:12           ` [PATCH] ACPI: ibm-acpi: improve backlight power handling Henrique de Moraes Holschuh
2007-02-26 16:38             ` Richard Purdie
2007-02-26 18:12               ` Henrique de Moraes Holschuh
2007-02-26 18:26                 ` [PATCH] ACPI: ibm-acpi: improve backlight power handling (v2) Henrique de Moraes Holschuh
2007-02-26 21:25                   ` Jiri Kosina
2007-02-26 21:42                     ` Richard Purdie
2007-02-26 21:46                       ` Henrique de Moraes Holschuh
2007-02-26 21:53                   ` Richard Purdie
2007-02-26 17:21             ` [PATCH] ACPI: ibm-acpi: improve backlight power handling Jiri Kosina
2007-02-26 18:17               ` Henrique de Moraes Holschuh
2007-02-26 15:24         ` 2.6.21-rc1 dims my LCD Jiri Kosina
2007-02-26 15:43           ` Richard Purdie
2007-02-26 17:13             ` [Linux-fbdev-devel] " Antonino A. Daplas
2007-02-26 16:03           ` Henrique de Moraes Holschuh
2007-02-26 17:01             ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070226152035.GB2909@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=jikos@jikos.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    --subject='Re: 2.6.21-rc1 dims my LCD' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).