LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@kvack.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jiri Slaby <jirislaby@gmail.com>, Uwe Bugla <uwe.bugla@gmx.de>,
	akpm@linux-foundation.org, bunk@stusta.de,
	linux-kernel@vger.kernel.org,
	Stephane Eranian <eranian@hpl.hp.com>, Andi Kleen <ak@suse.de>
Subject: Re: bug in kernel 2.6.21-rc1-git1: conventional floppy drive cannot be mounted without hanging up the whole system
Date: Mon, 26 Feb 2007 11:34:29 -0500	[thread overview]
Message-ID: <20070226163429.GL26583@kvack.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0702260741040.12485@woody.linux-foundation.org>

On Mon, Feb 26, 2007 at 07:51:19AM -0800, Linus Torvalds wrote:
> > Commit: 2ff2d3d74705d34ab71b21f54634fcf50d57bdd5
> > Author: Stephane Eranian <eranian@hpl.hp.com> Tue, 13 Feb 2007 13:26:22 +0100
> > 
> >     [PATCH] i386: add idle notifier
> 
> Interesting. It doesn't touch floppy at all, but it *does* seem to play 
> around with irq state. 

Side note: this patch adds several function calls (4), several additional 
L1 cache touches and a generally inefficient code path to *every single 
interrupt that exits from the idle poll*, not to mention the extra (useless, 
as it doesn't get used on 99.9% of deployed systems) function call and cache 
touches to every single interrupt.  Keep in mind that systems acting as 
routers will often be sitting in the idle loop when processing interrupts.  
At the very least this overhead (which is noticable on profiles) should be 
configurable.  I don't think that my 586 class embedded routers really need 
this crap to be going into the kernel.

		-ben
-- 
"Time is of no importance, Mr. President, only life is important."
Don't Email: <zyntrop@kvack.org>.

  parent reply	other threads:[~2007-02-26 16:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-24 17:54 Uwe Bugla
2007-02-24 18:07 ` Andrew Morton
2007-02-24 18:29   ` Uwe Bugla
2007-02-24 19:23   ` Uwe Bugla
2007-02-24 19:49     ` Ray Lee
2007-02-26 10:38 ` Jiri Slaby
2007-02-26 15:12   ` Jiri Slaby
2007-02-26 15:51     ` Linus Torvalds
2007-02-26 16:28       ` Jiri Slaby
2007-02-26 16:34       ` Benjamin LaHaise [this message]
2007-02-26 17:10         ` Linus Torvalds
2007-02-26 17:45           ` Stephane Eranian
2007-02-26 17:28       ` Stephane Eranian
2007-02-26 17:37         ` Linus Torvalds
2007-02-25 18:29 Uwe Bugla
2007-02-25 21:04 ` Alexey Dobriyan
2007-02-26  3:55 ` Mike Galbraith
2007-02-26 18:06 Oleg Nesterov
2007-02-26 18:13 ` Linus Torvalds
2007-02-26 20:55   ` Rene Herman
2007-02-26 21:14     ` Linus Torvalds
2007-02-28  2:42       ` Bill Davidsen
2007-02-28 13:04         ` Alan
2007-02-28 12:20           ` Rene Herman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070226163429.GL26583@kvack.org \
    --to=bcrl@kvack.org \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@stusta.de \
    --cc=eranian@hpl.hp.com \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=uwe.bugla@gmx.de \
    --subject='Re: bug in kernel 2.6.21-rc1-git1: conventional floppy drive cannot be mounted without hanging up the whole system' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).