LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org,
	Greg KH <greg@kroah.com>
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, David Brownell <david-b@pacbell.net>
Subject: [patch 7/9] USB: usbnet driver bugfix
Date: Mon, 26 Feb 2007 16:06:39 -0800	[thread overview]
Message-ID: <20070227000639.GH6283@kroah.com> (raw)
In-Reply-To: <20070227000538.GA6283@kroah.com>

[-- Attachment #1: usb-usbnet-driver-bugfix.patch --]
[-- Type: text/plain, Size: 1335 bytes --]

-stable review patch.  If anyone has any objections, please let us know.

------------------
From: David Brownell <david-b@pacbell.net>

The attached fixes an oops in the usbnet driver. The same patch is
in 2.6.21-rc1, but that one has many whitespace changes. This is much
smaller.


Signed-off-by: David Brownell <david-b@pacbell.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/usb/net/usbnet.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

--- linux-2.6.19.5.orig/drivers/usb/net/usbnet.c
+++ linux-2.6.19.5/drivers/usb/net/usbnet.c
@@ -1181,6 +1181,9 @@ usbnet_probe (struct usb_interface *udev
 	// NOTE net->name still not usable ...
 	if (info->bind) {
 		status = info->bind (dev, udev);
+		if (status < 0)
+			goto out1;
+
 		// heuristic:  "usb%d" for links we know are two-host,
 		// else "eth%d" when there's reasonable doubt.  userspace
 		// can rename the link if it knows better.
@@ -1207,12 +1210,12 @@ usbnet_probe (struct usb_interface *udev
 	if (status == 0 && dev->status)
 		status = init_status (dev, udev);
 	if (status < 0)
-		goto out1;
+		goto out3;
 
 	if (!dev->rx_urb_size)
 		dev->rx_urb_size = dev->hard_mtu;
 	dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1);
-	
+
 	SET_NETDEV_DEV(net, &udev->dev);
 	status = register_netdev (net);
 	if (status)

--

  parent reply	other threads:[~2007-02-27  0:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070226235248.438556696@mini.kroah.org>
2007-02-27  0:05 ` [patch 0/9] 2.6.19-stable review Greg KH
2007-02-27  0:06   ` [patch 1/9] fix umask when noACL kernel meets extN tuned for ACLs Greg KH
2007-02-27  0:28     ` Andreas Gruenbacher
2007-02-27  0:06   ` [patch 2/9] Backport of psmouse suspend/shutdown cleanups Greg KH
2007-02-27  0:06   ` [patch 3/9] fix memory corruption from misinterpreted bad_inode_ops return values (CVE-2006-5753) Greg KH
2007-02-27  0:06   ` [patch 4/9] netpoll: drivers must not enable IRQ unconditionally in their NAPI handler Greg KH
2007-02-27  0:06   ` [patch 5/9] hda-intel - Dont try to probe invalid codecs Greg KH
2007-02-27  0:06   ` [patch 6/9] Fix oops when Windows server sent bad domain name null terminator Greg KH
2007-02-27  0:06   ` Greg KH [this message]
2007-02-27  0:06   ` [patch 8/9] hda-codec - Dont return error at initialization of modem codec Greg KH
2007-02-27  0:06   ` [patch 9/9] Missing critical phys_to_virt in lib/swiotlb.c Greg KH
2007-02-27  2:47   ` [patch 0/9] 2.6.19-stable review (mmc: Power quirk for ENE controllers) Darren Salt
2007-02-27 20:23   ` [patch 0/9] 2.6.19-stable review Michael Krufky
2007-03-03  1:23     ` Greg KH
2007-03-03  1:48       ` Michael Krufky
2007-03-03  7:48         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070227000639.GH6283@kroah.com \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=david-b@pacbell.net \
    --cc=greg@kroah.com \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).