LKML Archive on
help / color / mirror / Atom feed
From: Andrew Morton <>
To: "Mike Miller (OS Dev)" <>
Subject: Re: [Patch 2/2] cciss: supercedes add shutdown support (replaces reboot notifier)
Date: Tue, 27 Feb 2007 12:26:34 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

> On Fri, 23 Feb 2007 14:42:39 -0600 "Mike Miller (OS Dev)" <> wrote:
> This patch supercedes yesterdays cciss-shutdown patch. The primary difference is
> removing __devexit from cciss_remove_one. Instead of create another function I'd
> rather use the code that was intended to perform the cleanup and cache flush. I've
> tested as a loadable module and statically linked without error.
> Please consider this for inclusion.

Please don't document patches like this.

The entirety of your changelog and the Subject: are relative to a patch
which will never hit the mainline git tree.  Put yourself in the position
of someone reading the git changelogs in a year's time.  They're going to
be left scratching their heads at the above, aren't they?

Always include a complete and standalone, not-referential-to-an-old-patch
changelog in each iteration of a patch.

Always choose a suitable Subject:

Yes, it's good to tell us things about how this patch differs from the
previous one.  That info can be placed after the ^--- which comes after
your signed-off-by:, or can be placed at the top of the email, as long as
the full permanent changelog is there too.

Bottom line: you are submitting code and its documentation into the
permanent kernel record, not just the mailing list.  Try to make it
appropriate, thanks.

Please send a new Subject: and changlog for this patch.

  parent reply	other threads:[~2007-02-27 20:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-23 20:42 [Patch 2/2] cciss: supercedes add shutdown support (replaces reboot notifier) Mike Miller (OS Dev)
2007-02-23 21:32 ` Greg KH
2007-02-23 21:44   ` Mike Miller (OS Dev)
2007-02-27 20:26 ` Andrew Morton [this message]
2007-03-05 22:06   ` [Patch 2/2] cciss: add struct pci_driver " Mike Miller (OS Dev)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).